WARNING: function definition argument 'const struct xt_mtchk_param *' should also have an identifier name #48: FILE: include/linux/netfilter/x_tables.h:150: + int (*check_hooks)(const struct xt_mtchk_param *); WARNING: function definition argument 'const struct xt_tgchk_param *' should also have an identifier name #58: FILE: include/linux/netfilter/x_tables.h:194: + int (*check_hooks)(const struct xt_tgchk_param *); CHECK: Comparison to NULL could be written "par->match->check_hooks" #117: FILE: net/netfilter/x_tables.c:553: + if (par->match->check_hooks != NULL) CHECK: Comparison to NULL could be written "par->target->check_hooks" #166: FILE: net/netfilter/x_tables.c:1100: + if (par->target->check_hooks != NULL) WARNING: line length of 98 exceeds 80 columns #314: FILE: net/netfilter/xt_addrtype.c:183: + const char *errmsg = "both incoming and outgoing interface limitation cannot be selected"; CHECK: spaces preferred around that '|' (ctx:VxV) #473: FILE: net/netfilter/xt_policy.c:156: + if (!(info->flags & (XT_POLICY_MATCH_IN|XT_POLICY_MATCH_OUT))) ^ total: 0 errors, 3 warnings, 3 checks, 463 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e633ec7ed4f0 ("netfilter: x_tables: add .check_hooks to matches and targets") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 3 warnings, 3 checks, 463 lines checked