WARNING: else is not generally useful after a break or return #339: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:270: + return -1; + } else { WARNING: line length of 88 exceeds 80 columns #486: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:417: + printf("FAIL: Connection closed during echo\n"); WARNING: line length of 82 exceeds 80 columns #514: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:445: + ret = do_tls_rekey(csk, TLS_TX, current_gen, cipher_type); WARNING: line length of 85 exceeds 80 columns #520: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:451: + printf("FAIL: recv KeyUpdate from server\n"); WARNING: line length of 82 exceeds 80 columns #653: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:584: + ret = do_tls_rekey(csk, TLS_RX, current_gen, cipher_type); WARNING: line length of 84 exceeds 80 columns #701: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:632: + if ((unsigned char)buf[off + j] != expect) { WARNING: line length of 96 exceeds 80 columns #702: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:633: + printf("FAIL: data mismatch recv #%d offset %d:" WARNING: quoted string split across lines #703: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:634: + printf("FAIL: data mismatch recv #%d offset %d:" + " expected 0x%02x got 0x%02x" WARNING: quoted string split across lines #704: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:635: + " expected 0x%02x got 0x%02x" + " (iter %d, remaining %d)\n", WARNING: line length of 83 exceeds 80 columns #707: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:638: + (unsigned char)buf[off + j], WARNING: line length of 82 exceeds 80 columns #787: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:718: + printf(" -n Number of send/echo iterations (default: 100)\n"); WARNING: line length of 92 exceeds 80 columns #788: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:719: + printf(" -k Perform N rekeys (client only, TLS 1.3; N < iterations)\n"); WARNING: line length of 88 exceeds 80 columns #789: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:720: + printf(" -B Burst mode: client sends continuously without echo;\n"); WARNING: line length of 92 exceeds 80 columns #790: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:721: + printf(" server drains and handles KeyUpdate without responding.\n"); WARNING: line length of 87 exceeds 80 columns #833: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:764: + printf("ERROR: Invalid port '%s'. Must be 1..65535.\n", WARNING: line length of 90 exceeds 80 columns #841: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:772: + printf("ERROR: Invalid buffer size '%s'. Must be >= 1.\n", WARNING: line length of 90 exceeds 80 columns #850: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:781: + printf("ERROR: Invalid random size '%s'. Must be >= 1.\n", WARNING: line length of 90 exceeds 80 columns #866: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:797: + printf("ERROR: Invalid rekey count '%s'. Must be >= 1.\n", WARNING: line length of 94 exceeds 80 columns #874: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:805: + printf("ERROR: Invalid iteration count '%s'. Must be >= 1.\n", WARNING: line length of 88 exceeds 80 columns #926: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:857: + printf("ERROR: num_rekeys (%d) must be < num_iterations (%d)\n", WARNING: line length of 84 exceeds 80 columns #931: FILE: tools/testing/selftests/drivers/net/hw/tls_hw_offload.c:862: + printf("ERROR: -Z applies to the server (receiver) only\n"); total: 0 errors, 21 warnings, 0 checks, 1169 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 82be275c921e ("selftests: net: add TLS hardware offload test") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 0 checks, 1169 lines checked