CHECK: Lines should not end with a '(' #175: FILE: include/net/tls.h:431: +static inline struct cipher_context *tls_tx_cipher_ctx( WARNING: line length of 87 exceeds 80 columns #451: FILE: net/tls/tls_device.c:303: + cipher_desc = get_cipher_desc(offload_ctx->rekey_crypto_send.info.cipher_type); WARNING: line length of 82 exceeds 80 columns #477: FILE: net/tls/tls_device.c:329: + lockdep_is_held(&device_offload_lock)); WARNING: line length of 86 exceeds 80 columns #489: FILE: net/tls/tls_device.c:341: + memcpy(crypto_info_rec_seq(&offload_ctx->rekey_crypto_send.info, cipher_desc), WARNING: line length of 82 exceeds 80 columns #493: FILE: net/tls/tls_device.c:345: + &offload_ctx->rekey_crypto_send.info, WARNING: line length of 81 exceeds 80 columns #521: FILE: net/tls/tls_device.c:373: + key = crypto_info_key(&offload_ctx->rekey_crypto_send.info, cipher_desc); WARNING: memory barrier without comment #545: FILE: net/tls/tls_device.c:397: + smp_mb__after_atomic(); WARNING: line length of 82 exceeds 80 columns #702: FILE: net/tls/tls_device.c:1340: + lockdep_is_held(&device_offload_lock)); WARNING: line length of 82 exceeds 80 columns #754: FILE: net/tls/tls_device.c:1392: + lockdep_is_held(&device_offload_lock)); CHECK: Please don't use multiple blank lines #762: FILE: net/tls/tls_device.c:1400: + + WARNING: line length of 86 exceeds 80 columns #817: FILE: net/tls/tls_device.c:1456: + tls_ctx->prot_info.rec_seq_size); WARNING: line length of 84 exceeds 80 columns #853: FILE: net/tls/tls_device.c:1552: + const struct tls_cipher_desc *cipher_desc) WARNING: line length of 81 exceeds 80 columns #1084: FILE: net/tls/tls_device.c:1799: + * it is the only key that can undo the NIC-XOR on queued WARNING: line length of 81 exceeds 80 columns #1089: FILE: net/tls/tls_device.c:1804: + * is installed once copied_seq crosses old_nic_boundary. WARNING: line length of 81 exceeds 80 columns #1115: FILE: net/tls/tls_device.c:1830: + before(copied_seq, rcv_nxt)); CHECK: Alignment should match open parenthesis #1115: FILE: net/tls/tls_device.c:1830: + trace_tls_device_rekey_start(sk, copied_seq, rcv_nxt, + before(copied_seq, rcv_nxt)); WARNING: line length of 84 exceeds 80 columns #1296: FILE: net/tls/tls_main.c:720: + TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSTXREKEYOK); WARNING: line length of 84 exceeds 80 columns #1323: FILE: net/tls/tls_main.c:737: + TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSTXREKEYOK); WARNING: line length of 83 exceeds 80 columns #1326: FILE: net/tls/tls_main.c:740: + TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSCURRTXSW); WARNING: line length of 84 exceeds 80 columns #1346: FILE: net/tls/tls_main.c:750: + TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSRXREKEYOK); WARNING: line length of 84 exceeds 80 columns #1375: FILE: net/tls/tls_main.c:767: + TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSRXREKEYOK); WARNING: line length of 83 exceeds 80 columns #1378: FILE: net/tls/tls_main.c:770: + TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSCURRRXSW); CHECK: Alignment should match open parenthesis #1587: FILE: net/tls/trace.h:196: +TRACE_EVENT(tls_device_rekey_start, + CHECK: Lines should not end with a '(' #1593: FILE: net/tls/trace.h:202: + TP_STRUCT__entry( ERROR: space prohibited after that open parenthesis '(' #1594: FILE: net/tls/trace.h:203: + __field( struct sock *, sk ) ERROR: space prohibited before that close parenthesis ')' #1594: FILE: net/tls/trace.h:203: + __field( struct sock *, sk ) ERROR: space prohibited after that open parenthesis '(' #1595: FILE: net/tls/trace.h:204: + __field( u32, copied_seq ) ERROR: space prohibited before that close parenthesis ')' #1595: FILE: net/tls/trace.h:204: + __field( u32, copied_seq ) ERROR: space prohibited after that open parenthesis '(' #1596: FILE: net/tls/trace.h:205: + __field( u32, nic_boundary ) ERROR: space prohibited before that close parenthesis ')' #1596: FILE: net/tls/trace.h:205: + __field( u32, nic_boundary ) ERROR: space prohibited after that open parenthesis '(' #1597: FILE: net/tls/trace.h:206: + __field( bool, inflight ) ERROR: space prohibited before that close parenthesis ')' #1597: FILE: net/tls/trace.h:206: + __field( bool, inflight ) CHECK: Lines should not end with a '(' #1600: FILE: net/tls/trace.h:209: + TP_fast_assign( CHECK: Lines should not end with a '(' #1607: FILE: net/tls/trace.h:216: + TP_printk( CHECK: Alignment should match open parenthesis #1615: FILE: net/tls/trace.h:224: +TRACE_EVENT(tls_device_rekey_reencrypt, + CHECK: Lines should not end with a '(' #1620: FILE: net/tls/trace.h:229: + TP_STRUCT__entry( ERROR: space prohibited after that open parenthesis '(' #1621: FILE: net/tls/trace.h:230: + __field( struct sock *, sk ) ERROR: space prohibited before that close parenthesis ')' #1621: FILE: net/tls/trace.h:230: + __field( struct sock *, sk ) ERROR: space prohibited after that open parenthesis '(' #1622: FILE: net/tls/trace.h:231: + __field( u32, tcp_seq ) ERROR: space prohibited before that close parenthesis ')' #1622: FILE: net/tls/trace.h:231: + __field( u32, tcp_seq ) ERROR: space prohibited after that open parenthesis '(' #1623: FILE: net/tls/trace.h:232: + __field( u32, nic_boundary ) ERROR: space prohibited before that close parenthesis ')' #1623: FILE: net/tls/trace.h:232: + __field( u32, nic_boundary ) ERROR: space prohibited after that open parenthesis '(' #1624: FILE: net/tls/trace.h:233: + __field( bool, retry ) ERROR: space prohibited before that close parenthesis ')' #1624: FILE: net/tls/trace.h:233: + __field( bool, retry ) CHECK: Lines should not end with a '(' #1627: FILE: net/tls/trace.h:236: + TP_fast_assign( CHECK: Lines should not end with a '(' #1634: FILE: net/tls/trace.h:243: + TP_printk( CHECK: Alignment should match open parenthesis #1642: FILE: net/tls/trace.h:251: +TRACE_EVENT(tls_device_rekey_done, + CHECK: Lines should not end with a '(' #1647: FILE: net/tls/trace.h:256: + TP_STRUCT__entry( ERROR: space prohibited after that open parenthesis '(' #1648: FILE: net/tls/trace.h:257: + __field( struct sock *, sk ) ERROR: space prohibited before that close parenthesis ')' #1648: FILE: net/tls/trace.h:257: + __field( struct sock *, sk ) ERROR: space prohibited after that open parenthesis '(' #1649: FILE: net/tls/trace.h:258: + __field( u32, tcp_seq ) ERROR: space prohibited before that close parenthesis ')' #1649: FILE: net/tls/trace.h:258: + __field( u32, tcp_seq ) ERROR: space prohibited after that open parenthesis '(' #1650: FILE: net/tls/trace.h:259: + __field( u32, nic_boundary ) ERROR: space prohibited before that close parenthesis ')' #1650: FILE: net/tls/trace.h:259: + __field( u32, nic_boundary ) CHECK: Lines should not end with a '(' #1653: FILE: net/tls/trace.h:262: + TP_fast_assign( CHECK: Lines should not end with a '(' #1659: FILE: net/tls/trace.h:268: + TP_printk( total: 22 errors, 19 warnings, 15 checks, 1524 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 79ef8b8fd6f6 ("tls: add hardware offload key update support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.