ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.vMwwUcsSdF and /tmp/tmp.BBcPZ8dRzf Tree base: 56a2a82cef2e ("bridge: Do not suppress ARP probes and DAD NS unconditionally") Now at: 48f2e1029cab ("selftests: net: Add tests for ARP probe and DAD NS handling") ====== Checking before the patch ====== Checking tools/testing/selftests/net/test_bridge_neigh_suppress.sh - 0b1cadd95ee005a034d0cb8f43134f66a4832538d3c92ff4b01768b76d8a0ec5 In test_bridge_neigh_suppress.sh line 73: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In test_bridge_neigh_suppress.sh line 87: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_neigh_suppress.sh line 95: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_neigh_suppress.sh line 109: printf "COMMAND: $cmd\n" ^---------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In test_bridge_neigh_suppress.sh line 113: out=$(eval $cmd $stderr) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" "$stderr") In test_bridge_neigh_suppress.sh line 115: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In test_bridge_neigh_suppress.sh line 119: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In test_bridge_neigh_suppress.sh line 131: pkts=$(tc -n $ns -j -s filter show $id \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pkts=$(tc -n "$ns" -j -s filter show "$id" \ In test_bridge_neigh_suppress.sh line 134: [[ $pkts == $count ]] ^----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In test_bridge_neigh_suppress.sh line 144: ip netns exec $ns sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 In test_bridge_neigh_suppress.sh line 145: ip netns exec $ns sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 In test_bridge_neigh_suppress.sh line 146: ip netns exec $ns sysctl -qw net.ipv6.conf.all.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.accept_dad=0 In test_bridge_neigh_suppress.sh line 147: ip netns exec $ns sysctl -qw net.ipv6.conf.default.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.accept_dad=0 In test_bridge_neigh_suppress.sh line 155: for ns in $h1 $h2 $sw1 $sw2; do ^-^ SC2154 (warning): h1 is referenced but not assigned. ^-^ SC2154 (warning): h2 is referenced but not assigned. ^--^ SC2154 (warning): sw1 is referenced but not assigned. ^--^ SC2154 (warning): sw2 is referenced but not assigned. In test_bridge_neigh_suppress.sh line 156: setup_topo_ns $ns ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_topo_ns "$ns" In test_bridge_neigh_suppress.sh line 159: ip -n $h1 link add name eth0 type veth peer name swp1 netns $sw1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$h1" link add name eth0 type veth peer name swp1 netns "$sw1" In test_bridge_neigh_suppress.sh line 160: ip -n $sw1 link add name veth0 type veth peer name veth0 netns $sw2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$sw1" link add name veth0 type veth peer name veth0 netns "$sw2" In test_bridge_neigh_suppress.sh line 161: ip -n $h2 link add name eth0 type veth peer name swp1 netns $sw2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$h2" link add name eth0 type veth peer name swp1 netns "$sw2" In test_bridge_neigh_suppress.sh line 172: ip -n $ns link set dev eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev eth0 up In test_bridge_neigh_suppress.sh line 173: ip -n $ns link add link eth0 name eth0.10 up type vlan id 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link eth0 name eth0.10 up type vlan id 10 In test_bridge_neigh_suppress.sh line 174: ip -n $ns link add link eth0 name eth0.20 up type vlan id 20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link eth0 name eth0.20 up type vlan id 20 In test_bridge_neigh_suppress.sh line 176: ip -n $ns address add $v4addr1 dev eth0.10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v4addr1" dev eth0.10 In test_bridge_neigh_suppress.sh line 177: ip -n $ns address add $v4addr2 dev eth0.20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v4addr2" dev eth0.20 In test_bridge_neigh_suppress.sh line 178: ip -n $ns address add $v6addr1 dev eth0.10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v6addr1" dev eth0.10 In test_bridge_neigh_suppress.sh line 179: ip -n $ns address add $v6addr2 dev eth0.20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v6addr2" dev eth0.20 In test_bridge_neigh_suppress.sh line 190: setup_host_common $ns $v4addr1 $v4addr2 $v6addr1 $v6addr2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_host_common "$ns" $v4addr1 $v4addr2 $v6addr1 $v6addr2 In test_bridge_neigh_suppress.sh line 201: setup_host_common $ns $v4addr1 $v4addr2 $v6addr1 $v6addr2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_host_common "$ns" $v4addr1 $v4addr2 $v6addr1 $v6addr2 In test_bridge_neigh_suppress.sh line 212: ip -n $ns address add $local_addr/32 dev lo ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$local_addr"/32 dev lo In test_bridge_neigh_suppress.sh line 214: ip -n $ns link set dev veth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev veth0 up In test_bridge_neigh_suppress.sh line 215: ip -n $ns address add $veth_addr/28 dev veth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$veth_addr"/28 dev veth0 In test_bridge_neigh_suppress.sh line 216: ip -n $ns route add default via $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" route add default via "$gw_addr" In test_bridge_neigh_suppress.sh line 218: ip -n $ns link add name br0 up type bridge vlan_filtering 1 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name br0 up type bridge vlan_filtering 1 \ In test_bridge_neigh_suppress.sh line 221: ip -n $ns link add link br0 name br0.10 up type vlan id 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link br0 name br0.10 up type vlan id 10 In test_bridge_neigh_suppress.sh line 222: bridge -n $ns vlan add vid 10 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev br0 self In test_bridge_neigh_suppress.sh line 224: ip -n $ns link add link br0 name br0.20 up type vlan id 20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link br0 name br0.20 up type vlan id 20 In test_bridge_neigh_suppress.sh line 225: bridge -n $ns vlan add vid 20 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev br0 self In test_bridge_neigh_suppress.sh line 227: ip -n $ns link set dev swp1 up master br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev swp1 up master br0 In test_bridge_neigh_suppress.sh line 228: bridge -n $ns vlan add vid 10 dev swp1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev swp1 In test_bridge_neigh_suppress.sh line 229: bridge -n $ns vlan add vid 20 dev swp1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev swp1 In test_bridge_neigh_suppress.sh line 231: ip -n $ns link add name vx0 up master br0 type vxlan \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name vx0 up master br0 type vxlan \ In test_bridge_neigh_suppress.sh line 232: local $local_addr dstport 4789 nolearning external ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local "$local_addr" dstport 4789 nolearning external In test_bridge_neigh_suppress.sh line 233: bridge -n $ns fdb add 00:00:00:00:00:00 dev vx0 self static \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" fdb add 00:00:00:00:00:00 dev vx0 self static \ In test_bridge_neigh_suppress.sh line 234: dst $remote_addr src_vni 10010 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst "$remote_addr" src_vni 10010 In test_bridge_neigh_suppress.sh line 235: bridge -n $ns fdb add 00:00:00:00:00:00 dev vx0 self static \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" fdb add 00:00:00:00:00:00 dev vx0 self static \ In test_bridge_neigh_suppress.sh line 236: dst $remote_addr src_vni 10020 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst "$remote_addr" src_vni 10020 In test_bridge_neigh_suppress.sh line 237: bridge -n $ns link set dev vx0 vlan_tunnel on learning off ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" link set dev vx0 vlan_tunnel on learning off In test_bridge_neigh_suppress.sh line 239: bridge -n $ns vlan add vid 10 dev vx0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 In test_bridge_neigh_suppress.sh line 240: bridge -n $ns vlan add vid 10 dev vx0 tunnel_info id 10010 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 tunnel_info id 10010 In test_bridge_neigh_suppress.sh line 242: bridge -n $ns vlan add vid 20 dev vx0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev vx0 In test_bridge_neigh_suppress.sh line 243: bridge -n $ns vlan add vid 20 dev vx0 tunnel_info id 10020 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev vx0 tunnel_info id 10020 In test_bridge_neigh_suppress.sh line 254: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr In test_bridge_neigh_suppress.sh line 265: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr In test_bridge_neigh_suppress.sh line 285: cleanup_ns $h1 $h2 $sw1 $sw2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$h1" "$h2" "$sw1" "$sw2" In test_bridge_neigh_suppress.sh line 309: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 320: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 325: h2_mac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 331: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 341: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 351: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 365: tc_check_packets $sw1 "dev vx0 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 4 In test_bridge_neigh_suppress.sh line 375: tc_check_packets $sw1 "dev vx0 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 5 In test_bridge_neigh_suppress.sh line 385: neigh_suppress_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 390: neigh_suppress_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 408: tmac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 419: tc_check_packets $h1 "dev eth0.$vid ingress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h1" "dev eth0.$vid ingress" 101 1 In test_bridge_neigh_suppress.sh line 421: tc_check_packets $h2 "dev eth0.$vid egress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h2" "dev eth0.$vid egress" 101 1 In test_bridge_neigh_suppress.sh line 431: neigh_suppress_uc_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 436: neigh_suppress_uc_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 458: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 469: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 474: h2_mac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 480: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 490: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 500: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 514: tc_check_packets $sw1 "dev vx0 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 4 In test_bridge_neigh_suppress.sh line 524: tc_check_packets $sw1 "dev vx0 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 5 In test_bridge_neigh_suppress.sh line 535: neigh_suppress_ns_common $vid $saddr $daddr $maddr ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_ns_common "$vid" "$saddr" "$daddr" "$maddr" In test_bridge_neigh_suppress.sh line 542: neigh_suppress_ns_common $vid $saddr $daddr $maddr ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_ns_common "$vid" "$saddr" "$daddr" "$maddr" In test_bridge_neigh_suppress.sh line 555: )"$type:"$( : ICMPv6.type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 556: )"00:"$( : ICMPv6.code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 557: )"$csum:"$( : ICMPv6.checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 558: )"00:00:00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 561: echo $p ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$p" In test_bridge_neigh_suppress.sh line 581: tmac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 591: run_cmd "ip netns exec $h1 mausezahn -6 eth0.$vid -c 1 -a own -b $tmac -A $sip -B $dip -t ip hop=255,next=58,payload=$(icmpv6_header_get $csum $full_dip) -q" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "ip netns exec $h1 mausezahn -6 eth0.$vid -c 1 -a own -b $tmac -A $sip -B $dip -t ip hop=255,next=58,payload=$(icmpv6_header_get "$csum" "$full_dip") -q" In test_bridge_neigh_suppress.sh line 592: tc_check_packets $h1 "dev eth0.$vid ingress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h1" "dev eth0.$vid ingress" 101 1 In test_bridge_neigh_suppress.sh line 594: tc_check_packets $h2 "dev eth0.$vid egress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h2" "dev eth0.$vid egress" 101 1 In test_bridge_neigh_suppress.sh line 606: neigh_suppress_uc_ns_common $vid $saddr $daddr $full_daddr $csum ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_ns_common "$vid" "$saddr" "$daddr" "$full_daddr" "$csum" In test_bridge_neigh_suppress.sh line 614: neigh_suppress_uc_ns_common $vid $saddr $daddr $full_daddr $csum ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_ns_common "$vid" "$saddr" "$daddr" "$full_daddr" "$csum" In test_bridge_neigh_suppress.sh line 636: h2_mac1=$(ip -n $h2 -j -p link show eth0.$vid1 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac1=$(ip -n "$h2" -j -p link show eth0."$vid1" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 637: h2_mac2=$(ip -n $h2 -j -p link show eth0.$vid2 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac2=$(ip -n "$h2" -j -p link show eth0."$vid2" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 654: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 656: tc_check_packets $sw1 "dev vx0 egress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 1 In test_bridge_neigh_suppress.sh line 672: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 674: tc_check_packets $sw1 "dev vx0 egress" 102 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 2 In test_bridge_neigh_suppress.sh line 688: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 690: tc_check_packets $sw1 "dev vx0 egress" 102 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 3 In test_bridge_neigh_suppress.sh line 704: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 706: tc_check_packets $sw1 "dev vx0 egress" 102 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 4 In test_bridge_neigh_suppress.sh line 720: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 722: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 741: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 743: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 767: h2_mac1=$(ip -n $h2 -j -p link show eth0.$vid1 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac1=$(ip -n "$h2" -j -p link show eth0."$vid1" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 768: h2_mac2=$(ip -n $h2 -j -p link show eth0.$vid2 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac2=$(ip -n "$h2" -j -p link show eth0."$vid2" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 785: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 787: tc_check_packets $sw1 "dev vx0 egress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 1 In test_bridge_neigh_suppress.sh line 803: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 805: tc_check_packets $sw1 "dev vx0 egress" 102 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 2 In test_bridge_neigh_suppress.sh line 819: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 821: tc_check_packets $sw1 "dev vx0 egress" 102 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 3 In test_bridge_neigh_suppress.sh line 835: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 837: tc_check_packets $sw1 "dev vx0 egress" 102 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 4 In test_bridge_neigh_suppress.sh line 851: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 853: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 872: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 874: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 904: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In test_bridge_neigh_suppress.sh line 954: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_bridge_neigh_suppress.sh line 968: printf "\nTests passed: %3d\n" ${nsuccess} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "\nTests passed: %3d\n" "${nsuccess}" In test_bridge_neigh_suppress.sh line 969: printf "Tests failed: %3d\n" ${nfail} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "Tests failed: %3d\n" "${nfail}" For more information: https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i... https://www.shellcheck.net/wiki/SC2154 -- h1 is referenced but not assigned. ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/test_bridge_neigh_suppress.sh - 0b1cadd95ee005a034d0cb8f43134f66a4832538d3c92ff4b01768b76d8a0ec5 In test_bridge_neigh_suppress.sh line 75: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In test_bridge_neigh_suppress.sh line 89: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_neigh_suppress.sh line 97: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_bridge_neigh_suppress.sh line 111: printf "COMMAND: $cmd\n" ^---------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In test_bridge_neigh_suppress.sh line 115: out=$(eval $cmd $stderr) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" "$stderr") In test_bridge_neigh_suppress.sh line 117: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In test_bridge_neigh_suppress.sh line 121: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In test_bridge_neigh_suppress.sh line 133: pkts=$(tc -n $ns -j -s filter show $id \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pkts=$(tc -n "$ns" -j -s filter show "$id" \ In test_bridge_neigh_suppress.sh line 136: [[ $pkts == $count ]] ^----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In test_bridge_neigh_suppress.sh line 146: ip netns exec $ns sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.keep_addr_on_down=1 In test_bridge_neigh_suppress.sh line 147: ip netns exec $ns sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.ignore_routes_with_linkdown=1 In test_bridge_neigh_suppress.sh line 148: ip netns exec $ns sysctl -qw net.ipv6.conf.all.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.all.accept_dad=0 In test_bridge_neigh_suppress.sh line 149: ip netns exec $ns sysctl -qw net.ipv6.conf.default.accept_dad=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -qw net.ipv6.conf.default.accept_dad=0 In test_bridge_neigh_suppress.sh line 157: for ns in $h1 $h2 $sw1 $sw2; do ^-^ SC2154 (warning): h1 is referenced but not assigned. ^-^ SC2154 (warning): h2 is referenced but not assigned. ^--^ SC2154 (warning): sw1 is referenced but not assigned. ^--^ SC2154 (warning): sw2 is referenced but not assigned. In test_bridge_neigh_suppress.sh line 158: setup_topo_ns $ns ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_topo_ns "$ns" In test_bridge_neigh_suppress.sh line 161: ip -n $h1 link add name eth0 type veth peer name swp1 netns $sw1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$h1" link add name eth0 type veth peer name swp1 netns "$sw1" In test_bridge_neigh_suppress.sh line 162: ip -n $sw1 link add name veth0 type veth peer name veth0 netns $sw2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$sw1" link add name veth0 type veth peer name veth0 netns "$sw2" In test_bridge_neigh_suppress.sh line 163: ip -n $h2 link add name eth0 type veth peer name swp1 netns $sw2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$h2" link add name eth0 type veth peer name swp1 netns "$sw2" In test_bridge_neigh_suppress.sh line 174: ip -n $ns link set dev eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev eth0 up In test_bridge_neigh_suppress.sh line 175: ip -n $ns link add link eth0 name eth0.10 up type vlan id 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link eth0 name eth0.10 up type vlan id 10 In test_bridge_neigh_suppress.sh line 176: ip -n $ns link add link eth0 name eth0.20 up type vlan id 20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link eth0 name eth0.20 up type vlan id 20 In test_bridge_neigh_suppress.sh line 178: ip -n $ns address add $v4addr1 dev eth0.10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v4addr1" dev eth0.10 In test_bridge_neigh_suppress.sh line 179: ip -n $ns address add $v4addr2 dev eth0.20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v4addr2" dev eth0.20 In test_bridge_neigh_suppress.sh line 180: ip -n $ns address add $v6addr1 dev eth0.10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v6addr1" dev eth0.10 In test_bridge_neigh_suppress.sh line 181: ip -n $ns address add $v6addr2 dev eth0.20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$v6addr2" dev eth0.20 In test_bridge_neigh_suppress.sh line 192: setup_host_common $ns $v4addr1 $v4addr2 $v6addr1 $v6addr2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_host_common "$ns" $v4addr1 $v4addr2 $v6addr1 $v6addr2 In test_bridge_neigh_suppress.sh line 203: setup_host_common $ns $v4addr1 $v4addr2 $v6addr1 $v6addr2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_host_common "$ns" $v4addr1 $v4addr2 $v6addr1 $v6addr2 In test_bridge_neigh_suppress.sh line 214: ip -n $ns address add $local_addr/32 dev lo ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$local_addr"/32 dev lo In test_bridge_neigh_suppress.sh line 216: ip -n $ns link set dev veth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev veth0 up In test_bridge_neigh_suppress.sh line 217: ip -n $ns address add $veth_addr/28 dev veth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" address add "$veth_addr"/28 dev veth0 In test_bridge_neigh_suppress.sh line 218: ip -n $ns route add default via $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" route add default via "$gw_addr" In test_bridge_neigh_suppress.sh line 220: ip -n $ns link add name br0 up type bridge vlan_filtering 1 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name br0 up type bridge vlan_filtering 1 \ In test_bridge_neigh_suppress.sh line 223: ip -n $ns link add link br0 name br0.10 up type vlan id 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link br0 name br0.10 up type vlan id 10 In test_bridge_neigh_suppress.sh line 224: bridge -n $ns vlan add vid 10 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev br0 self In test_bridge_neigh_suppress.sh line 226: ip -n $ns link add link br0 name br0.20 up type vlan id 20 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add link br0 name br0.20 up type vlan id 20 In test_bridge_neigh_suppress.sh line 227: bridge -n $ns vlan add vid 20 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev br0 self In test_bridge_neigh_suppress.sh line 229: ip -n $ns link set dev swp1 up master br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link set dev swp1 up master br0 In test_bridge_neigh_suppress.sh line 230: bridge -n $ns vlan add vid 10 dev swp1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev swp1 In test_bridge_neigh_suppress.sh line 231: bridge -n $ns vlan add vid 20 dev swp1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev swp1 In test_bridge_neigh_suppress.sh line 233: ip -n $ns link add name vx0 up master br0 type vxlan \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$ns" link add name vx0 up master br0 type vxlan \ In test_bridge_neigh_suppress.sh line 234: local $local_addr dstport 4789 nolearning external ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local "$local_addr" dstport 4789 nolearning external In test_bridge_neigh_suppress.sh line 235: bridge -n $ns fdb add 00:00:00:00:00:00 dev vx0 self static \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" fdb add 00:00:00:00:00:00 dev vx0 self static \ In test_bridge_neigh_suppress.sh line 236: dst $remote_addr src_vni 10010 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst "$remote_addr" src_vni 10010 In test_bridge_neigh_suppress.sh line 237: bridge -n $ns fdb add 00:00:00:00:00:00 dev vx0 self static \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" fdb add 00:00:00:00:00:00 dev vx0 self static \ In test_bridge_neigh_suppress.sh line 238: dst $remote_addr src_vni 10020 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst "$remote_addr" src_vni 10020 In test_bridge_neigh_suppress.sh line 239: bridge -n $ns link set dev vx0 vlan_tunnel on learning off ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" link set dev vx0 vlan_tunnel on learning off In test_bridge_neigh_suppress.sh line 241: bridge -n $ns vlan add vid 10 dev vx0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 In test_bridge_neigh_suppress.sh line 242: bridge -n $ns vlan add vid 10 dev vx0 tunnel_info id 10010 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 10 dev vx0 tunnel_info id 10010 In test_bridge_neigh_suppress.sh line 244: bridge -n $ns vlan add vid 20 dev vx0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev vx0 In test_bridge_neigh_suppress.sh line 245: bridge -n $ns vlan add vid 20 dev vx0 tunnel_info id 10020 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$ns" vlan add vid 20 dev vx0 tunnel_info id 10020 In test_bridge_neigh_suppress.sh line 256: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr In test_bridge_neigh_suppress.sh line 267: setup_sw_common $ns $local_addr $remote_addr $veth_addr $gw_addr ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_sw_common "$ns" $local_addr $remote_addr $veth_addr $gw_addr In test_bridge_neigh_suppress.sh line 287: cleanup_ns $h1 $h2 $sw1 $sw2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$h1" "$h2" "$sw1" "$sw2" In test_bridge_neigh_suppress.sh line 311: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 322: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 327: h2_mac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 333: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 343: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 353: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 367: tc_check_packets $sw1 "dev vx0 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 4 In test_bridge_neigh_suppress.sh line 377: tc_check_packets $sw1 "dev vx0 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 5 In test_bridge_neigh_suppress.sh line 387: neigh_suppress_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 392: neigh_suppress_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 410: tmac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 421: tc_check_packets $h1 "dev eth0.$vid ingress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h1" "dev eth0.$vid ingress" 101 1 In test_bridge_neigh_suppress.sh line 423: tc_check_packets $h2 "dev eth0.$vid egress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h2" "dev eth0.$vid egress" 101 1 In test_bridge_neigh_suppress.sh line 433: neigh_suppress_uc_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 438: neigh_suppress_uc_arp_common $vid $sip $tip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_arp_common "$vid" "$sip" "$tip" In test_bridge_neigh_suppress.sh line 460: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 471: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 476: h2_mac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 482: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 492: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 502: tc_check_packets $sw1 "dev vx0 egress" 101 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 3 In test_bridge_neigh_suppress.sh line 516: tc_check_packets $sw1 "dev vx0 egress" 101 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 4 In test_bridge_neigh_suppress.sh line 526: tc_check_packets $sw1 "dev vx0 egress" 101 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 5 In test_bridge_neigh_suppress.sh line 537: neigh_suppress_ns_common $vid $saddr $daddr $maddr ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_ns_common "$vid" "$saddr" "$daddr" "$maddr" In test_bridge_neigh_suppress.sh line 544: neigh_suppress_ns_common $vid $saddr $daddr $maddr ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_ns_common "$vid" "$saddr" "$daddr" "$maddr" In test_bridge_neigh_suppress.sh line 557: )"$type:"$( : ICMPv6.type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 558: )"00:"$( : ICMPv6.code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 559: )"$csum:"$( : ICMPv6.checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 560: )"00:00:00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In test_bridge_neigh_suppress.sh line 563: echo $p ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$p" In test_bridge_neigh_suppress.sh line 583: tmac=$(ip -n $h2 -j -p link show eth0.$vid | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmac=$(ip -n "$h2" -j -p link show eth0."$vid" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 593: run_cmd "ip netns exec $h1 mausezahn -6 eth0.$vid -c 1 -a own -b $tmac -A $sip -B $dip -t ip hop=255,next=58,payload=$(icmpv6_header_get $csum $full_dip) -q" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "ip netns exec $h1 mausezahn -6 eth0.$vid -c 1 -a own -b $tmac -A $sip -B $dip -t ip hop=255,next=58,payload=$(icmpv6_header_get "$csum" "$full_dip") -q" In test_bridge_neigh_suppress.sh line 594: tc_check_packets $h1 "dev eth0.$vid ingress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h1" "dev eth0.$vid ingress" 101 1 In test_bridge_neigh_suppress.sh line 596: tc_check_packets $h2 "dev eth0.$vid egress" 101 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$h2" "dev eth0.$vid egress" 101 1 In test_bridge_neigh_suppress.sh line 608: neigh_suppress_uc_ns_common $vid $saddr $daddr $full_daddr $csum ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_ns_common "$vid" "$saddr" "$daddr" "$full_daddr" "$csum" In test_bridge_neigh_suppress.sh line 616: neigh_suppress_uc_ns_common $vid $saddr $daddr $full_daddr $csum ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: neigh_suppress_uc_ns_common "$vid" "$saddr" "$daddr" "$full_daddr" "$csum" In test_bridge_neigh_suppress.sh line 638: h2_mac1=$(ip -n $h2 -j -p link show eth0.$vid1 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac1=$(ip -n "$h2" -j -p link show eth0."$vid1" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 639: h2_mac2=$(ip -n $h2 -j -p link show eth0.$vid2 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac2=$(ip -n "$h2" -j -p link show eth0."$vid2" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 656: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 658: tc_check_packets $sw1 "dev vx0 egress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 1 In test_bridge_neigh_suppress.sh line 674: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 676: tc_check_packets $sw1 "dev vx0 egress" 102 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 2 In test_bridge_neigh_suppress.sh line 690: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 692: tc_check_packets $sw1 "dev vx0 egress" 102 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 3 In test_bridge_neigh_suppress.sh line 706: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 708: tc_check_packets $sw1 "dev vx0 egress" 102 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 4 In test_bridge_neigh_suppress.sh line 722: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 724: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 743: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 745: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 769: h2_mac1=$(ip -n $h2 -j -p link show eth0.$vid1 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac1=$(ip -n "$h2" -j -p link show eth0."$vid1" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 770: h2_mac2=$(ip -n $h2 -j -p link show eth0.$vid2 | jq -r '.[]["address"]') ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac2=$(ip -n "$h2" -j -p link show eth0."$vid2" | jq -r '.[]["address"]') In test_bridge_neigh_suppress.sh line 787: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 789: tc_check_packets $sw1 "dev vx0 egress" 102 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 1 In test_bridge_neigh_suppress.sh line 805: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 807: tc_check_packets $sw1 "dev vx0 egress" 102 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 2 In test_bridge_neigh_suppress.sh line 821: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 823: tc_check_packets $sw1 "dev vx0 egress" 102 3 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 3 In test_bridge_neigh_suppress.sh line 837: tc_check_packets $sw1 "dev vx0 egress" 101 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 1 In test_bridge_neigh_suppress.sh line 839: tc_check_packets $sw1 "dev vx0 egress" 102 4 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 4 In test_bridge_neigh_suppress.sh line 853: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 855: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 874: tc_check_packets $sw1 "dev vx0 egress" 101 2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 101 2 In test_bridge_neigh_suppress.sh line 876: tc_check_packets $sw1 "dev vx0 egress" 102 5 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_check_packets "$sw1" "dev vx0 egress" 102 5 In test_bridge_neigh_suppress.sh line 1030: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In test_bridge_neigh_suppress.sh line 1080: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_bridge_neigh_suppress.sh line 1094: printf "\nTests passed: %3d\n" ${nsuccess} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "\nTests passed: %3d\n" "${nsuccess}" In test_bridge_neigh_suppress.sh line 1095: printf "Tests failed: %3d\n" ${nfail} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "Tests failed: %3d\n" "${nfail}" For more information: https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i... https://www.shellcheck.net/wiki/SC2154 -- h1 is referenced but not assigned.