WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines #57: FILE: net/rxrpc/Kconfig:100: +config AF_RXRPC_KUNIT_TEST + tristate "RxRPC KUnit test" if !KUNIT_ALL_TESTS + depends on KUNIT && RXKAD + default KUNIT_ALL_TESTS + help + Enable the RxRPC KUnit test suite. + WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #121: FILE: net/rxrpc/fcrypt.c:1: +/* FCrypt encryption algorithm CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues #176: FILE: net/rxrpc/fcrypt.c:56: +#define Z(x) cpu_to_be32(x << 3) CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues #213: FILE: net/rxrpc/fcrypt.c:93: +#define Z(x) cpu_to_be32(((x & 0x1f) << 27) | (x >> 5)) CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues #250: FILE: net/rxrpc/fcrypt.c:130: +#define Z(x) cpu_to_be32(x << 11) CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues #287: FILE: net/rxrpc/fcrypt.c:167: +#define Z(x) cpu_to_be32(x << 19) CHECK: Macro argument 'R' may be better as '(R)' to avoid precedence issues #330: FILE: net/rxrpc/fcrypt.c:210: +#define F_ENCRYPT(R, L, sched) \ + do { \ + union lc4 { \ + __be32 l; \ + u8 c[4]; \ + } u; \ + u.l = sched ^ R; \ + L ^= sbox0[u.c[0]] ^ sbox1[u.c[1]] ^ sbox2[u.c[2]] ^ \ + sbox3[u.c[3]]; \ + } while (0) CHECK: Macro argument 'L' may be better as '(L)' to avoid precedence issues #330: FILE: net/rxrpc/fcrypt.c:210: +#define F_ENCRYPT(R, L, sched) \ + do { \ + union lc4 { \ + __be32 l; \ + u8 c[4]; \ + } u; \ + u.l = sched ^ R; \ + L ^= sbox0[u.c[0]] ^ sbox1[u.c[1]] ^ sbox2[u.c[2]] ^ \ + sbox3[u.c[3]]; \ + } while (0) CHECK: Macro argument 'sched' may be better as '(sched)' to avoid precedence issues #330: FILE: net/rxrpc/fcrypt.c:210: +#define F_ENCRYPT(R, L, sched) \ + do { \ + union lc4 { \ + __be32 l; \ + u8 c[4]; \ + } u; \ + u.l = sched ^ R; \ + L ^= sbox0[u.c[0]] ^ sbox1[u.c[1]] ^ sbox2[u.c[2]] ^ \ + sbox3[u.c[3]]; \ + } while (0) CHECK: Please use a blank line after function/struct/union/enum declarations #591: FILE: net/rxrpc/tests/rxrpc_kunit.c:105: +}; +kunit_test_suite(rxrpc_test_suite); total: 0 errors, 2 warnings, 8 checks, 518 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4b005ed3059b ("net/rxrpc: Add local FCrypt-PCBC implementation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 2 warnings, 8 checks, 518 lines checked