WARNING: externs should be avoided in .c files #58: FILE: tools/testing/selftests/bpf/bench.c:289: +extern struct argp bench_xdp_lb_argp; WARNING: externs should be avoided in .c files #74: FILE: tools/testing/selftests/bpf/bench.c:581: +extern const struct bench bench_xdp_lb; WARNING: line length of 98 exceeds 80 columns #110: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:19: +#define IP4(a, b, c, d) (((__u32)(a) << 24) | ((__u32)(b) << 16) | ((__u32)(c) << 8) | (__u32)(d)) WARNING: line length of 85 exceeds 80 columns #201: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:110: + __u32 fixed_batch_iters; /* 0 = auto-calibrate, >0 = use this value */ WARNING: line length of 83 exceeds 80 columns #599: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:508: +static void populate_vip(struct xdp_lb_bench *skel, const struct test_scenario *sc) WARNING: line length of 88 exceeds 80 columns #614: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:523: + err = bpf_map_update_elem(bpf_map__fd(skel->maps.vip_map), &key, &val, BPF_ANY); WARNING: line length of 81 exceeds 80 columns #616: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:525: + fprintf(stderr, "vip_map [%s]: %s\n", sc->name, strerror(errno)); WARNING: line length of 83 exceeds 80 columns #639: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:548: + fprintf(stderr, "lru_inner[%d]: %s\n", i, strerror(errno)); WARNING: line length of 85 exceeds 80 columns #646: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:555: + fprintf(stderr, "lru_mapping[%d]: %s\n", i, strerror(errno)); WARNING: line length of 82 exceeds 80 columns #695: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:604: + fprintf(stderr, "ch_rings[%d]: %s\n", i, strerror(errno)); WARNING: line length of 91 exceeds 80 columns #702: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:611: + err = bpf_map_update_elem(bpf_map__fd(skel->maps.ctl_array), &key, &cval, BPF_ANY); WARNING: line length of 90 exceeds 80 columns #711: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:620: + err = bpf_map_update_elem(bpf_map__fd(skel->maps.reals), &key, &real_v4, BPF_ANY); WARNING: line length of 90 exceeds 80 columns #720: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:629: + err = bpf_map_update_elem(bpf_map__fd(skel->maps.reals), &key, &real_v6, BPF_ANY); WARNING: line length of 83 exceeds 80 columns #722: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:631: + fprintf(stderr, "reals[%d]: %s\n", REAL_INDEX_V6, strerror(errno)); WARNING: line length of 81 exceeds 80 columns #747: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:656: + err = bpf_map_update_elem(bpf_map__fd(skel->maps.vip_miss_stats), WARNING: line length of 81 exceeds 80 columns #750: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:659: + fprintf(stderr, "vip_miss_stats: %s\n", strerror(errno)); WARNING: line length of 93 exceeds 80 columns #823: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:732: +static void print_hex_diff(const char *name, const __u8 *got, __u32 got_len, const __u8 *exp, WARNING: line length of 91 exceeds 80 columns #837: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:746: + fprintf(stderr, " offset 0x%03x: got 0x%02x expected 0x%02x\n", WARNING: line length of 100 exceeds 80 columns #900: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:809: + fprintf(stderr, " [%s] COUNTER FAIL: STATS_XDP_TX=%llu, expected %llu\n", sc->name, WARNING: line length of 92 exceeds 80 columns #905: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:814: + fprintf(stderr, " [%s] COUNTER FAIL: STATS_XDP_PASS=%llu, expected %llu\n", WARNING: line length of 87 exceeds 80 columns #906: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:815: + sc->name, (unsigned long long)xdp_pass, (unsigned long long)n); WARNING: line length of 92 exceeds 80 columns #910: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:819: + fprintf(stderr, " [%s] COUNTER FAIL: STATS_XDP_DROP=%llu, expected %llu\n", WARNING: line length of 87 exceeds 80 columns #911: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:820: + sc->name, (unsigned long long)xdp_drop, (unsigned long long)n); WARNING: line length of 90 exceeds 80 columns #919: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:828: + fprintf(stderr, " [%s] COUNTER FAIL: STATS_LRU.v1=%llu, expected %llu\n", WARNING: line length of 87 exceeds 80 columns #920: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:829: + sc->name, (unsigned long long)lru_pkts, (unsigned long long)n); WARNING: line length of 88 exceeds 80 columns #949: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:858: + fprintf(stderr, " [%s] COUNTER FAIL: LRU misses=%llu, expected %llu\n", WARNING: line length of 100 exceeds 80 columns #957: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:866: + fprintf(stderr, " [%s] COUNTER FAIL: TCP LRU misses=%llu, expected %llu\n", WARNING: line length of 90 exceeds 80 columns #994: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:903: + fprintf(stderr, " [%s] FAIL: test_run: %s\n", sc->name, strerror(errno)); WARNING: line length of 82 exceeds 80 columns #999: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:908: + fprintf(stderr, " [%s] FAIL: retval %s, expected %s\n", sc->name, WARNING: line length of 91 exceeds 80 columns #1000: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:909: + xdp_action_str(topts.retval), xdp_action_str(sc->expected_retval)); WARNING: line length of 91 exceeds 80 columns #1011: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:920: + fprintf(stderr, " [%s] FAIL: output packet mismatch\n", sc->name); WARNING: line length of 93 exceeds 80 columns #1012: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:921: + print_hex_diff(sc->name, out, topts.data_size_out, expected_buf[idx], WARNING: line length of 84 exceeds 80 columns #1041: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:950: + fprintf(stderr, "too many CPUs (%d > %d), increase BENCH_NR_CPUS\n", CHECK: Alignment should match open parenthesis #1052: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:961: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .data_in = pkt_buf[idx], WARNING: line length of 98 exceeds 80 columns #1066: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:975: + fprintf(stderr, "--scenario is required. Use --list-scenarios to see options.\n"); WARNING: line length of 81 exceeds 80 columns #1080: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:989: + fprintf(stderr, "failed to load skeleton: %s\n", strerror(-err)); WARNING: line length of 84 exceeds 80 columns #1097: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:1006: + ctx.timing.batch_iters = scenarios[args.scenario].fixed_batch_iters; WARNING: line length of 81 exceeds 80 columns #1171: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:1080: + fprintf(stderr, "use --list-scenarios to see options\n"); WARNING: line length of 93 exceeds 80 columns #1178: FILE: tools/testing/selftests/bpf/benchs/bench_xdp_lb.c:1087: + printf(" %-20s %s\n", scenarios[i].name, scenarios[i].description); total: 0 errors, 38 warnings, 1 checks, 1155 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit fb18de1b6253 ("selftests/bpf: Add XDP load-balancer benchmark driver") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 38 warnings, 1 checks, 1155 lines checked