CHECK: Prefer using the BIT macro #34: FILE: tools/testing/selftests/bpf/xdp_lb_bench_common.h:7: +#define F_IPV6 (1 << 0) CHECK: Prefer using the BIT macro #35: FILE: tools/testing/selftests/bpf/xdp_lb_bench_common.h:8: +#define F_LRU_BYPASS (1 << 1) WARNING: line length of 83 exceeds 80 columns #43: FILE: tools/testing/selftests/bpf/xdp_lb_bench_common.h:16: +#define MAX_CONN_RATE 100000000 /* high enough to never trigger in bench */ WARNING: line length of 83 exceeds 80 columns #53: FILE: tools/testing/selftests/bpf/xdp_lb_bench_common.h:26: +#define STATS_LRU (MAX_VIPS + 0) /* v1: total VIP packets, v2: LRU misses */ ERROR: Macros with complex values should be enclosed in parentheses #63: FILE: tools/testing/selftests/bpf/xdp_lb_bench_common.h:36: +#define LB_INLINE static __always_inline BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. ERROR: Macros with complex values should be enclosed in parentheses #66: FILE: tools/testing/selftests/bpf/xdp_lb_bench_common.h:39: +#define LB_INLINE static inline BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. total: 2 errors, 2 warnings, 2 checks, 112 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 85932f309bf1 ("selftests/bpf: Add XDP load-balancer common definitions") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.