WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #78: FILE: tools/testing/selftests/bpf/bench_bpf_timing.h:23: + volatile __u32 *timing_enabled; /* &skel->bss->timing_enabled */ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #79: FILE: tools/testing/selftests/bpf/bench_bpf_timing.h:24: + volatile __u32 *batch_iters_bss; /* &skel->bss->batch_iters */ WARNING: line length of 81 exceeds 80 columns #101: FILE: tools/testing/selftests/bpf/bench_bpf_timing.h:46: +void bpf_bench_timing_measure(struct bpf_bench_timing *t, struct bench_res *res); WARNING: line length of 93 exceeds 80 columns #102: FILE: tools/testing/selftests/bpf/bench_bpf_timing.h:47: +void bpf_bench_timing_report(struct bpf_bench_timing *t, const char *name, const char *desc); WARNING: line length of 89 exceeds 80 columns #103: FILE: tools/testing/selftests/bpf/bench_bpf_timing.h:48: +void bpf_bench_calibrate(struct bpf_bench_timing *t, bpf_bench_run_fn run_fn, void *ctx); WARNING: line length of 87 exceeds 80 columns #236: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:125: + if (total_samples >= (__u32)env.producer_cnt * t->target_samples && !t->done) { WARNING: line length of 99 exceeds 80 columns #243: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:132: +void bpf_bench_timing_report(struct bpf_bench_timing *t, const char *name, const char *description) WARNING: line length of 96 exceeds 80 columns #267: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:156: + printf("RESULT scenario=%s samples=%d median=%.2f stddev=%.2f cv=%.2f min=%.2f " WARNING: quoted string split across lines #268: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:157: + printf("RESULT scenario=%s samples=%d median=%.2f stddev=%.2f cv=%.2f min=%.2f " + "p99=%.2f max=%.2f\n", name, total, s.median, s.stddev, WARNING: line length of 90 exceeds 80 columns #269: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:158: + s.mean > 0 ? s.stddev / s.mean * 100.0 : 0.0, s.min, s.p99, s.max); WARNING: line length of 91 exceeds 80 columns #271: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:160: + printf("%s: median %.2f ns/op, stddev %.2f, p99 %.2f (%d samples)\n", name, WARNING: line length of 96 exceeds 80 columns #292: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:181: +static __u64 measure_elapsed(struct bpf_bench_timing *t, bpf_bench_run_fn run_fn, void *run_ctx, WARNING: line length of 92 exceeds 80 columns #349: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:238: +void bpf_bench_calibrate(struct bpf_bench_timing *t, bpf_bench_run_fn run_fn, void *run_ctx) WARNING: line length of 92 exceeds 80 columns #355: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:244: + elapsed = measure_elapsed(t, run_fn, run_ctx, CALIBRATE_SEED_BATCH, CALIBRATE_RUNS); WARNING: line length of 83 exceeds 80 columns #357: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:246: + fprintf(stderr, "calibration: no timing samples, using default\n"); WARNING: line length of 85 exceeds 80 columns #367: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:256: + time_n = measure_elapsed(t, run_fn, run_ctx, t->batch_iters, CALIBRATE_RUNS); WARNING: line length of 90 exceeds 80 columns #368: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:257: + time_2n = measure_elapsed(t, run_fn, run_ctx, t->batch_iters * 2, CALIBRATE_RUNS); WARNING: quoted string split across lines #376: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:265: + "WARNING: proportionality check failed (2N/N ratio=%.3f, " + "expected=2.000, error=%.1f%%)\n System noise may be affecting " WARNING: quoted string split across lines #377: FILE: tools/testing/selftests/bpf/benchs/bench_bpf_timing.c:266: + "expected=2.000, error=%.1f%%)\n System noise may be affecting " + "results.\n", WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #412: FILE: tools/testing/selftests/bpf/progs/bench_bpf_timing.bpf.h:23: +volatile __u32 batch_iters; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #413: FILE: tools/testing/selftests/bpf/progs/bench_bpf_timing.bpf.h:24: +volatile __u32 timing_enabled; total: 0 errors, 21 warnings, 0 checks, 405 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a499708d368c ("selftests/bpf: Add BPF batch-timing library") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 0 checks, 405 lines checked