ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.8Fx3dktkh6 and /tmp/tmp.NlN5CPLi2f
Tree base:
000ba9842029 ("ipv6: update route serial number on NETDEV_CHANGE")
Now at:
9949c2b2e9f1 ("selftest: net: Add test for TCP flow failover with ECMP routes.")
 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/tcp_ecmp_failover.sh - c6738717ba0f43366b33eb81e21cf44e456c94dd25b2383c465c615cffac816a


In tcp_ecmp_failover.sh line 30:
	IP="ip -n $server"
                  ^-----^ SC2154 (warning): server is referenced but not assigned.


In tcp_ecmp_failover.sh line 59:
	IP="ip -n $client"
                  ^-----^ SC2154 (warning): client is referenced but not assigned.


In tcp_ecmp_failover.sh line 107:
	ip -n $client link add veth-c1 type veth peer veth-s1 netns $server
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                    ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "$client" link add veth-c1 type veth peer veth-s1 netns "$server"


In tcp_ecmp_failover.sh line 108:
	ip -n $client link add veth-c2 type veth peer veth-s2 netns $server
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                    ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "$client" link add veth-c2 type veth peer veth-s2 netns "$server"


In tcp_ecmp_failover.sh line 127:
	tcpdump_start veth-s1 $server
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_start veth-s1 "$server"


In tcp_ecmp_failover.sh line 128:
	tcpdump_start veth-s2 $server
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_start veth-s2 "$server"


In tcp_ecmp_failover.sh line 130:
	ip netns exec $server \
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$server" \


In tcp_ecmp_failover.sh line 131:
		socat -u TCP-LISTEN:8080,pf=$pf,bind=$server_ip,reuseaddr /dev/null &
                                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                     ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		socat -u TCP-LISTEN:8080,pf="$pf",bind="$server_ip",reuseaddr /dev/null &


In tcp_ecmp_failover.sh line 138:
	ip netns exec $client \
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$client" \


In tcp_ecmp_failover.sh line 139:
		socat -u /dev/zero TCP:$server_ip:8080,pf=$pf,bind=$client_ip &
                                       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		socat -u /dev/zero TCP:"$server_ip":8080,pf="$pf",bind="$client_ip" &


In tcp_ecmp_failover.sh line 155:
	if [ $pkts_s1 -gt $pkts_s2 ]; then
             ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if [ "$pkts_s1" -gt "$pkts_s2" ]; then


In tcp_ecmp_failover.sh line 170:
	ip -n $server link set $veth_down down
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "$server" link set $veth_down down


In tcp_ecmp_failover.sh line 172:
	tcpdump_start $veth_up $server
                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_start $veth_up "$server"


In tcp_ecmp_failover.sh line 179:
	kill -9 $client_pid 2>&1 > /dev/null
                            ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).


In tcp_ecmp_failover.sh line 180:
	kill -9 $server_pid 2>&1 > /dev/null
                            ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).


In tcp_ecmp_failover.sh line 187:
	if [ $pkts -lt 10000 ]; then
             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if [ "$pkts" -lt 10000 ]; then


In tcp_ecmp_failover.sh line 188:
		RET=$ksft_fail
                ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).
                    ^--------^ SC2154 (warning): ksft_fail is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- RET appears unused. Verify use (o...
  https://www.shellcheck.net/wiki/SC2069 -- To redirect stdout+stderr, 2>&1 m...
  https://www.shellcheck.net/wiki/SC2154 -- client is referenced but not assi...