WARNING: line length of 81 exceeds 80 columns #86: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:52: + * verification failures if verified with the rest of asan_test_buddy_uaf_single. CHECK: spaces preferred around that '*' (ctx:WxV) #88: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:54: +__weak int asan_test_buddy_byte(u8 __arena __arg_arena *mem, int i, bool freed) ^ CHECK: Alignment should match open parenthesis #94: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:60: + if (freed && BUDDY_HEADER_OFF <= i && + i < BUDDY_HEADER_OFF + sizeof(struct buddy_header)) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #143: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:109: + volatile u8 mem[48]; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #149: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:115: + volatile struct buddy_blob __arena *blob; WARNING: Prefer ARRAY_SIZE(sizes) #191: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:157: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #195: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:161: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); WARNING: Prefer ARRAY_SIZE(sizes) #222: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:188: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #226: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:192: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); CHECK: Alignment should match open parenthesis #257: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:223: + arena_stdout("%s:%d Failed on iteration %d", __func__, + __LINE__, i); WARNING: line length of 87 exceeds 80 columns #301: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:21: +size_t __arena alloc_multiple_sizes[] = { 3, 17, 1025, 129, 16350, 333, 9, 517, 2099 }; CHECK: Alignment should match open parenthesis #437: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:157: + arena_stdout("%s:%d %lx %u vs %u", __func__, + __LINE__, (uintptr_t)&mem[j], WARNING: line length of 81 exceeds 80 columns #464: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:184: + arena_stdout("alignment test: alloc failed for size %lu", CHECK: Alignment should match open parenthesis #465: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:185: + arena_stdout("alignment test: alloc failed for size %lu", + alignment_sizes[i]); CHECK: Lines should not end with a '(' #472: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:192: + arena_stdout( CHECK: Alignment should match open parenthesis #509: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:14: +static void run_libarena_test(struct libarena *skel, struct bpf_program *prog, + const char *name) WARNING: line length of 88 exceeds 80 columns #514: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:19: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset)); CHECK: Blank lines aren't necessary before a close brace '}' #523: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:28: + +} WARNING: line length of 86 exceeds 80 columns #542: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:47: + ret = libarena_run_prog_args(bpf_program__fd(skel->progs.arena_alloc_reserve), CHECK: Alignment should match open parenthesis #543: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:48: + ret = libarena_run_prog_args(bpf_program__fd(skel->progs.arena_alloc_reserve), + &args, sizeof(args)); CHECK: Alignment should match open parenthesis #583: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:16: +static void run_libarena_asan_test(struct libarena_asan *skel, + struct bpf_program *prog, const char *name) WARNING: line length of 88 exceeds 80 columns #588: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:21: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset)); WARNING: line length of 86 exceeds 80 columns #614: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:47: + ret = libarena_run_prog_args(bpf_program__fd(skel->progs.arena_alloc_reserve), CHECK: Alignment should match open parenthesis #615: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:48: + ret = libarena_run_prog_args(bpf_program__fd(skel->progs.arena_alloc_reserve), + &args, sizeof(args)); CHECK: Lines should not end with a '(' #619: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:52: + ret = libarena_asan_init( WARNING: void function return statements are not generally useful #657: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:90: + return; +} total: 0 errors, 12 warnings, 14 checks, 606 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4b0d2ac1b8ae ("selftests/bpf: Add selftests for libarena buddy allocator") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 14 checks, 606 lines checked