WARNING: Improper SPDX comment style for 'tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h', please use '/*' instead #186: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:1: +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #186: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:1: +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause CHECK: spaces preferred around that '*' (ctx:WxV) #193: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:8: +static inline void print_asan_map_state(void __arena *addr) ^ CHECK: Alignment should match open parenthesis #196: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:11: + arena_stdout("%s:%d ASAN %p -> (val: %x gran: %x set: [%s])", + __func__, __LINE__, addr, CHECK: spaces preferred around that '*' (ctx:WxV) #205: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:20: +static inline int asan_validate_addr(bool cond, void __arena *addr) ^ CHECK: Unnecessary parentheses around 'asan_violated != 0' #207: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:22: + if ((asan_violated != 0) == cond) { CHECK: Alignment should match open parenthesis #213: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:28: + arena_stdout("%s:%d ASAN asan_violated %lx", __func__, __LINE__, + (u64)asan_violated); CHECK: Alignment should match open parenthesis #227: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:42: + arena_stdout("%s:%d Found ASAN violation at %lx", __func__, __LINE__, + asan_violated); WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #235: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:50: + volatile u8 mem[59]; total: 0 errors, 3 warnings, 6 checks, 198 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 368b8f068fbf ("selftests/bpf: Add ASAN support for libarena selftests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 3 warnings, 6 checks, 198 lines checked