CHECK: Prefer kernel type 'u32' over 'uint32_t'
#114: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:97:
+				    uint32_t ioresource_types, int32_t *bars)

CHECK: Prefer kernel type 's32' over 'int32_t'
#116: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:99:
+	int32_t pos = 0;

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#117: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:100:
+	uint8_t type = 0;

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#118: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:101:
+	uint8_t bar = 0;

WARNING: line length of 100 exceeds 80 columns
#122: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:105:
+		pci_read_config_byte(pdev, pos + offsetof(struct zxdh_pf_pci_cap, cfg_type), &type);

WARNING: line length of 94 exceeds 80 columns
#123: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:106:
+		pci_read_config_byte(pdev, pos + offsetof(struct zxdh_pf_pci_cap, bar), &bar);

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#143: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:126:
+				     uint32_t start, uint32_t size,

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#148: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:131:
+	uint8_t bar = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#149: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:132:
+	uint32_t offset = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#150: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:133:
+	uint32_t length = 0;

WARNING: line length of 86 exceeds 80 columns
#153: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:136:
+	pci_read_config_byte(pdev, off + offsetof(struct zxdh_pf_pci_cap, bar), &bar);

WARNING: line length of 93 exceeds 80 columns
#154: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:137:
+	pci_read_config_dword(pdev, off + offsetof(struct zxdh_pf_pci_cap, offset), &offset);

WARNING: line length of 93 exceeds 80 columns
#155: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:138:
+	pci_read_config_dword(pdev, off + offsetof(struct zxdh_pf_pci_cap, length), &length);

WARNING: line length of 89 exceeds 80 columns
#161: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:144:
+		LOG_ERR(dh_dev, "bad capability len %u (>%u expected)\n", length, start);

WARNING: line length of 92 exceeds 80 columns
#166: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:149:
+		LOG_ERR(dh_dev, "bad capability len %u (>=%zu expected)\n", length, minlen);

WARNING: line length of 88 exceeds 80 columns
#188: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:171:
+	if (minlen + offset < minlen || minlen + offset > pci_resource_len(pdev, bar)) {

WARNING: line length of 94 exceeds 80 columns
#189: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:172:
+		LOG_ERR(dh_dev, "map custom queue %zu@%u out of range on bar %i length %lu\n",

WARNING: line length of 89 exceeds 80 columns
#190: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:173:
+			minlen, offset, bar, (unsigned long)pci_resource_len(pdev, bar));

WARNING: braces {} are not necessary for any arm of this statement
#195: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:178:
+	if (!p) {
[...]
+	} else if (pa) {
[...]

WARNING: line length of 101 exceeds 80 columns
#196: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:179:
+		LOG_ERR(dh_dev, "unable to map custom queue %u@%u on bar %i\n", length, offset, bar);

CHECK: Prefer kernel type 's32' over 'int32_t'
#206: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:189:
+	int32_t common = 0;

WARNING: line length of 96 exceeds 80 columns
#215: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:198:
+		LOG_ERR(dh_dev, "missing capabilities %i, leaving for legacy driver\n", common);

WARNING: line length of 86 exceeds 80 columns
#220: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:203:
+						sizeof(struct zxdh_pf_pci_common_cfg),

WARNING: line length of 86 exceeds 80 columns
#222: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:205:
+						sizeof(struct zxdh_pf_pci_common_cfg),

CHECK: Prefer kernel type 's32' over 'int32_t'
#234: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:217:
+	int32_t notify = 0;

WARNING: line length of 84 exceeds 80 columns
#249: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:232:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,

WARNING: line length of 91 exceeds 80 columns
#250: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:233:
+				notify_off_multiplier), &pf_dev->notify_offset_multiplier);

CHECK: Alignment should match open parenthesis
#250: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:233:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,
+				notify_off_multiplier), &pf_dev->notify_offset_multiplier);

WARNING: line length of 84 exceeds 80 columns
#251: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:234:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,

CHECK: Alignment should match open parenthesis
#252: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:235:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,
+				cap.length), &notify_length);

WARNING: line length of 84 exceeds 80 columns
#253: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:236:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,

CHECK: Alignment should match open parenthesis
#254: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:237:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,
+				cap.offset), &notify_offset);

WARNING: line length of 96 exceeds 80 columns
#257: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:240:
+	 * If notify length is small, map it all now. Otherwise, map each VQ individually later.

CHECK: Alignment should match open parenthesis
#261: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:244:
+		pf_dev->notify_base = zxdh_pf_map_capability(dh_dev, notify,
+							    ZXDH_PF_MAP_MINLEN2,

WARNING: line length of 86 exceeds 80 columns
#265: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:248:
+							    &pf_dev->notify_pa, NULL);

CHECK: Prefer kernel type 's32' over 'int32_t'
#279: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:262:
+	int32_t device = 0;

WARNING: line length of 102 exceeds 80 columns
#283: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:266:
+	/* Device capability is only mandatory for devices that have device-specific configuration. */

WARNING: line length of 111 exceeds 80 columns
#288: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:271:
+	/* we don't know how much we should map, but PAGE_SIZE is more than enough for all existing devices. */

WARNING: line length of 84 exceeds 80 columns
#291: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:274:
+						       ZXDH_PF_ALIGN4, 0, PAGE_SIZE,

CHECK: Alignment should match open parenthesis
#291: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:274:
+		pf_dev->device = zxdh_pf_map_capability(dh_dev, device, 0,
+						       ZXDH_PF_ALIGN4, 0, PAGE_SIZE,

WARNING: line length of 81 exceeds 80 columns
#292: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:275:
+						       &pf_dev->device_len, NULL,

WARNING: line length of 81 exceeds 80 columns
#293: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:276:
+						       &pf_dev->dev_cfg_bar_off);

CHECK: Prefer kernel type 's32' over 'int32_t'
#316: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:299:
+	int32_t ret = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#349: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:332:
+				      uint16_t phy_index, uint16_t index)

CHECK: Alignment should match open parenthesis
#362: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:345:
+void __iomem *zxdh_pf_map_vq_notify(struct dh_core_dev *dh_dev,
+				     uint16_t phy_index, uint16_t index,

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#362: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:345:
+				     uint16_t phy_index, uint16_t index,

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#366: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:349:
+	uint16_t off = 0;

WARNING: line length of 96 exceeds 80 columns
#372: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:355:
+		if ((uint64_t)off * pf_dev->notify_offset_multiplier + 2 > pf_dev->notify_len) {

WARNING: line length of 95 exceeds 80 columns
#373: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:356:
+			LOG_ERR(dh_dev, "bad notification offset %u (x %u) for queue %u > %zd",

WARNING: line length of 81 exceeds 80 columns
#374: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:357:
+				off, pf_dev->notify_offset_multiplier, phy_index,

WARNING: line length of 89 exceeds 80 columns
#380: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:363:
+			*pa = pf_dev->notify_pa + off * pf_dev->notify_offset_multiplier;

WARNING: line length of 84 exceeds 80 columns
#382: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:365:
+		return pf_dev->notify_base + off * pf_dev->notify_offset_multiplier;

WARNING: line length of 83 exceeds 80 columns
#384: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:367:
+		return zxdh_pf_map_capability(dh_dev, pf_dev->notify_map_cap, 2, 2,

WARNING: line length of 85 exceeds 80 columns
#385: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:368:
+					      off * pf_dev->notify_offset_multiplier,

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#415: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:398:
+	uint8_t config_generation = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#425: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:408:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#426: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:409:
+	uint16_t DEV_MAC_H = 0;

WARNING: line length of 87 exceeds 80 columns
#446: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:429:
+void zxdh_pf_set_vf_mac_reg(struct zxdh_pf_device *pf_dev, uint8_t *mac, int32_t vf_id)

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#448: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:431:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#449: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:432:
+	uint16_t DEV_MAC_H = 0;

WARNING: line length of 85 exceeds 80 columns
#452: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:435:
+		DEV_MAC_L = mac[0] | (mac[1] << 8) | (mac[2] << 16) | (mac[3] << 24);

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#473: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:456:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#474: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:457:
+	uint16_t DEV_MAC_H = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#485: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:468:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#486: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:469:
+	uint16_t DEV_MAC_H = 0;

CHECK: Prefer kernel type 'u64' over 'uint64_t'
#502: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:485:
+	uint64_t device_feature = 0;

WARNING: line length of 86 exceeds 80 columns
#507: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:490:
+	device_feature |= ((uint64_t)ioread32(&pf_dev->common->device_feature) << 32);

CHECK: Prefer kernel type 's32' over 'int32_t'
#570: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:67:
+	int32_t notify_map_cap;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#571: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:68:
+	uint32_t notify_offset_multiplier;

CHECK: Prefer kernel type 's32' over 'int32_t'
#573: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:70:
+	int32_t modern_bars;

CHECK: Prefer kernel type 'u64' over 'uint64_t'
#576: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:73:
+	uint64_t sriov_bar_size;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#577: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:74:
+	uint32_t dev_cfg_bar_off;

total: 0 errors, 36 warnings, 36 checks, 544 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit fedfdb35e0e0 ("net/ethernet/zte/dinghai: add hardware register access and PCI capability scanning") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 36 warnings, 36 checks, 544 lines checked