WARNING: line length of 88 exceeds 80 columns #100: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:108: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset)); WARNING: line length of 81 exceeds 80 columns #165: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:53: + * verification failures if verified with the rest of asan_test_buddy_uaf_single. CHECK: spaces preferred around that '*' (ctx:WxV) #167: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:55: +__weak int asan_test_buddy_byte(u8 __arena __arg_arena *mem, int i, bool freed) ^ CHECK: Alignment should match open parenthesis #173: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:61: + if (freed && BUDDY_HEADER_OFF <= i && + i < BUDDY_HEADER_OFF + sizeof(struct buddy_header)) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #222: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:110: + volatile u8 mem[48]; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #228: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:116: + volatile struct buddy_blob __arena *blob; WARNING: Prefer ARRAY_SIZE(sizes) #270: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:158: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #274: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:162: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); WARNING: Prefer ARRAY_SIZE(sizes) #301: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:189: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #305: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:193: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); CHECK: Alignment should match open parenthesis #336: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:224: + arena_stdout("%s:%d Failed on iteration %d", __func__, + __LINE__, i); WARNING: line length of 87 exceeds 80 columns #380: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:21: +size_t __arena alloc_multiple_sizes[] = { 3, 17, 1025, 129, 16350, 333, 9, 517, 2099 }; CHECK: Alignment should match open parenthesis #516: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:157: + arena_stdout("%s:%d %lx %u vs %u", __func__, + __LINE__, &mem[j], mem[j], poison); WARNING: line length of 81 exceeds 80 columns #542: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:183: + arena_stdout("alignment test: alloc failed for size %lu", CHECK: Alignment should match open parenthesis #543: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:184: + arena_stdout("alignment test: alloc failed for size %lu", + alignment_sizes[i]); CHECK: Lines should not end with a '(' #550: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:191: + arena_stdout( CHECK: Alignment should match open parenthesis #587: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:14: +static void run_libarena_test(struct libarena *skel, struct bpf_program *prog, + const char *name) WARNING: line length of 88 exceeds 80 columns #592: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:19: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset)); CHECK: Blank lines aren't necessary before a close brace '}' #601: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:28: + +} WARNING: line length of 82 exceeds 80 columns #617: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:44: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_alloc_reserve)); CHECK: Alignment should match open parenthesis #657: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:16: +static void run_libarena_asan_test(struct libarena_asan *skel, + struct bpf_program *prog, const char *name) WARNING: line length of 88 exceeds 80 columns #662: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:21: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset)); WARNING: line length of 82 exceeds 80 columns #685: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:44: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_alloc_reserve)); CHECK: Lines should not end with a '(' #689: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:48: + ret = libarena_asan_init( WARNING: void function return statements are not generally useful #727: FILE: tools/testing/selftests/bpf/prog_tests/libarena_asan.c:86: + return; +} total: 0 errors, 13 warnings, 12 checks, 656 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 5f700f1c6312 ("selftests/bpf: Add selftests for libarena buddy allocator") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 13 warnings, 12 checks, 656 lines checked