WARNING: do not add new typedefs #182: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:24: +typedef struct libarena_asan selftest; WARNING: line length of 82 exceeds 80 columns #208: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:85: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_alloc_reserve)); CHECK: Lines should not end with a '(' #213: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:90: + ret = libarena_asan_init( WARNING: line length of 87 exceeds 80 columns #233: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:118: + /* Check if our BPF programs are ASAN-capable using strstr on the prog name. */ WARNING: line length of 81 exceeds 80 columns #238: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:122: + printf("=== %s %s===\n", "libarena selftests", is_asan ? "(asan) " : ""); WARNING: line length of 86 exceeds 80 columns #256: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:172: + if (!libarena_is_test_prog(name) && !libarena_is_asan_test_prog(name)) WARNING: Improper SPDX comment style for 'tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h', please use '/*' instead #266: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:1: +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #266: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:1: +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause CHECK: spaces preferred around that '*' (ctx:WxV) #273: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:8: +static inline void print_asan_map_state(void __arena *addr) ^ CHECK: Alignment should match open parenthesis #276: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:11: + arena_stdout("%s:%d ASAN %p -> (val: %x gran: %x set: [%s])", + __func__, __LINE__, addr, CHECK: spaces preferred around that '*' (ctx:WxV) #285: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:20: +static inline int asan_validate_addr(bool cond, void __arena *addr) ^ CHECK: Unnecessary parentheses around 'asan_violated != 0' #287: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:22: + if ((asan_violated != 0) == cond) { CHECK: Alignment should match open parenthesis #293: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:28: + arena_stdout("%s:%d ASAN asan_violated %lx", __func__, __LINE__, + (u64)asan_violated); CHECK: Alignment should match open parenthesis #304: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:39: + arena_stdout("%s:%d Found ASAN violation at %lx", __func__, __LINE__, + asan_violated); WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #310: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_common.h:45: + volatile u8 mem[59]; total: 0 errors, 8 warnings, 7 checks, 258 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d0d98c0187d5 ("selftests/bpf: Add ASAN support for libarena selftests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 7 checks, 258 lines checked