CHECK: Unnecessary parentheses around 'new_prs == PRS_ISOLATED' #101: FILE: kernel/cgroup/cpuset.c:1675: + if (tick_nohz_full_enabled() && (new_prs == PRS_ISOLATED) && + cpumask_intersects(tmp->new_cpus, offline_disabled_cpus)) CHECK: Unnecessary parentheses around 'prs == PRS_ISOLATED' #115: FILE: kernel/cgroup/cpuset.c:1767: + if (tick_nohz_full_enabled() && (prs == PRS_ISOLATED) && + cpumask_intersects(excpus, offline_disabled_cpus)) { CHECK: Unnecessary parentheses around 'new_prs == PRS_ISOLATED' #128: FILE: kernel/cgroup/cpuset.c:1940: + if (tick_nohz_full_enabled() && + (new_prs == PRS_ISOLATED) && + cpumask_intersects(xcpus, offline_disabled_cpus)) CHECK: Unnecessary parentheses around 'old_prs == PRS_ISOLATED' #144: FILE: kernel/cgroup/cpuset.c:2015: + if (tick_nohz_full_enabled() && + ((old_prs == PRS_ISOLATED) || + (old_prs == PRS_INVALID_ISOLATED)) && + cpumask_intersects(newmask, offline_disabled_cpus)) { CHECK: Unnecessary parentheses around 'old_prs == PRS_INVALID_ISOLATED' #144: FILE: kernel/cgroup/cpuset.c:2015: + if (tick_nohz_full_enabled() && + ((old_prs == PRS_ISOLATED) || + (old_prs == PRS_INVALID_ISOLATED)) && + cpumask_intersects(newmask, offline_disabled_cpus)) { CHECK: Alignment should match open parenthesis #145: FILE: kernel/cgroup/cpuset.c:2016: + if (tick_nohz_full_enabled() && + ((old_prs == PRS_ISOLATED) || WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #183: FILE: kernel/cgroup/cpuset.c:3883: + BUG_ON(!zalloc_cpumask_var(&offline_disabled_cpus, GFP_KERNEL)); total: 0 errors, 1 warnings, 6 checks, 173 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit cd7a83920dd8 ("cgroup/cpuset: Prevent offline_disabled CPUs from being used in isolated partition") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 6 checks, 173 lines checked