CHECK: No space is necessary after a cast #75: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:27: + const char *pa = *(const char **) ppa; CHECK: No space is necessary after a cast #76: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:28: + const char *pb = *(const char **) ppb; WARNING: line length of 81 exceeds 80 columns #85: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:37: +static __u32 *get_ids(const char * const funcs[], int funcs_cnt, const char *mod) WARNING: line length of 84 exceeds 80 columns #147: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:99: + * We keep pointer for each function name so we can get the original WARNING: line length of 85 exceeds 80 columns #148: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:100: + * array index and have the resulting ids array matching the original WARNING: line length of 81 exceeds 80 columns #151: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:103: + * Doing it this way allow us to easily test the cookies support, WARNING: line length of 86 exceeds 80 columns #181: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:133: + ASSERT_EQ(skel->bss->test_result_fentry, FUNCS_CNT + 1, "test_result_fentry"); WARNING: line length of 84 exceeds 80 columns #182: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:134: + ASSERT_EQ(skel->bss->test_result_fexit, FUNCS_CNT + 1, "test_result_fexit"); WARNING: line length of 92 exceeds 80 columns #216: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:168: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, CHECK: Alignment should match open parenthesis #217: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:169: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, + "bpf_fentry_test*", NULL); WARNING: line length of 89 exceeds 80 columns #218: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:170: + if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi")) WARNING: line length of 90 exceeds 80 columns #221: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:173: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, CHECK: Alignment should match open parenthesis #222: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:174: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, + "bpf_fentry_test*", NULL); WARNING: line length of 88 exceeds 80 columns #223: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:175: + if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi")) WARNING: line length of 96 exceeds 80 columns #226: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:178: + skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s, CHECK: Alignment should match open parenthesis #227: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:179: + skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s, + "bpf_fentry_test1", NULL); WARNING: line length of 91 exceeds 80 columns #228: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:180: + if (!ASSERT_OK_PTR(skel->links.test_fentry_s, "bpf_program__attach_tracing_multi")) WARNING: line length of 94 exceeds 80 columns #231: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:183: + skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s, CHECK: Alignment should match open parenthesis #232: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:184: + skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s, + "bpf_fentry_test1", NULL); WARNING: line length of 90 exceeds 80 columns #233: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:185: + if (!ASSERT_OK_PTR(skel->links.test_fexit_s, "bpf_program__attach_tracing_multi")) WARNING: line length of 92 exceeds 80 columns #262: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:214: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, CHECK: Alignment should match open parenthesis #263: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:215: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, + NULL, &opts); WARNING: line length of 89 exceeds 80 columns #264: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:216: + if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi")) WARNING: line length of 90 exceeds 80 columns #267: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:219: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, CHECK: Alignment should match open parenthesis #268: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:220: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, + NULL, &opts); WARNING: line length of 88 exceeds 80 columns #269: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:221: + if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi")) WARNING: line length of 96 exceeds 80 columns #274: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:226: + skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s, CHECK: Alignment should match open parenthesis #275: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:227: + skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s, + NULL, &opts); WARNING: line length of 91 exceeds 80 columns #276: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:228: + if (!ASSERT_OK_PTR(skel->links.test_fentry_s, "bpf_program__attach_tracing_multi")) WARNING: line length of 94 exceeds 80 columns #279: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:231: + skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s, CHECK: Alignment should match open parenthesis #280: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:232: + skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s, + NULL, &opts); WARNING: line length of 90 exceeds 80 columns #281: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:233: + if (!ASSERT_OK_PTR(skel->links.test_fexit_s, "bpf_program__attach_tracing_multi")) WARNING: line length of 92 exceeds 80 columns #318: FILE: tools/testing/selftests/bpf/progs/tracing_multi_attach.c:8: +__hidden extern int tracing_multi_arg_check(__u64 *ctx, __u64 *test_result, bool is_return); WARNING: externs should be avoided in .c files #366: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:11: +extern const void bpf_fentry_test2 __ksym; WARNING: externs should be avoided in .c files #367: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:12: +extern const void bpf_fentry_test3 __ksym; WARNING: externs should be avoided in .c files #368: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:13: +extern const void bpf_fentry_test4 __ksym; WARNING: externs should be avoided in .c files #369: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:14: +extern const void bpf_fentry_test5 __ksym; WARNING: externs should be avoided in .c files #370: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:15: +extern const void bpf_fentry_test6 __ksym; WARNING: externs should be avoided in .c files #371: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:16: +extern const void bpf_fentry_test7 __ksym; WARNING: externs should be avoided in .c files #372: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:17: +extern const void bpf_fentry_test8 __ksym; WARNING: externs should be avoided in .c files #373: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:18: +extern const void bpf_fentry_test9 __ksym; WARNING: externs should be avoided in .c files #374: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:19: +extern const void bpf_fentry_test10 __ksym; CHECK: No space is necessary after a cast #378: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:23: + void *ip = (void *) bpf_get_func_ip(ctx); CHECK: No space is necessary after a cast #392: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:37: + a = (int) value; CHECK: No space is necessary after a cast #402: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:47: + a = (int) value; CHECK: No space is necessary after a cast #415: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:60: + a = (char) value; CHECK: No space is necessary after a cast #417: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:62: + b = (int) value; CHECK: No space is necessary after a cast #431: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:76: + a = (void *) value; CHECK: No space is necessary after a cast #433: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:78: + b = (char) value; CHECK: No space is necessary after a cast #435: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:80: + c = (int) value; WARNING: line length of 91 exceeds 80 columns #441: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:86: + *test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10; CHECK: No space is necessary after a cast #441: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:86: + *test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10; CHECK: No space is necessary after a cast #452: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:97: + b = (void *) value; CHECK: No space is necessary after a cast #454: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:99: + c = (short) value; CHECK: No space is necessary after a cast #456: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:101: + d = (int) value; WARNING: line length of 105 exceeds 80 columns #462: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:107: + *test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15; CHECK: No space is necessary after a cast #462: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:107: + *test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15; CHECK: No space is necessary after a cast #474: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:119: + b = (void *) value; CHECK: No space is necessary after a cast #476: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:121: + c = (short) value; CHECK: No space is necessary after a cast #478: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:123: + d = (int) value; CHECK: No space is necessary after a cast #480: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:125: + e = (void *) value; WARNING: line length of 125 exceeds 80 columns #486: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:131: + *test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21; CHECK: No space is necessary after a cast #486: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:131: + *test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21; total: 0 errors, 35 warnings, 28 checks, 461 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit cb7ea6bcd34d ("selftests/bpf: Add tracing multi skel/pattern/ids attach tests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 35 warnings, 28 checks, 461 lines checked