WARNING: Missing a blank line after declarations #59: FILE: tools/testing/selftests/bpf/prog_tests/stack_arg.c:12: + int err, prog_fd; + LIBBPF_OPTS(bpf_test_run_opts, topts, CHECK: Alignment should match open parenthesis #60: FILE: tools/testing/selftests/bpf/prog_tests/stack_arg.c:13: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .data_in = &pkt_v4, WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #214: FILE: tools/testing/selftests/bpf/progs/stack_arg.c:28: +const volatile bool has_stack_arg = true; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #394: FILE: tools/testing/selftests/bpf/progs/stack_arg.c:208: +const volatile bool has_stack_arg = false; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #457: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:11: +const volatile bool has_stack_arg = true; ERROR: space prohibited before that ':' (ctx:WxV) #460: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:14: + u64 :64; ^ ERROR: space prohibited before that ':' (ctx:WxV) #461: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:15: + u64 :64; ^ WARNING: line length of 96 exceeds 80 columns #464: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:18: +extern int bpf_iter_testmod_seq_new(struct bpf_iter_testmod_seq *it, s64 value, int cnt) __ksym; WARNING: externs should be avoided in .c files #465: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:19: +extern int *bpf_iter_testmod_seq_next(struct bpf_iter_testmod_seq *it) __ksym; WARNING: line length of 81 exceeds 80 columns #466: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:20: +extern void bpf_iter_testmod_seq_destroy(struct bpf_iter_testmod_seq *it) __ksym; WARNING: const array should probably be static const #534: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:88: +const char cstr[] = "hello"; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #558: FILE: tools/testing/selftests/bpf/progs/stack_arg_kfunc.c:112: +const volatile bool has_stack_arg = false; WARNING: line length of 82 exceeds 80 columns #638: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod.c:847: +__bpf_kfunc u64 bpf_kfunc_call_stack_arg_dynptr(u64 a, u64 b, u64 c, u64 d, u64 e, CHECK: Alignment should match open parenthesis #639: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod.c:848: +__bpf_kfunc u64 bpf_kfunc_call_stack_arg_dynptr(u64 a, u64 b, u64 c, u64 d, u64 e, + struct bpf_dynptr *ptr) WARNING: line length of 84 exceeds 80 columns #659: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod.c:868: + struct bpf_iter_testmod_seq *it__iter) WARNING: line length of 85 exceeds 80 columns #664: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod.c:873: +__bpf_kfunc u64 bpf_kfunc_call_stack_arg_const_str(u64 a, u64 b, u64 c, u64 d, u64 e, WARNING: line length of 81 exceeds 80 columns #670: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod.c:879: +__bpf_kfunc u64 bpf_kfunc_call_stack_arg_timer(u64 a, u64 b, u64 c, u64 d, u64 e, WARNING: line length of 82 exceeds 80 columns #720: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h:123: +__u64 bpf_kfunc_call_stack_arg_dynptr(__u64 a, __u64 b, __u64 c, __u64 d, __u64 e, WARNING: line length of 82 exceeds 80 columns #725: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h:128: + struct bpf_iter_testmod_seq *it__iter) __ksym; WARNING: line length of 85 exceeds 80 columns #726: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h:129: +__u64 bpf_kfunc_call_stack_arg_const_str(__u64 a, __u64 b, __u64 c, __u64 d, __u64 e, WARNING: line length of 81 exceeds 80 columns #728: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod_kfunc.h:131: +__u64 bpf_kfunc_call_stack_arg_timer(__u64 a, __u64 b, __u64 c, __u64 d, __u64 e, total: 2 errors, 17 warnings, 2 checks, 661 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c0e7fb5db8f6 ("selftests/bpf: Add tests for BPF function stack arguments") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.