ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.JfyvPAA1Py and /tmp/tmp.Uzt77Qpfkq Tree base: c36967d2db29 ("net: warn ops-locked drivers still using ndo_set_rx_mode") Now at: 2411099d9cf9 ("selftests: net: add team_bridge_macvlan rx_mode test") ====== Checking before the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 58: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 72: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 88: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 89: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 107: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 108: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 115: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 116: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 126: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 131: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 154: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 157: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 159: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 187: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 202: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 203: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 204: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 205: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 212: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 214: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 240: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 257: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 266: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 290: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 302: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 313: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 334: run_cmd ip -6 addr add $test_addr dev "$devdummy" valid_lft 300 preferred_lft 300 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -6 addr add "$test_addr" dev "$devdummy" valid_lft 300 preferred_lft 300 In rtnetlink.sh line 336: run_cmd ip -6 addr del $test_addr dev "$devdummy" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -6 addr del "$test_addr" dev "$devdummy" In rtnetlink.sh line 339: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 350: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 352: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 354: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 356: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 360: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 361: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 366: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 393: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 408: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 415: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 440: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 453: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 455: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 458: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 463: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 472: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 485: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 487: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 518: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 530: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 532: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 537: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 542: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 549: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 562: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 564: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 573: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 581: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 583: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 586: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 596: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 614: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 616: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 619: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 631: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 663: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 665: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 671: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 672: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 676: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 678: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 681: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 682: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 685: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 686: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 687: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 689: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 690: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 693: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 694: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 698: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 699: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 703: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 704: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 706: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 708: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 709: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 712: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 713: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 714: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 715: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 720: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 722: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 764: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 766: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 772: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 774: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 776: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 777: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 778: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 782: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 791: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 792: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 795: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 796: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 799: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 800: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 801: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 803: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 804: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 805: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 807: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 813: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 814: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 820: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 822: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 825: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 834: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 842: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 843: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 853: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 866: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 868: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 872: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 875: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 884: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 891: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 907: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 909: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 913: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 916: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 925: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 932: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 947: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 949: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 952: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 954: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 964: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 974: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 981: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 996: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 998: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1001: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1003: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1013: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1023: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1032: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1052: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1054: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1058: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1060: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1064: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 1066: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 1067: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 1068: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 1069: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 1070: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1071: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1072: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1074: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1076: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1092: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1094: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1098: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1100: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1104: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1105: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1106: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1107: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1108: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1109: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1110: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1111: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1113: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1115: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1131: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1133: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1137: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1138: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1139: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1142: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1143: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1144: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1147: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1148: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1149: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1152: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1153: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1154: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1156: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1172: run_cmd ip neigh add $proxy $dstip dev "$devdummy" lladdr $dstmac nud permanent ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$proxy" "$dstip" dev "$devdummy" lladdr "$dstmac" nud permanent In rtnetlink.sh line 1173: run_cmd_grep $dstip ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh show "$proxy" In rtnetlink.sh line 1174: run_cmd_grep_fail "$dstip dev $devdummy .*\(managed\|use\|router\|extern\)" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy .*\(managed\|use\|router\|extern\)" ip neigh show "$proxy" In rtnetlink.sh line 1177: run_cmd ip neigh change $proxy $dstip dev "$devdummy" extern_learn ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" extern_learn In rtnetlink.sh line 1178: run_cmd_grep "$dstip dev $devdummy .* extern_learn" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* extern_learn" ip neigh show "$proxy" In rtnetlink.sh line 1179: run_cmd_grep_fail "$dstip dev $devdummy .* \(managed\|use\|router\)" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy .* \(managed\|use\|router\)" ip neigh show "$proxy" In rtnetlink.sh line 1182: run_cmd ip neigh change $proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" In rtnetlink.sh line 1183: run_cmd_grep $dstip ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh show "$proxy" In rtnetlink.sh line 1184: run_cmd_grep_fail "$dstip dev $devdummy .* extern_learn" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy .* extern_learn" ip neigh show "$proxy" In rtnetlink.sh line 1187: run_cmd ip neigh change $proxy $dstip dev "$devdummy" protocol boot ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" protocol boot In rtnetlink.sh line 1188: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show "$proxy" In rtnetlink.sh line 1191: run_cmd ip neigh change $proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" In rtnetlink.sh line 1192: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show "$proxy" In rtnetlink.sh line 1195: run_cmd ip neigh change $proxy $dstip dev "$devdummy" protocol static ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" protocol static In rtnetlink.sh line 1196: run_cmd_grep "$dstip dev $devdummy .* proto static" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* proto static" ip neigh show "$proxy" In rtnetlink.sh line 1200: run_cmd ip neigh change $proxy $dstip dev "$devdummy" managed ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" managed In rtnetlink.sh line 1201: run_cmd_grep "$dstip dev $devdummy managed" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy managed" ip neigh show "$proxy" In rtnetlink.sh line 1203: run_cmd ip neigh change $proxy $dstip dev "$devdummy" lladdr $dstmac ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" lladdr "$dstmac" In rtnetlink.sh line 1204: run_cmd_grep_fail "$dstip dev $devdummy managed" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy managed" ip neigh show "$proxy" In rtnetlink.sh line 1207: run_cmd ip neigh del $proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$proxy" "$dstip" dev "$devdummy" In rtnetlink.sh line 1210: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1226: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1228: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1234: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1236: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1238: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1239: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1241: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1242: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1253: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1287: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1289: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1340: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1357: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1366: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1368: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1371: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1372: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1373: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1374: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1375: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1395: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1396: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1398: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1401: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1407: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1408: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1416: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1430: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1432: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1436: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1437: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1438: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1439: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1440: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1441: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1447: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1452: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1458: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1459: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1460: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1462: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1465: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1468: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1475: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1537: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1554: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 59: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 73: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 89: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 90: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 108: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 109: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 116: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 117: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 127: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 132: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 155: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 158: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 160: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 188: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 203: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 204: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 205: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 206: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 213: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 215: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 241: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 258: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 267: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 291: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 303: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 314: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 335: run_cmd ip -6 addr add $test_addr dev "$devdummy" valid_lft 300 preferred_lft 300 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -6 addr add "$test_addr" dev "$devdummy" valid_lft 300 preferred_lft 300 In rtnetlink.sh line 337: run_cmd ip -6 addr del $test_addr dev "$devdummy" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -6 addr del "$test_addr" dev "$devdummy" In rtnetlink.sh line 340: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 351: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 353: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 355: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 357: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 361: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 362: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 367: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 394: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 409: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 416: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 441: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 454: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 456: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 459: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 464: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 473: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 486: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 488: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 519: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 531: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 533: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 538: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 543: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 550: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 563: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 565: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 574: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 582: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 584: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 587: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 597: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 615: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 617: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 620: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 632: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 654: run_cmd ip link add $team type team ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link add "$team" type team In rtnetlink.sh line 655: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 657: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 660: run_cmd ip link add $dummy type dummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link add "$dummy" type dummy In rtnetlink.sh line 661: run_cmd ip link set $dummy master $team ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$dummy" master "$team" In rtnetlink.sh line 662: run_cmd ip link set $team up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$team" up In rtnetlink.sh line 663: run_cmd ip link add $bridge type bridge vlan_filtering 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link add "$bridge" type bridge vlan_filtering 1 In rtnetlink.sh line 664: run_cmd ip link set $bridge up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$bridge" up In rtnetlink.sh line 665: run_cmd ip link set $team master $bridge ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$team" master "$bridge" In rtnetlink.sh line 666: run_cmd ip link add link $bridge name $vlan \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link add link "$bridge" name "$vlan" \ In rtnetlink.sh line 668: run_cmd ip link set $vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$vlan" up In rtnetlink.sh line 670: run_cmd ip link del $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$vlan" In rtnetlink.sh line 671: run_cmd ip link del $bridge ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$bridge" In rtnetlink.sh line 672: run_cmd ip link del $team ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$team" In rtnetlink.sh line 673: run_cmd ip link del $dummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$dummy" In rtnetlink.sh line 675: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 707: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 709: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 715: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 716: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 720: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 722: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 725: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 726: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 729: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 730: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 731: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 733: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 734: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 737: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 738: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 742: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 743: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 747: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 748: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 750: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 752: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 753: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 756: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 757: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 758: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 759: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 764: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 766: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 808: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 810: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 816: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 818: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 820: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 821: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 822: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 826: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 835: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 836: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 839: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 840: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 843: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 844: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 845: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 847: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 848: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 849: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 851: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 857: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 858: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 864: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 866: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 869: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 878: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 886: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 887: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 897: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 910: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 912: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 916: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 919: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 928: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 935: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 951: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 953: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 957: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 960: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 969: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 976: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 991: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 993: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 996: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 998: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1008: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1018: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1025: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1040: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1042: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1045: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1047: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1057: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1067: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1076: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1096: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1098: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1102: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1104: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1108: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 1110: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 1111: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 1112: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 1113: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 1114: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1115: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1116: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1118: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1120: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1136: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1138: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1142: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1144: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1148: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1149: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1150: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1151: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1152: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1153: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1154: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1155: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1157: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1159: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1175: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1177: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1181: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1182: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1183: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1186: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1187: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1188: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1191: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1192: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1193: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1196: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1197: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1198: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1200: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1216: run_cmd ip neigh add $proxy $dstip dev "$devdummy" lladdr $dstmac nud permanent ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$proxy" "$dstip" dev "$devdummy" lladdr "$dstmac" nud permanent In rtnetlink.sh line 1217: run_cmd_grep $dstip ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh show "$proxy" In rtnetlink.sh line 1218: run_cmd_grep_fail "$dstip dev $devdummy .*\(managed\|use\|router\|extern\)" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy .*\(managed\|use\|router\|extern\)" ip neigh show "$proxy" In rtnetlink.sh line 1221: run_cmd ip neigh change $proxy $dstip dev "$devdummy" extern_learn ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" extern_learn In rtnetlink.sh line 1222: run_cmd_grep "$dstip dev $devdummy .* extern_learn" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* extern_learn" ip neigh show "$proxy" In rtnetlink.sh line 1223: run_cmd_grep_fail "$dstip dev $devdummy .* \(managed\|use\|router\)" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy .* \(managed\|use\|router\)" ip neigh show "$proxy" In rtnetlink.sh line 1226: run_cmd ip neigh change $proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" In rtnetlink.sh line 1227: run_cmd_grep $dstip ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh show "$proxy" In rtnetlink.sh line 1228: run_cmd_grep_fail "$dstip dev $devdummy .* extern_learn" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy .* extern_learn" ip neigh show "$proxy" In rtnetlink.sh line 1231: run_cmd ip neigh change $proxy $dstip dev "$devdummy" protocol boot ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" protocol boot In rtnetlink.sh line 1232: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show "$proxy" In rtnetlink.sh line 1235: run_cmd ip neigh change $proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" In rtnetlink.sh line 1236: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* proto boot" ip neigh show "$proxy" In rtnetlink.sh line 1239: run_cmd ip neigh change $proxy $dstip dev "$devdummy" protocol static ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" protocol static In rtnetlink.sh line 1240: run_cmd_grep "$dstip dev $devdummy .* proto static" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy .* proto static" ip neigh show "$proxy" In rtnetlink.sh line 1244: run_cmd ip neigh change $proxy $dstip dev "$devdummy" managed ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" managed In rtnetlink.sh line 1245: run_cmd_grep "$dstip dev $devdummy managed" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip dev $devdummy managed" ip neigh show "$proxy" In rtnetlink.sh line 1247: run_cmd ip neigh change $proxy $dstip dev "$devdummy" lladdr $dstmac ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh change "$proxy" "$dstip" dev "$devdummy" lladdr "$dstmac" In rtnetlink.sh line 1248: run_cmd_grep_fail "$dstip dev $devdummy managed" ip neigh show $proxy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep_fail "$dstip dev $devdummy managed" ip neigh show "$proxy" In rtnetlink.sh line 1251: run_cmd ip neigh del $proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$proxy" "$dstip" dev "$devdummy" In rtnetlink.sh line 1254: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1270: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1272: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1278: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1280: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1282: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1283: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1285: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1286: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1297: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1331: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1333: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1384: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1401: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1410: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1412: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1415: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1416: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1417: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1418: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1419: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1439: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1440: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1442: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1445: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1451: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1452: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1460: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1474: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1476: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1480: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1481: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1482: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1483: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1484: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1485: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1491: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1496: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1502: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1503: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1504: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1506: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1509: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1512: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1519: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1581: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1598: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi...