WARNING: line length of 84 exceeds 80 columns #68: FILE: kernel/bpf/verifier.c:2352: + /* If the input reg_state has no intersection between abstract values, it is WARNING: line length of 84 exceeds 80 columns #99: FILE: kernel/bpf/verifier.c:2422: + * If the min > max, then the range itself is ill-formed, so there can be no WARNING: line length of 81 exceeds 80 columns #106: FILE: kernel/bpf/verifier.c:2429: + * If the var_off is ill-formed, there can be no intersection in abstract WARNING: line length of 82 exceeds 80 columns #113: FILE: kernel/bpf/verifier.c:2436: + * Intersect u64 with s64. We map the s64 range to u64 domain and check if WARNING: line length of 82 exceeds 80 columns #115: FILE: kernel/bpf/verifier.c:2438: + * boundary, then we can treat it as a u64 range and check if its bounding WARNING: line length of 84 exceeds 80 columns #116: FILE: kernel/bpf/verifier.c:2439: + * values are outside the u64 range. If s64 range crosses the sign boundary, WARNING: line length of 84 exceeds 80 columns #118: FILE: kernel/bpf/verifier.c:2441: + * Intersection exists if the u64 range overlaps either of these components. WARNING: line length of 81 exceeds 80 columns #129: FILE: kernel/bpf/verifier.c:2452: + * Intersect u64 with tnum. If the bounding values of tnum when mapped to WARNING: line length of 84 exceeds 80 columns #131: FILE: kernel/bpf/verifier.c:2454: + * intersection. However, it is also possible that the tnum "jumps over" the WARNING: line length of 83 exceeds 80 columns #137: FILE: kernel/bpf/verifier.c:2460: + * In this case, if the next tnum value after umin is beyond umax, there is WARNING: line length of 84 exceeds 80 columns #149: FILE: kernel/bpf/verifier.c:2472: + * domain and check if there is an intersection with tnum. If s64 range does WARNING: line length of 82 exceeds 80 columns #150: FILE: kernel/bpf/verifier.c:2473: + * not cross the -1/0 sign boundary, we can treat it as a normal u64 range WARNING: line length of 81 exceeds 80 columns #154: FILE: kernel/bpf/verifier.c:2477: + * components. The tnum cannot "jump over" either of these two intervals, CHECK: No space is necessary after a cast #167: FILE: kernel/bpf/verifier.c:2490: + if (tmin > (u64)smax && tmax < (u64) smin) WARNING: line length of 88 exceeds 80 columns #183: FILE: kernel/bpf/verifier.c:2506: + if ((t32.value != (u32_min & ~t32.mask)) && (tnum_step(t32, u32_min) > u32_max)) WARNING: line length of 82 exceeds 80 columns #200: FILE: kernel/bpf/verifier.c:2523: + * Intersect u64 with u32. If the u64 range spans >=U32_MAX values then an WARNING: line length of 82 exceeds 80 columns #201: FILE: kernel/bpf/verifier.c:2524: + * intersection is guaranteed, so we skip that case. Otherwise, we map the WARNING: line length of 81 exceeds 80 columns #202: FILE: kernel/bpf/verifier.c:2525: + * u64 bounds to the u32 domain and check if the new u32 range intersects WARNING: line length of 82 exceeds 80 columns #203: FILE: kernel/bpf/verifier.c:2526: + * with the u32 bounds. When mapped, the u64 range might cross the U32_MAX WARNING: line length of 83 exceeds 80 columns #204: FILE: kernel/bpf/verifier.c:2527: + * boundary. If it doesn't cross the boundary, it forms a single contiguous WARNING: line length of 83 exceeds 80 columns #207: FILE: kernel/bpf/verifier.c:2530: + * ranges: [0, (u32)umax] and [(u32)umin, U32_MAX]. We check if any part of WARNING: line length of 83 exceeds 80 columns #209: FILE: kernel/bpf/verifier.c:2532: + * ensuring the u32 bounds are not trapped between (u32)umax and (u32)umin. WARNING: line length of 91 exceeds 80 columns #211: FILE: kernel/bpf/verifier.c:2534: + if (umax - umin < U32_MAX) { /* u64 range does not span the entire 32-bit domain */ WARNING: line length of 97 exceeds 80 columns #212: FILE: kernel/bpf/verifier.c:2535: + if ((u32)umin <= (u32)umax) { /* mapped u32 range is a single contiguous range */ WARNING: line length of 84 exceeds 80 columns #226: FILE: kernel/bpf/verifier.c:2549: + * overlap in the standard way. Otherwise, we get two contiguous ranges (one WARNING: line length of 82 exceeds 80 columns #227: FILE: kernel/bpf/verifier.c:2550: + * of which crosses the S32_MIN/S32_MAX boundary, and might also cross the WARNING: line length of 83 exceeds 80 columns #229: FILE: kernel/bpf/verifier.c:2552: + * Intersection exists if the s32 bounds overlap with either segment, which WARNING: line length of 91 exceeds 80 columns #233: FILE: kernel/bpf/verifier.c:2556: + if (umax - umin < U32_MAX) { /* u64 range does not span the entire 32-bit domain */ WARNING: line length of 97 exceeds 80 columns #234: FILE: kernel/bpf/verifier.c:2557: + if ((s32)umin <= (s32)umax) { /* mapped s32 range is a single contiguous range */ WARNING: line length of 84 exceeds 80 columns #237: FILE: kernel/bpf/verifier.c:2560: + } else { /* mapped s32 range crosses the S32_MIN/S32_MAX boundary */ WARNING: line length of 83 exceeds 80 columns #247: FILE: kernel/bpf/verifier.c:2570: + * does, we check that the u32 bounds are not trapped between (u32)smax and WARNING: line length of 101 exceeds 80 columns #250: FILE: kernel/bpf/verifier.c:2573: + if ((u64)smax - (u64)smin < U32_MAX) { /* s64 range does not span the entire 32-bit domain */ WARNING: line length of 97 exceeds 80 columns #251: FILE: kernel/bpf/verifier.c:2574: + if ((u32)smin <= (u32)smax) { /* mapped u32 range is a single contiguous range */ WARNING: line length of 81 exceeds 80 columns #264: FILE: kernel/bpf/verifier.c:2587: + * standard way. If it does, we check that the s32 bounds are not trapped WARNING: line length of 101 exceeds 80 columns #267: FILE: kernel/bpf/verifier.c:2590: + if ((u64)smax - (u64)smin < U32_MAX) { /* s64 range does not span the entire 32-bit domain */ WARNING: line length of 108 exceeds 80 columns #268: FILE: kernel/bpf/verifier.c:2591: + if ((s32)smin <= (s32)smax) { /* mapped s32 range does not cross S32_MAX/S32_MIN boundary */ WARNING: line length of 95 exceeds 80 columns #288: FILE: kernel/bpf/verifier.c:15699: + if (!reg_bounds_intersect(&env->false_reg1) || !reg_bounds_intersect(&env->false_reg2)) WARNING: line length of 93 exceeds 80 columns #297: FILE: kernel/bpf/verifier.c:15711: + if (!reg_bounds_intersect(&env->true_reg1) || !reg_bounds_intersect(&env->true_reg2)) total: 0 errors, 37 warnings, 1 checks, 240 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit cd732d0e8055 ("bpf/verifier: Use intersection checks when simulating to detect dead branches") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 37 warnings, 1 checks, 240 lines checked