ERROR: space required before the open parenthesis '('
#115: FILE: drivers/net/slip/slhc.c:574:
+			if((x = decode(&cp, end)) == -1) {

ERROR: do not use assignment in if condition
#115: FILE: drivers/net/slip/slhc.c:574:
+			if((x = decode(&cp, end)) == -1) {

WARNING: braces {} are not necessary for single statement blocks
#115: FILE: drivers/net/slip/slhc.c:574:
+			if((x = decode(&cp, end)) == -1) {
 				goto bad;
 			}

ERROR: space required before the open parenthesis '('
#123: FILE: drivers/net/slip/slhc.c:581:
+			if((x = decode(&cp, end)) == -1) {

ERROR: do not use assignment in if condition
#123: FILE: drivers/net/slip/slhc.c:581:
+			if((x = decode(&cp, end)) == -1) {

WARNING: braces {} are not necessary for single statement blocks
#123: FILE: drivers/net/slip/slhc.c:581:
+			if((x = decode(&cp, end)) == -1) {
 				goto bad;
 			}

ERROR: space required before the open parenthesis '('
#130: FILE: drivers/net/slip/slhc.c:587:
+			if((x = decode(&cp, end)) == -1) {

ERROR: do not use assignment in if condition
#130: FILE: drivers/net/slip/slhc.c:587:
+			if((x = decode(&cp, end)) == -1) {

WARNING: braces {} are not necessary for single statement blocks
#130: FILE: drivers/net/slip/slhc.c:587:
+			if((x = decode(&cp, end)) == -1) {
 				goto bad;
 			}

ERROR: space required before the open parenthesis '('
#137: FILE: drivers/net/slip/slhc.c:593:
+			if((x = decode(&cp, end)) == -1) {

ERROR: do not use assignment in if condition
#137: FILE: drivers/net/slip/slhc.c:593:
+			if((x = decode(&cp, end)) == -1) {

WARNING: braces {} are not necessary for single statement blocks
#137: FILE: drivers/net/slip/slhc.c:593:
+			if((x = decode(&cp, end)) == -1) {
 				goto bad;
 			}

ERROR: space required before the open parenthesis '('
#146: FILE: drivers/net/slip/slhc.c:601:
+		if((x = decode(&cp, end)) == -1) {

ERROR: do not use assignment in if condition
#146: FILE: drivers/net/slip/slhc.c:601:
+		if((x = decode(&cp, end)) == -1) {

WARNING: braces {} are not necessary for single statement blocks
#146: FILE: drivers/net/slip/slhc.c:601:
+		if((x = decode(&cp, end)) == -1) {
 			goto bad;
 		}

total: 10 errors, 5 warnings, 0 checks, 109 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 73d6ccc574f9 ("slip: bound decode() reads against the compressed packet length") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.