CHECK: Comparison to NULL could be written "!ctx.offsets" #224: FILE: arch/arm/net/bpf_jit_32.c:2167: + if (ctx.offsets == NULL) CHECK: Comparison to NULL could be written "!ctx.imms" #247: FILE: arch/arm/net/bpf_jit_32.c:2197: + if (ctx.imms == NULL) CHECK: Comparison to NULL could be written "!header" #259: FILE: arch/arm/net/bpf_jit_32.c:2220: + if (header == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #350: FILE: arch/arm64/net/bpf_jit_comp.c:2059: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #518: FILE: arch/loongarch/net/bpf_jit.c:1964: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!addrs" #860: FILE: arch/powerpc/net/bpf_jit_comp.c:236: + if (addrs == NULL) CHECK: Comparison to NULL could be written "!jit.addrs" #1152: FILE: arch/s390/net/bpf_jit_comp.c:2343: + if (jit.addrs == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #1270: FILE: arch/sparc/net/bpf_jit_comp_64.c:1515: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!header" #1296: FILE: arch/sparc/net/bpf_jit_comp_64.c:1553: + if (header == NULL) WARNING: line length of 89 exceeds 80 columns #1558: FILE: include/linux/filter.h:1192: +static inline struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off, WARNING: line length of 89 exceeds 80 columns #1559: FILE: include/linux/filter.h:1193: + const struct bpf_insn *patch, u32 len) WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #1561: FILE: include/linux/filter.h:1195: + return ERR_PTR(-ENOTSUPP); WARNING: line length of 94 exceeds 80 columns #1573: FILE: include/linux/filter.h:1325: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog); WARNING: line length of 93 exceeds 80 columns #1594: FILE: include/linux/filter.h:1477: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog) WARNING: line length of 93 exceeds 80 columns #1599: FILE: include/linux/filter.h:1482: +static inline void bpf_jit_prog_release_other(struct bpf_prog *fp, struct bpf_prog *fp_other) WARNING: line length of 86 exceeds 80 columns #1615: FILE: kernel/bpf/core.c:1512: + * Now this function is used only to blind the main prog and must be invoked only when WARNING: line length of 93 exceeds 80 columns #1618: FILE: kernel/bpf/core.c:1515: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog) WARNING: line length of 84 exceeds 80 columns #1651: FILE: kernel/bpf/core.c:1564: + tmp = bpf_patch_insn_single(clone, i, insn_buff, rewritten); WARNING: line length of 93 exceeds 80 columns #1675: FILE: kernel/bpf/core.c:1585: + * Instructions arrays must be updated using absolute xlated offsets. WARNING: line length of 94 exceeds 80 columns #1676: FILE: kernel/bpf/core.c:1586: + * The arrays have already been adjusted by bpf_patch_insn_data() when WARNING: line length of 86 exceeds 80 columns #1760: FILE: kernel/bpf/fixups.c:988: +static void bpf_restore_subprog_starts(struct bpf_verifier_env *env, u32 *orig_starts) WARNING: line length of 84 exceeds 80 columns #1768: FILE: kernel/bpf/fixups.c:996: +static struct bpf_insn_aux_data *bpf_dup_insn_aux_data(struct bpf_verifier_env *env) WARNING: line length of 87 exceeds 80 columns #1783: FILE: kernel/bpf/fixups.c:1011: + /* the expanded elements are zero-filled, so no special handling is required */ CHECK: multiple assignments should be avoided #1852: FILE: kernel/bpf/fixups.c:1295: + prog = orig_prog = env->prog; CHECK: multiple assignments should be avoided #1890: FILE: kernel/bpf/fixups.c:1333: + prog = env->prog = orig_prog; WARNING: line length of 96 exceeds 80 columns #1895: FILE: kernel/bpf/fixups.c:1338: + * We will fall back to interpreter mode when err is not -EFAULT, before WARNING: line length of 93 exceeds 80 columns #1896: FILE: kernel/bpf/fixups.c:1339: + * that, insn->off and insn->imm should be restored to their original WARNING: line length of 86 exceeds 80 columns #1899: FILE: kernel/bpf/fixups.c:1342: + for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) { total: 0 errors, 17 warnings, 11 checks, 1681 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d51d0fbd541b ("bpf: Move constants blinding out of arch-specific JITs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 17 warnings, 11 checks, 1681 lines checked