CHECK: Prefer kernel type 'u32' over 'uint32_t'
#106: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:111:
+				    uint32_t ioresource_types, int32_t *bars)

CHECK: Prefer kernel type 's32' over 'int32_t'
#108: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:113:
+	int32_t pos = 0;

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#109: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:114:
+	uint8_t type = 0;

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#110: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:115:
+	uint8_t bar = 0;

WARNING: line length of 100 exceeds 80 columns
#114: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:119:
+		pci_read_config_byte(pdev, pos + offsetof(struct zxdh_pf_pci_cap, cfg_type), &type);

WARNING: line length of 94 exceeds 80 columns
#115: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:120:
+		pci_read_config_byte(pdev, pos + offsetof(struct zxdh_pf_pci_cap, bar), &bar);

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#135: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:140:
+				     uint32_t start, uint32_t size,

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#140: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:145:
+	uint8_t bar = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#141: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:146:
+	uint32_t offset = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#142: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:147:
+	uint32_t length = 0;

WARNING: line length of 86 exceeds 80 columns
#145: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:150:
+	pci_read_config_byte(pdev, off + offsetof(struct zxdh_pf_pci_cap, bar), &bar);

WARNING: line length of 93 exceeds 80 columns
#146: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:151:
+	pci_read_config_dword(pdev, off + offsetof(struct zxdh_pf_pci_cap, offset), &offset);

WARNING: line length of 93 exceeds 80 columns
#147: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:152:
+	pci_read_config_dword(pdev, off + offsetof(struct zxdh_pf_pci_cap, length), &length);

WARNING: line length of 81 exceeds 80 columns
#153: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:158:
+		LOG_ERR("bad capability len %u (>%u expected)\n", length, start);

WARNING: line length of 84 exceeds 80 columns
#158: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:163:
+		LOG_ERR("bad capability len %u (>=%zu expected)\n", length, minlen);

WARNING: line length of 88 exceeds 80 columns
#180: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:185:
+	if (minlen + offset < minlen || minlen + offset > pci_resource_len(pdev, bar)) {

WARNING: line length of 86 exceeds 80 columns
#181: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:186:
+		LOG_ERR("map custom queue %zu@%u out of range on bar %i length %lu\n",

WARNING: line length of 89 exceeds 80 columns
#182: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:187:
+			minlen, offset, bar, (unsigned long)pci_resource_len(pdev, bar));

WARNING: braces {} are not necessary for any arm of this statement
#187: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:192:
+	if (unlikely(!p)) {
[...]
+	} else if (pa) {
[...]

WARNING: line length of 93 exceeds 80 columns
#188: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:193:
+		LOG_ERR("unable to map custom queue %u@%u on bar %i\n", length, offset, bar);

CHECK: Prefer kernel type 's32' over 'int32_t'
#198: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:203:
+	int32_t common = 0;

WARNING: line length of 88 exceeds 80 columns
#207: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:212:
+		LOG_ERR("missing capabilities %i, leaving for legacy driver\n", common);

WARNING: line length of 86 exceeds 80 columns
#212: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:217:
+						sizeof(struct zxdh_pf_pci_common_cfg),

WARNING: line length of 86 exceeds 80 columns
#214: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:219:
+						sizeof(struct zxdh_pf_pci_common_cfg),

CHECK: Prefer kernel type 's32' over 'int32_t'
#226: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:231:
+	int32_t notify = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#227: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:232:
+	uint32_t notify_length = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#228: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:233:
+	uint32_t notify_offset = 0;

WARNING: line length of 84 exceeds 80 columns
#241: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:246:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,

WARNING: line length of 91 exceeds 80 columns
#242: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:247:
+				notify_off_multiplier), &pf_dev->notify_offset_multiplier);

CHECK: Alignment should match open parenthesis
#242: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:247:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,
+				notify_off_multiplier), &pf_dev->notify_offset_multiplier);

WARNING: line length of 84 exceeds 80 columns
#243: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:248:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,

CHECK: Alignment should match open parenthesis
#244: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:249:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,
+				cap.length), &notify_length);

WARNING: line length of 84 exceeds 80 columns
#245: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:250:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,

CHECK: Alignment should match open parenthesis
#246: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:251:
+	pci_read_config_dword(pdev, notify + offsetof(struct zxdh_pf_pci_notify_cap,
+				cap.offset), &notify_offset);

WARNING: line length of 96 exceeds 80 columns
#249: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:254:
+	 * If notify length is small, map it all now. Otherwise, map each VQ individually later.

WARNING: line length of 81 exceeds 80 columns
#251: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:256:
+	if ((uint64_t)notify_length + (notify_offset % PAGE_SIZE) <= PAGE_SIZE) {

CHECK: Alignment should match open parenthesis
#253: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:258:
+		pf_dev->notify_base = zxdh_pf_map_capability(dh_dev, notify,
+							    ZXDH_PF_MAP_MINLEN2,

WARNING: line length of 86 exceeds 80 columns
#257: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:262:
+							    &pf_dev->notify_pa, NULL);

CHECK: Prefer kernel type 's32' over 'int32_t'
#271: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:276:
+	int32_t device = 0;

WARNING: line length of 102 exceeds 80 columns
#275: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:280:
+	/* Device capability is only mandatory for devices that have device-specific configuration. */

WARNING: line length of 111 exceeds 80 columns
#280: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:285:
+	/* we don't know how much we should map, but PAGE_SIZE is more than enough for all existing devices. */

WARNING: line length of 84 exceeds 80 columns
#283: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:288:
+						       ZXDH_PF_ALIGN4, 0, PAGE_SIZE,

CHECK: Alignment should match open parenthesis
#283: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:288:
+		pf_dev->device = zxdh_pf_map_capability(dh_dev, device, 0,
+						       ZXDH_PF_ALIGN4, 0, PAGE_SIZE,

WARNING: line length of 81 exceeds 80 columns
#284: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:289:
+						       &pf_dev->device_len, NULL,

WARNING: line length of 81 exceeds 80 columns
#285: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:290:
+						       &pf_dev->dev_cfg_bar_off);

CHECK: Prefer kernel type 's32' over 'int32_t'
#308: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:313:
+	int32_t ret = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#341: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:346:
+				      uint16_t phy_index, uint16_t index)

CHECK: Alignment should match open parenthesis
#354: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:359:
+void __iomem *zxdh_pf_map_vq_notify(struct dh_core_dev *dh_dev,
+				     uint16_t phy_index, uint16_t index,

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#354: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:359:
+				     uint16_t phy_index, uint16_t index,

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#358: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:363:
+	uint16_t off = 0;

WARNING: line length of 96 exceeds 80 columns
#364: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:369:
+		if ((uint64_t)off * pf_dev->notify_offset_multiplier + 2 > pf_dev->notify_len) {

WARNING: line length of 87 exceeds 80 columns
#365: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:370:
+			LOG_ERR("bad notification offset %u (x %u) for queue %u > %zd",

WARNING: line length of 81 exceeds 80 columns
#366: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:371:
+				off, pf_dev->notify_offset_multiplier, phy_index,

WARNING: line length of 89 exceeds 80 columns
#372: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:377:
+			*pa = pf_dev->notify_pa + off * pf_dev->notify_offset_multiplier;

WARNING: line length of 84 exceeds 80 columns
#374: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:379:
+		return pf_dev->notify_base + off * pf_dev->notify_offset_multiplier;

WARNING: line length of 83 exceeds 80 columns
#376: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:381:
+		return zxdh_pf_map_capability(dh_dev, pf_dev->notify_map_cap, 2, 2,

WARNING: line length of 85 exceeds 80 columns
#377: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:382:
+					      off * pf_dev->notify_offset_multiplier,

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#407: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:412:
+	uint8_t config_generation = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#417: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:422:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#418: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:423:
+	uint16_t DEV_MAC_H = 0;

WARNING: line length of 81 exceeds 80 columns
#422: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:427:
+		DEV_MAC_L = ioread32((void __iomem *)(pf_dev->pf_sriov_cap_base +

WARNING: line length of 81 exceeds 80 columns
#429: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:434:
+		DEV_MAC_H = ioread16((void __iomem *)(pf_dev->pf_sriov_cap_base +

WARNING: line length of 87 exceeds 80 columns
#438: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:443:
+void zxdh_pf_set_vf_mac_reg(struct zxdh_pf_device *pf_dev, uint8_t *mac, int32_t vf_id)

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#440: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:445:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#441: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:446:
+	uint16_t DEV_MAC_H = 0;

WARNING: line length of 85 exceeds 80 columns
#444: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:449:
+		DEV_MAC_L = mac[0] | (mac[1] << 8) | (mac[2] << 16) | (mac[3] << 24);

WARNING: line length of 81 exceeds 80 columns
#446: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:451:
+		iowrite32(DEV_MAC_L, (void __iomem *)(pf_dev->pf_sriov_cap_base +

WARNING: line length of 81 exceeds 80 columns
#449: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:454:
+		iowrite16(DEV_MAC_H, (void __iomem *)(pf_dev->pf_sriov_cap_base +

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#465: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:470:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#466: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:471:
+	uint16_t DEV_MAC_H = 0;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#478: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:483:
+	uint32_t DEV_MAC_L = 0;

CHECK: Prefer kernel type 'u16' over 'uint16_t'
#479: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:484:
+	uint16_t DEV_MAC_H = 0;

CHECK: Prefer kernel type 'u64' over 'uint64_t'
#496: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:501:
+	uint64_t device_feature = 0;

WARNING: line length of 86 exceeds 80 columns
#501: FILE: drivers/net/ethernet/zte/dinghai/en_pf.c:506:
+	device_feature |= ((uint64_t)ioread32(&pf_dev->common->device_feature) << 32);

CHECK: Prefer kernel type 's32' over 'int32_t'
#571: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:69:
+	int32_t notify_map_cap;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#572: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:70:
+	uint32_t notify_offset_multiplier;

CHECK: Prefer kernel type 's32' over 'int32_t'
#574: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:72:
+	int32_t modern_bars;

CHECK: Prefer kernel type 'u64' over 'uint64_t'
#576: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:74:
+	uint64_t pci_ioremap_addr[6];

CHECK: Prefer kernel type 'u64' over 'uint64_t'
#577: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:75:
+	uint64_t sriov_bar_size;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
#578: FILE: drivers/net/ethernet/zte/dinghai/en_pf.h:76:
+	uint32_t dev_cfg_bar_off;

total: 0 errors, 41 warnings, 39 checks, 546 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2acbd4051a52 ("net/ethernet/zte/dinghai: add hardware register access and PCI capability scanning") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 41 warnings, 39 checks, 546 lines checked