====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.V6gyMBDOzh 2026-04-12 07:55:30.655611399 -0400 +++ /tmp/tmp.L7iSOyRBsc 2026-04-12 07:55:31.901598600 -0400 @@ -232,14 +232,3 @@ -In bridge_vlan_mcast.sh line 167: - tc filter add dev $dev egress pref 10 prot 802.1Q \ - ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - tc filter add dev "$dev" egress pref 10 prot 802.1Q \ - - -In bridge_vlan_mcast.sh line 171: - tc filter add dev $dev egress pref 10 prot 802.1Q \ - ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - tc filter add dev "$dev" egress pref 10 prot 802.1Q \ +In bridge_vlan_mcast.sh line 174: + match=(match u8 0x11 0xff at 24 $match) + ^----^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. @@ -249,5 +238,3 @@ - tc filter del dev $dev egress pref 10 - ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - tc filter del dev "$dev" egress pref 10 + match=(match u8 0x82 0xff at 48 $match) + ^----^ SC2128 (warning): Expanding an array without an index only gives the first element. + ^----^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. @@ -256,10 +243 @@ -In bridge_vlan_mcast.sh line 196: - vlmc_query_cnt_setup $type $dev - ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - vlmc_query_cnt_setup "$type" "$dev" - - -In bridge_vlan_mcast.sh line 198: +In bridge_vlan_mcast.sh line 261: @@ -276 +254 @@ -In bridge_vlan_mcast.sh line 202: +In bridge_vlan_mcast.sh line 265: @@ -284,2 +262,2 @@ -In bridge_vlan_mcast.sh line 204: - local tcstats=$(tc_rule_stats_get $dev 10 egress) +In bridge_vlan_mcast.sh line 267: + local tcstats=$(tc_rule_stats_get "$dev" 20 egress) @@ -287,4 +264,0 @@ - ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - local tcstats=$(tc_rule_stats_get "$dev" 10 egress) @@ -293 +267 @@ -In bridge_vlan_mcast.sh line 205: +In bridge_vlan_mcast.sh line 268: @@ -304 +278 @@ -In bridge_vlan_mcast.sh line 207: +In bridge_vlan_mcast.sh line 270: @@ -309 +283 @@ -In bridge_vlan_mcast.sh line 208: +In bridge_vlan_mcast.sh line 271: @@ -316 +290 @@ -In bridge_vlan_mcast.sh line 209: +In bridge_vlan_mcast.sh line 272: @@ -322 +296 @@ -In bridge_vlan_mcast.sh line 215: +In bridge_vlan_mcast.sh line 278: @@ -330 +304 @@ -In bridge_vlan_mcast.sh line 217: +In bridge_vlan_mcast.sh line 280: @@ -338 +312 @@ -In bridge_vlan_mcast.sh line 223: +In bridge_vlan_mcast.sh line 286: @@ -347 +321 @@ -In bridge_vlan_mcast.sh line 224: +In bridge_vlan_mcast.sh line 287: @@ -355 +329 @@ -In bridge_vlan_mcast.sh line 228: +In bridge_vlan_mcast.sh line 291: @@ -363 +337 @@ -In bridge_vlan_mcast.sh line 240: +In bridge_vlan_mcast.sh line 303: @@ -371 +345 @@ -In bridge_vlan_mcast.sh line 245: +In bridge_vlan_mcast.sh line 308: @@ -379 +353 @@ -In bridge_vlan_mcast.sh line 253: +In bridge_vlan_mcast.sh line 316: @@ -388 +362 @@ -In bridge_vlan_mcast.sh line 254: +In bridge_vlan_mcast.sh line 317: @@ -396 +370 @@ -In bridge_vlan_mcast.sh line 258: +In bridge_vlan_mcast.sh line 321: @@ -404 +378 @@ -In bridge_vlan_mcast.sh line 264: +In bridge_vlan_mcast.sh line 327: @@ -412 +386 @@ -In bridge_vlan_mcast.sh line 275: +In bridge_vlan_mcast.sh line 338: @@ -420 +394 @@ -In bridge_vlan_mcast.sh line 285: +In bridge_vlan_mcast.sh line 348: @@ -428 +402 @@ -In bridge_vlan_mcast.sh line 296: +In bridge_vlan_mcast.sh line 359: @@ -437 +411 @@ -In bridge_vlan_mcast.sh line 297: +In bridge_vlan_mcast.sh line 360: @@ -445 +419 @@ -In bridge_vlan_mcast.sh line 301: +In bridge_vlan_mcast.sh line 364: @@ -453 +427 @@ -In bridge_vlan_mcast.sh line 308: +In bridge_vlan_mcast.sh line 371: @@ -461 +435 @@ -In bridge_vlan_mcast.sh line 330: +In bridge_vlan_mcast.sh line 393: @@ -470 +444 @@ -In bridge_vlan_mcast.sh line 331: +In bridge_vlan_mcast.sh line 394: @@ -478 +452 @@ -In bridge_vlan_mcast.sh line 335: +In bridge_vlan_mcast.sh line 398: @@ -486 +460 @@ -In bridge_vlan_mcast.sh line 342: +In bridge_vlan_mcast.sh line 405: @@ -494 +468 @@ -In bridge_vlan_mcast.sh line 351: +In bridge_vlan_mcast.sh line 414: @@ -502 +476 @@ -In bridge_vlan_mcast.sh line 358: +In bridge_vlan_mcast.sh line 421: @@ -510 +484 @@ -In bridge_vlan_mcast.sh line 369: +In bridge_vlan_mcast.sh line 432: @@ -519 +493 @@ -In bridge_vlan_mcast.sh line 370: +In bridge_vlan_mcast.sh line 433: @@ -527 +501 @@ -In bridge_vlan_mcast.sh line 374: +In bridge_vlan_mcast.sh line 437: @@ -535 +509 @@ -In bridge_vlan_mcast.sh line 395: +In bridge_vlan_mcast.sh line 458: @@ -544 +518 @@ -In bridge_vlan_mcast.sh line 396: +In bridge_vlan_mcast.sh line 459: @@ -552 +526 @@ -In bridge_vlan_mcast.sh line 400: +In bridge_vlan_mcast.sh line 463: @@ -560 +534 @@ -In bridge_vlan_mcast.sh line 415: +In bridge_vlan_mcast.sh line 478: @@ -568 +542 @@ -In bridge_vlan_mcast.sh line 417: +In bridge_vlan_mcast.sh line 480: @@ -576 +550 @@ -In bridge_vlan_mcast.sh line 418: +In bridge_vlan_mcast.sh line 481: @@ -584 +558 @@ -In bridge_vlan_mcast.sh line 422: +In bridge_vlan_mcast.sh line 485: @@ -592 +566 @@ -In bridge_vlan_mcast.sh line 423: +In bridge_vlan_mcast.sh line 486: @@ -600 +574 @@ -In bridge_vlan_mcast.sh line 433: +In bridge_vlan_mcast.sh line 496: @@ -609 +583 @@ -In bridge_vlan_mcast.sh line 434: +In bridge_vlan_mcast.sh line 497: @@ -617 +591 @@ -In bridge_vlan_mcast.sh line 438: +In bridge_vlan_mcast.sh line 501: @@ -625 +599 @@ -In bridge_vlan_mcast.sh line 449: +In bridge_vlan_mcast.sh line 513: @@ -633 +607,33 @@ -In bridge_vlan_mcast.sh line 460: +In bridge_vlan_mcast.sh line 525: + vlmc_check_query igmp 3 $swp1 1 1 qqic 60 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 qqic 60 + + +In bridge_vlan_mcast.sh line 531: + vlmc_check_query mld 2 $swp1 1 1 qqic 60 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 qqic 60 + + +In bridge_vlan_mcast.sh line 539: + vlmc_check_query igmp 3 $swp1 1 1 qqic 160 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 qqic 160 + + +In bridge_vlan_mcast.sh line 545: + vlmc_check_query mld 2 $swp1 1 1 qqic 160 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 qqic 160 + + +In bridge_vlan_mcast.sh line 558: @@ -642 +648 @@ -In bridge_vlan_mcast.sh line 461: +In bridge_vlan_mcast.sh line 559: @@ -650 +656 @@ -In bridge_vlan_mcast.sh line 465: +In bridge_vlan_mcast.sh line 563: @@ -658 +664,33 @@ -In bridge_vlan_mcast.sh line 482: +In bridge_vlan_mcast.sh line 577: + vlmc_check_query igmp 3 $swp1 1 1 mrc 60 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 mrc 60 + + +In bridge_vlan_mcast.sh line 585: + vlmc_check_query igmp 3 $swp1 1 1 mrc 160 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 mrc 160 + + +In bridge_vlan_mcast.sh line 595: + vlmc_check_query mld 2 $swp1 1 1 mrc 30000 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 mrc 30000 + + +In bridge_vlan_mcast.sh line 603: + vlmc_check_query mld 2 $swp1 1 1 mrc 60000 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 mrc 60000 + + +In bridge_vlan_mcast.sh line 616: @@ -667 +705 @@ -In bridge_vlan_mcast.sh line 483: +In bridge_vlan_mcast.sh line 617: @@ -675 +713 @@ -In bridge_vlan_mcast.sh line 488: +In bridge_vlan_mcast.sh line 622: @@ -683 +721 @@ -In bridge_vlan_mcast.sh line 496: +In bridge_vlan_mcast.sh line 630: @@ -691 +729 @@ -In bridge_vlan_mcast.sh line 501: +In bridge_vlan_mcast.sh line 635: @@ -699 +737 @@ -In bridge_vlan_mcast.sh line 503: +In bridge_vlan_mcast.sh line 637: @@ -707 +745 @@ -In bridge_vlan_mcast.sh line 505: +In bridge_vlan_mcast.sh line 639: @@ -715 +753 @@ -In bridge_vlan_mcast.sh line 514: +In bridge_vlan_mcast.sh line 648: @@ -724 +762 @@ -In bridge_vlan_mcast.sh line 518: +In bridge_vlan_mcast.sh line 652: @@ -733 +771 @@ -In bridge_vlan_mcast.sh line 519: +In bridge_vlan_mcast.sh line 653: @@ -741 +779 @@ -In bridge_vlan_mcast.sh line 522: +In bridge_vlan_mcast.sh line 656: @@ -749 +787 @@ -In bridge_vlan_mcast.sh line 523: +In bridge_vlan_mcast.sh line 657: @@ -757 +795 @@ -In bridge_vlan_mcast.sh line 526: +In bridge_vlan_mcast.sh line 660: @@ -765 +803 @@ -In bridge_vlan_mcast.sh line 527: +In bridge_vlan_mcast.sh line 661: @@ -773 +811 @@ -In bridge_vlan_mcast.sh line 547: +In bridge_vlan_mcast.sh line 681: @@ -783 +821 @@ - https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... + https://www.shellcheck.net/wiki/SC2128 -- Expanding an array without an ind...