CHECK: Comparison to NULL could be written "!ctx.offsets" #223: FILE: arch/arm/net/bpf_jit_32.c:2167: + if (ctx.offsets == NULL) CHECK: Comparison to NULL could be written "!ctx.imms" #246: FILE: arch/arm/net/bpf_jit_32.c:2197: + if (ctx.imms == NULL) CHECK: Comparison to NULL could be written "!header" #258: FILE: arch/arm/net/bpf_jit_32.c:2220: + if (header == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #349: FILE: arch/arm64/net/bpf_jit_comp.c:2065: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #517: FILE: arch/loongarch/net/bpf_jit.c:1964: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!addrs" #847: FILE: arch/powerpc/net/bpf_jit_comp.c:183: + if (addrs == NULL) CHECK: Comparison to NULL could be written "!jit.addrs" #1139: FILE: arch/s390/net/bpf_jit_comp.c:2343: + if (jit.addrs == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #1257: FILE: arch/sparc/net/bpf_jit_comp_64.c:1515: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!header" #1283: FILE: arch/sparc/net/bpf_jit_comp_64.c:1553: + if (header == NULL) WARNING: line length of 89 exceeds 80 columns #1545: FILE: include/linux/filter.h:1191: +static inline struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off, WARNING: line length of 89 exceeds 80 columns #1546: FILE: include/linux/filter.h:1192: + const struct bpf_insn *patch, u32 len) WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #1548: FILE: include/linux/filter.h:1194: + return ERR_PTR(-ENOTSUPP); WARNING: line length of 94 exceeds 80 columns #1560: FILE: include/linux/filter.h:1324: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog); WARNING: line length of 93 exceeds 80 columns #1581: FILE: include/linux/filter.h:1476: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog) WARNING: line length of 93 exceeds 80 columns #1586: FILE: include/linux/filter.h:1481: +static inline void bpf_jit_prog_release_other(struct bpf_prog *fp, struct bpf_prog *fp_other) WARNING: line length of 86 exceeds 80 columns #1601: FILE: kernel/bpf/core.c:1511: +/* Now this function is used only to blind the main prog and must be invoked only when WARNING: line length of 93 exceeds 80 columns #1604: FILE: kernel/bpf/core.c:1514: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog) WARNING: line length of 84 exceeds 80 columns #1637: FILE: kernel/bpf/core.c:1563: + tmp = bpf_patch_insn_single(clone, i, insn_buff, rewritten); WARNING: line length of 93 exceeds 80 columns #1660: FILE: kernel/bpf/core.c:1583: + /* Instructions arrays must be updated using absolute xlated offsets. WARNING: line length of 94 exceeds 80 columns #1661: FILE: kernel/bpf/core.c:1584: + * The arrays have already been adjusted by bpf_patch_insn_data() when WARNING: line length of 82 exceeds 80 columns #1744: FILE: kernel/bpf/verifier.c:23384: +static void restore_subprog_starts(struct bpf_verifier_env *env, u32 *orig_starts) WARNING: line length of 87 exceeds 80 columns #1765: FILE: kernel/bpf/verifier.c:23405: + /* the expanded elements are zero-filled, so no special handling is required */ CHECK: multiple assignments should be avoided #1834: FILE: kernel/bpf/verifier.c:23688: + prog = orig_prog = env->prog; CHECK: multiple assignments should be avoided #1872: FILE: kernel/bpf/verifier.c:23726: + prog = env->prog = orig_prog; WARNING: line length of 96 exceeds 80 columns #1876: FILE: kernel/bpf/verifier.c:23730: + /* We will fall back to interpreter mode when err is not -EFAULT, before WARNING: line length of 93 exceeds 80 columns #1877: FILE: kernel/bpf/verifier.c:23731: + * that, insn->off and insn->imm should be restored to their original WARNING: line length of 86 exceeds 80 columns #1880: FILE: kernel/bpf/verifier.c:23734: + for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) { total: 0 errors, 16 warnings, 11 checks, 1664 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit fb23a14ac643 ("bpf: Move constants blinding out of arch-specific JITs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 16 warnings, 11 checks, 1664 lines checked