ERROR: do not use assignment in if condition #63: FILE: tools/testing/selftests/bpf/test_loader.c:453: + if ((val = str_has_pfx(s, "test_description="))) { ERROR: do not use assignment in if condition #92: FILE: tools/testing/selftests/bpf/test_loader.c:475: + } else if ((msg = str_has_pfx(s, "test_expect_msg="))) { ERROR: do not use assignment in if condition #98: FILE: tools/testing/selftests/bpf/test_loader.c:480: + } else if ((msg = str_has_pfx(s, "test_expect_not_msg="))) { ERROR: do not use assignment in if condition #104: FILE: tools/testing/selftests/bpf/test_loader.c:485: + } else if ((msg = str_has_pfx(s, "test_expect_msg_unpriv="))) { WARNING: line length of 83 exceeds 80 columns #110: FILE: tools/testing/selftests/bpf/test_loader.c:490: + } else if ((msg = str_has_pfx(s, "test_expect_not_msg_unpriv="))) { ERROR: do not use assignment in if condition #110: FILE: tools/testing/selftests/bpf/test_loader.c:490: + } else if ((msg = str_has_pfx(s, "test_expect_not_msg_unpriv="))) { ERROR: do not use assignment in if condition #116: FILE: tools/testing/selftests/bpf/test_loader.c:495: + } else if ((msg = str_has_pfx(s, "test_jited="))) { ERROR: do not use assignment in if condition #125: FILE: tools/testing/selftests/bpf/test_loader.c:507: + } else if ((msg = str_has_pfx(s, "test_jited_unpriv="))) { ERROR: do not use assignment in if condition #134: FILE: tools/testing/selftests/bpf/test_loader.c:519: + } else if ((msg = str_has_pfx(s, "test_expect_xlated="))) { WARNING: line length of 82 exceeds 80 columns #141: FILE: tools/testing/selftests/bpf/test_loader.c:525: + } else if ((msg = str_has_pfx(s, "test_expect_xlated_unpriv="))) { ERROR: do not use assignment in if condition #141: FILE: tools/testing/selftests/bpf/test_loader.c:525: + } else if ((msg = str_has_pfx(s, "test_expect_xlated_unpriv="))) { ERROR: do not use assignment in if condition #148: FILE: tools/testing/selftests/bpf/test_loader.c:531: + } else if ((val = str_has_pfx(s, "test_retval="))) { ERROR: do not use assignment in if condition #155: FILE: tools/testing/selftests/bpf/test_loader.c:537: + } else if ((val = str_has_pfx(s, "test_retval_unpriv="))) { ERROR: do not use assignment in if condition #163: FILE: tools/testing/selftests/bpf/test_loader.c:544: + } else if ((val = str_has_pfx(s, "test_log_level="))) { ERROR: do not use assignment in if condition #168: FILE: tools/testing/selftests/bpf/test_loader.c:548: + } else if ((val = str_has_pfx(s, "test_prog_flags="))) { ERROR: do not use assignment in if condition #177: FILE: tools/testing/selftests/bpf/test_loader.c:573: + } else if ((val = str_has_pfx(s, "test_arch="))) { ERROR: do not use assignment in if condition #186: FILE: tools/testing/selftests/bpf/test_loader.c:591: + } else if ((val = str_has_pfx(s, "test_btf_path="))) { ERROR: do not use assignment in if condition #189: FILE: tools/testing/selftests/bpf/test_loader.c:593: + } else if ((val = str_has_pfx(s, "test_caps_unpriv="))) { ERROR: do not use assignment in if condition #195: FILE: tools/testing/selftests/bpf/test_loader.c:598: + } else if ((val = str_has_pfx(s, "load_mode="))) { ERROR: do not use assignment in if condition #204: FILE: tools/testing/selftests/bpf/test_loader.c:608: + } else if ((msg = str_has_pfx(s, "test_expect_stderr="))) { WARNING: line length of 82 exceeds 80 columns #210: FILE: tools/testing/selftests/bpf/test_loader.c:613: + } else if ((msg = str_has_pfx(s, "test_expect_stderr_unpriv="))) { ERROR: do not use assignment in if condition #210: FILE: tools/testing/selftests/bpf/test_loader.c:613: + } else if ((msg = str_has_pfx(s, "test_expect_stderr_unpriv="))) { ERROR: do not use assignment in if condition #216: FILE: tools/testing/selftests/bpf/test_loader.c:618: + } else if ((msg = str_has_pfx(s, "test_expect_stdout="))) { WARNING: line length of 82 exceeds 80 columns #222: FILE: tools/testing/selftests/bpf/test_loader.c:623: + } else if ((msg = str_has_pfx(s, "test_expect_stdout_unpriv="))) { ERROR: do not use assignment in if condition #222: FILE: tools/testing/selftests/bpf/test_loader.c:623: + } else if ((msg = str_has_pfx(s, "test_expect_stdout_unpriv="))) { ERROR: do not use assignment in if condition #228: FILE: tools/testing/selftests/bpf/test_loader.c:628: + } else if ((val = str_has_pfx(s, "test_linear_size="))) { total: 22 errors, 4 warnings, 0 checks, 202 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 12abbc44bda2 ("selftests/bpf: inline TEST_TAG constants in test_loader.c") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.