WARNING: line length of 99 exceeds 80 columns #57: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:133: +#define __test_tag(tag) __attribute__((btf_decl_tag("comment:" XSTR(__COUNTER__) ":" tag))) WARNING: line length of 82 exceeds 80 columns #92: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:160: +#define __caps_unpriv(caps) __test_tag("test_caps_unpriv=" EXPAND_QUOTE(caps)) WARNING: line length of 97 exceeds 80 columns #235: FILE: tools/testing/selftests/bpf/test_loader.c:385: + if (!btf_is_decl_tag(t) || t->type != id || btf_decl_tag(t)->component_idx != -1) ERROR: do not use assignment in if condition #296: FILE: tools/testing/selftests/bpf/test_loader.c:503: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_MSG_PFX))) { WARNING: line length of 81 exceeds 80 columns #302: FILE: tools/testing/selftests/bpf/test_loader.c:508: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_NOT_MSG_PFX))) { ERROR: do not use assignment in if condition #302: FILE: tools/testing/selftests/bpf/test_loader.c:508: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_NOT_MSG_PFX))) { WARNING: line length of 84 exceeds 80 columns #308: FILE: tools/testing/selftests/bpf/test_loader.c:513: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_MSG_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #308: FILE: tools/testing/selftests/bpf/test_loader.c:513: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_MSG_PFX_UNPRIV))) { WARNING: line length of 88 exceeds 80 columns #314: FILE: tools/testing/selftests/bpf/test_loader.c:518: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_NOT_MSG_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #314: FILE: tools/testing/selftests/bpf/test_loader.c:518: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_NOT_MSG_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #320: FILE: tools/testing/selftests/bpf/test_loader.c:523: + } else if ((msg = str_has_pfx(s, TEST_TAG_JITED_PFX))) { ERROR: do not use assignment in if condition #329: FILE: tools/testing/selftests/bpf/test_loader.c:535: + } else if ((msg = str_has_pfx(s, TEST_TAG_JITED_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #338: FILE: tools/testing/selftests/bpf/test_loader.c:547: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_XLATED_PFX))) { WARNING: line length of 87 exceeds 80 columns #345: FILE: tools/testing/selftests/bpf/test_loader.c:553: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_XLATED_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #345: FILE: tools/testing/selftests/bpf/test_loader.c:553: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_XLATED_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #354: FILE: tools/testing/selftests/bpf/test_loader.c:636: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_STDERR_PFX))) { WARNING: line length of 87 exceeds 80 columns #360: FILE: tools/testing/selftests/bpf/test_loader.c:641: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_STDERR_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #360: FILE: tools/testing/selftests/bpf/test_loader.c:641: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_STDERR_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #366: FILE: tools/testing/selftests/bpf/test_loader.c:646: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_STDOUT_PFX))) { WARNING: line length of 87 exceeds 80 columns #372: FILE: tools/testing/selftests/bpf/test_loader.c:651: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_STDOUT_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #372: FILE: tools/testing/selftests/bpf/test_loader.c:651: + } else if ((msg = str_has_pfx(s, TEST_TAG_EXPECT_STDOUT_PFX_UNPRIV))) { total: 12 errors, 9 warnings, 0 checks, 341 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 6f010197c258 ("selftests/bpf: impose global ordering for test decl_tags") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.