ERROR: do not use assignment in if condition #52: FILE: tools/testing/selftests/bpf/test_loader.c:180: + if (!in_regex && (next = str_has_pfx(pattern, "{{"))) { ERROR: do not use assignment in if condition #59: FILE: tools/testing/selftests/bpf/test_loader.c:185: + if (in_regex && (next = str_has_pfx(pattern, "}}"))) { ERROR: do not use assignment in if condition #72: FILE: tools/testing/selftests/bpf/test_loader.c:464: + if ((val = str_has_pfx(s, TEST_TAG_DESCRIPTION_PFX))) { ERROR: do not use assignment in if condition #83: FILE: tools/testing/selftests/bpf/test_loader.c:542: + } else if ((val = str_has_pfx(s, TEST_TAG_RETVAL_PFX))) { ERROR: do not use assignment in if condition #91: FILE: tools/testing/selftests/bpf/test_loader.c:548: + } else if ((val = str_has_pfx(s, TEST_TAG_RETVAL_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #100: FILE: tools/testing/selftests/bpf/test_loader.c:555: + } else if ((val = str_has_pfx(s, TEST_TAG_LOG_LEVEL_PFX))) { ERROR: do not use assignment in if condition #107: FILE: tools/testing/selftests/bpf/test_loader.c:559: + } else if ((val = str_has_pfx(s, TEST_TAG_PROG_FLAGS_PFX))) { ERROR: do not use assignment in if condition #117: FILE: tools/testing/selftests/bpf/test_loader.c:584: + } else if ((val = str_has_pfx(s, TEST_TAG_ARCH))) { ERROR: do not use assignment in if condition #129: FILE: tools/testing/selftests/bpf/test_loader.c:602: + } else if ((val = str_has_pfx(s, TEST_BTF_PATH))) { ERROR: do not use assignment in if condition #131: FILE: tools/testing/selftests/bpf/test_loader.c:604: + } else if ((val = str_has_pfx(s, TEST_TAG_CAPS_UNPRIV))) { ERROR: do not use assignment in if condition #138: FILE: tools/testing/selftests/bpf/test_loader.c:609: + } else if ((val = str_has_pfx(s, TEST_TAG_LOAD_MODE_PFX))) { ERROR: do not use assignment in if condition #147: FILE: tools/testing/selftests/bpf/test_loader.c:639: + } else if ((val = str_has_pfx(s, TEST_TAG_LINEAR_SIZE))) { total: 12 errors, 0 warnings, 0 checks, 125 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b811996e2658 ("selftests/bpf: make str_has_pfx return pointer past the prefix") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.