WARNING: line length of 88 exceeds 80 columns #65: FILE: tools/testing/selftests/bpf/libarena/selftests/selftest.c:108: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset)); WARNING: line length of 81 exceeds 80 columns #132: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:55: + * verification failures if verified with the rest of asan_test_buddy_uaf_single. CHECK: spaces preferred around that '*' (ctx:WxV) #134: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:57: +__weak int asan_test_buddy_byte(u8 __arena __arg_arena *mem, int i, bool freed) ^ CHECK: Alignment should match open parenthesis #140: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:63: + if (freed && BUDDY_HEADER_OFF <= i && + i < BUDDY_HEADER_OFF + sizeof(struct buddy_header)) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #189: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:112: + volatile u8 mem[48]; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #195: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:118: + volatile struct buddy_blob __arena *blob; WARNING: Prefer ARRAY_SIZE(sizes) #237: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:160: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #241: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:164: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); WARNING: Prefer ARRAY_SIZE(sizes) #268: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:191: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #272: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:195: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); CHECK: Alignment should match open parenthesis #303: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:226: + arena_stdout("%s:%d Failed on iteration %d", __func__, + __LINE__, i); WARNING: do not add new typedefs #343: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:17: +typedef struct segarr_entry __arena segarr_entry_t; WARNING: line length of 87 exceeds 80 columns #349: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:23: +size_t __arena alloc_multiple_sizes[] = { 3, 17, 1025, 129, 16350, 333, 9, 517, 2099 }; CHECK: Alignment should match open parenthesis #486: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:160: + arena_stdout("%s:%d %lx %u vs %u", __func__, + __LINE__, &mem[j], mem[j], poison); WARNING: line length of 81 exceeds 80 columns #512: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:186: + arena_stdout("alignment test: alloc failed for size %lu", CHECK: Alignment should match open parenthesis #513: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:187: + arena_stdout("alignment test: alloc failed for size %lu", + alignment_sizes[i]); CHECK: Lines should not end with a '(' #520: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:194: + arena_stdout( CHECK: Alignment should match open parenthesis #557: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:14: +static void run_libarena_test(struct libarena *skel, struct bpf_program *prog, + const char *name) WARNING: line length of 88 exceeds 80 columns #562: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:19: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset)); CHECK: Blank lines aren't necessary before a close brace '}' #570: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:27: + +} WARNING: line length of 82 exceeds 80 columns #586: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:43: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_alloc_reserve)); total: 0 errors, 11 warnings, 10 checks, 545 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit eda395e5cb02 ("selftests/bpf: Add selftests for libarena buddy allocator") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 11 warnings, 10 checks, 545 lines checked