WARNING: const array should probably be static const #40: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:24: +const char snprintf_u64_fmt[] = "%llu"; CHECK: Lines should not end with a '(' #53: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:171: + asm volatile ( CHECK: Lines should not end with a '(' #64: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:182: + asm volatile ( WARNING: quoted string split across lines #69: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:187: +"1:" + "r0 = r2;" WARNING: quoted string split across lines #71: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:189: +"2:" + "r0 = 0;" CHECK: Lines should not end with a '(' #107: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:388: + asm volatile ( CHECK: Lines should not end with a '(' #123: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:404: + asm volatile ( CHECK: Lines should not end with a '(' #155: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:436: + asm volatile ( CHECK: Lines should not end with a '(' #171: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:452: + asm volatile ( CHECK: Lines should not end with a '(' #180: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:461: + asm volatile ( CHECK: Lines should not end with a '(' #221: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:502: + asm volatile ( WARNING: quoted string split across lines #226: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:507: +"1:" + "*(u64 *)(r10 - 8) = r0;" CHECK: Lines should not end with a '(' #240: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:521: + asm volatile ( CHECK: Lines should not end with a '(' #257: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:538: + asm volatile ( CHECK: Lines should not end with a '(' #295: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:576: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #299: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:580: + /* fall-through (path A) explored first */ CHECK: Lines should not end with a '(' #362: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:643: + asm volatile ( CHECK: Lines should not end with a '(' #385: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:666: + asm volatile ( WARNING: quoted string split across lines #393: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:674: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #429: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:710: + asm volatile ( WARNING: line length of 83 exceeds 80 columns #432: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:713: + "*(u64 *)(r10 - 16) = r1;" /* fp-16 = ctx (STACK_SPILL ptr) */ CHECK: Lines should not end with a '(' #458: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:739: + asm volatile ( WARNING: quoted string split across lines #466: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:747: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #478: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:759: + asm volatile ( CHECK: Lines should not end with a '(' #533: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:814: + asm volatile ( WARNING: quoted string split across lines #542: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:823: +"1:" + "r1 = r10;" WARNING: quoted string split across lines #548: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:829: +"2:" + "r1 = r10;" CHECK: Lines should not end with a '(' #586: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:867: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #596: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:877: + /* Branch: fall-through (path A) verified first */ WARNING: quoted string split across lines #627: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:908: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #654: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:935: + asm volatile ( CHECK: Lines should not end with a '(' #684: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:965: + asm volatile ( CHECK: Lines should not end with a '(' #708: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:989: + asm volatile ( CHECK: Lines should not end with a '(' #736: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1017: + asm volatile ( CHECK: Lines should not end with a '(' #762: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1043: + asm volatile ( CHECK: Lines should not end with a '(' #786: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1067: + asm volatile ( CHECK: Lines should not end with a '(' #812: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1093: + asm volatile ( CHECK: Lines should not end with a '(' #847: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1128: + asm volatile ( WARNING: quoted string split across lines #853: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1134: +"1:" + "*(u32 *)(r10 - 4) = 0;" WARNING: quoted string split across lines #855: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1136: +"2:" + "r0 = *(u32 *)(r10 - 4);" CHECK: Lines should not end with a '(' #884: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1165: + asm volatile ( WARNING: quoted string split across lines #891: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1172: +"l_nonconst%=:" + "*(u8 *)(r10 - 4) = r0;" /* slot 0: STACK_MISC */ WARNING: quoted string split across lines #893: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1174: +"l_lookup%=:" + "r2 = r10;" WARNING: Prefer 'fallthrough;' over fallthrough comment #911: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1192: + * Path A (fall-through): spill r6 to fp-8 across helper call CHECK: Lines should not end with a '(' #926: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1207: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #948: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1229: + * on a register that already has non-zero spis falls through to CHECK: Lines should not end with a '(' #973: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1254: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #977: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1258: + /* Path A (fall-through, explored first): fp-8 = 0 */ CHECK: Lines should not end with a '(' #1029: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1310: + asm volatile ( WARNING: quoted string split across lines #1038: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1319: +"l_pathB%=:" + "r1 = 42;" WARNING: quoted string split across lines #1042: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1323: +"l_merge%=:" + "r6 = r10;" WARNING: quoted string split across lines #1057: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1338: +"l_danger%=:" + "r1 = 0;" CHECK: Lines should not end with a '(' #1085: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1366: + asm volatile ( CHECK: Lines should not end with a '(' #1099: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1380: + asm volatile ( WARNING: quoted string split across lines #1105: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1386: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1117: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1398: + asm volatile ( CHECK: Lines should not end with a '(' #1146: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1427: + asm volatile ( CHECK: Lines should not end with a '(' #1162: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1443: + asm volatile ( CHECK: Lines should not end with a '(' #1171: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1452: + asm volatile ( CHECK: Lines should not end with a '(' #1189: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1470: + asm volatile ( CHECK: Lines should not end with a '(' #1201: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1482: + asm volatile ( CHECK: Lines should not end with a '(' #1228: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1509: + asm volatile ( CHECK: Lines should not end with a '(' #1247: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1528: + asm volatile ( CHECK: Lines should not end with a '(' #1266: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1547: + asm volatile ( WARNING: quoted string split across lines #1272: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1553: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1284: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1565: + asm volatile ( CHECK: Lines should not end with a '(' #1305: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1586: + asm volatile ( CHECK: Lines should not end with a '(' #1324: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1605: + asm volatile ( CHECK: Lines should not end with a '(' #1342: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1623: + asm volatile ( WARNING: quoted string split across lines #1348: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1629: + "1:" + "r0 = *(u64 *)(r6 - 8);" CHECK: Lines should not end with a '(' #1366: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1647: + asm volatile ( CHECK: Lines should not end with a '(' #1390: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1671: + asm volatile ( CHECK: Lines should not end with a '(' #1424: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1705: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1433: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1714: + /* Branch: path A (fall-through) explored first */ WARNING: quoted string split across lines #1451: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1732: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1463: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1744: + asm volatile ( CHECK: Lines should not end with a '(' #1473: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1754: + asm volatile ( WARNING: line length of 85 exceeds 80 columns #1488: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1769: +__msg("14: (79) r1 = *(u64 *)(r10 -8) // r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") WARNING: line length of 94 exceeds 80 columns #1489: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1770: +__msg("15: (79) r0 = *(u64 *)(r1 +0) // r1=fp1-16 r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") CHECK: Lines should not end with a '(' #1495: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1776: + asm volatile ( CHECK: Lines should not end with a '(' #1506: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1787: + asm volatile ( CHECK: Lines should not end with a '(' #1525: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1806: + asm volatile ( WARNING: line length of 85 exceeds 80 columns #1534: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1815: +__msg("13: (79) r1 = *(u64 *)(r10 -8) // r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") WARNING: line length of 94 exceeds 80 columns #1535: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1816: +__msg("14: (79) r0 = *(u64 *)(r1 +0) // r1=fp1-16 r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") CHECK: Lines should not end with a '(' #1541: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1822: + asm volatile ( CHECK: Lines should not end with a '(' #1552: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1833: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1581: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1862: + * if r0 != 0 goto clobber path A (fall-through) first CHECK: Lines should not end with a '(' #1616: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1897: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1620: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1901: + /* fall-through (path A) explored first */ WARNING: quoted string split across lines #1628: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1909: +"l_merge%=:" + "r1 = r10;" CHECK: Lines should not end with a '(' #1650: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1931: + asm volatile ( WARNING: line length of 81 exceeds 80 columns #1652: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1933: + "r2 = r1;" /* R2 = parent ptr (AT_PARENT) */ WARNING: line length of 84 exceeds 80 columns #1654: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1935: + "call %[bpf_map_lookup_elem];" /* reads 4 bytes from parent fp-4 */ CHECK: Lines should not end with a '(' #1680: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1961: + asm volatile ( CHECK: Lines should not end with a '(' #1693: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1974: + asm volatile ( CHECK: Lines should not end with a '(' #1749: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2030: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1758: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2039: + /* Branch: path A (fall-through) explored first */ WARNING: quoted string split across lines #1781: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2062: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1799: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2080: + asm volatile ( WARNING: line length of 84 exceeds 80 columns #1801: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2082: + "r0 = *(u64 *)(r2 + 0);" /* read main's fp-16: triggers anc_use[0] */ CHECK: Lines should not end with a '(' #1812: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2093: + asm volatile ( CHECK: Lines should not end with a '(' #1821: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2102: + asm volatile ( WARNING: line length of 88 exceeds 80 columns #1823: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2104: + "r0 = *(u64 *)(r0 + 0);" /* deref: safe for map_ptr, unsafe for scalar */ CHECK: Lines should not end with a '(' #1860: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2141: + asm volatile ( WARNING: quoted string split across lines #1881: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2162: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1892: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2173: + asm volatile ( CHECK: Lines should not end with a '(' #1906: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2187: + asm volatile ( CHECK: Lines should not end with a '(' #1935: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2216: + asm volatile ( CHECK: Lines should not end with a '(' #1952: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2233: + asm volatile ( CHECK: Lines should not end with a '(' #1961: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2242: + asm volatile ( CHECK: Lines should not end with a '(' #1970: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2251: + asm volatile ( CHECK: Lines should not end with a '(' #1979: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2260: + asm volatile ( CHECK: Lines should not end with a '(' #1993: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2274: + asm volatile ( CHECK: Lines should not end with a '(' #2010: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2291: + asm volatile ( CHECK: Lines should not end with a '(' #2019: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2300: + asm volatile ( CHECK: Lines should not end with a '(' #2028: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2309: + asm volatile ( WARNING: quoted string split across lines #2035: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2316: + "1:" + "r2 = dyn_cb_b ll;" WARNING: quoted string split across lines #2037: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2318: + "2:" + "r1 = 1;" CHECK: Lines should not end with a '(' #2051: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2332: + asm volatile ( CHECK: Lines should not end with a '(' #2060: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2341: + asm volatile ( CHECK: Lines should not end with a '(' #2077: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2358: + asm volatile ( CHECK: Lines should not end with a '(' #2113: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2394: + asm volatile ( CHECK: Lines should not end with a '(' #2136: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2417: + asm volatile ( CHECK: Lines should not end with a '(' #2144: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2425: + asm volatile ( CHECK: Lines should not end with a '(' #2159: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2440: + asm volatile ( WARNING: line length of 89 exceeds 80 columns #2163: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2444: + ".8byte %[load_acquire_insn];" /* load_acquire is a special case for BPF_STX, */ WARNING: line length of 82 exceeds 80 columns #2164: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2445: + "r0 = *(u64 *)(r10 - 16);" /* it shouldn't clear tracking info for */ WARNING: line length of 82 exceeds 80 columns #2170: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2451: + BPF_ATOMIC_OP(BPF_DW, BPF_LOAD_ACQ, BPF_REG_0, BPF_REG_0, 0)) total: 0 errors, 46 warnings, 82 checks, 2150 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 12ee248ffa24 ("selftests/bpf: add new tests for static stack liveness analysis") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 46 warnings, 82 checks, 2150 lines checked