ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.wohpTFGJo6 and /tmp/tmp.5aq2fa31Wf
Tree base:
eb216e422044 ("MAINTAINERS: Remove Salil Mehta as HiSilicon HNS3/HNS Ethernet maintainer")
Now at:
6b173eca8141 ("selftests: netfilter: nft_tproxy.sh: adjust to socat changes")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh - 17495dea354ca3db030aaed60d81057668bde883af92ffaf0accb02d63fbdabc


In nft_tproxy_udp.sh line 34:
	ip netns pids "$ns1" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_tproxy_udp.sh line 35:
	ip netns pids "$ns2" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_tproxy_udp.sh line 36:
	ip netns pids "$ns3" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns3 is referenced but not assigned.


In nft_tproxy_udp.sh line 37:
	ip netns pids "$nsrouter" | xargs kill 2>/dev/null
                       ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In nft_tproxy_udp.sh line 181:
	ip netns exec "$nsrouter" $ip_command rule add fwmark 1 table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" rule add fwmark 1 table 100


In nft_tproxy_udp.sh line 182:
	ip netns exec "$nsrouter" $ip_command route add local "$ns2_ip" dev lo table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" route add local "$ns2_ip" dev lo table 100


In nft_tproxy_udp.sh line 246:
	ip netns exec "$nsrouter" $ip_command rule del fwmark 1 table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" rule del fwmark 1 table 100


In nft_tproxy_udp.sh line 247:
	ip netns exec "$nsrouter" $ip_command route flush table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" route flush table 100

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh - 17495dea354ca3db030aaed60d81057668bde883af92ffaf0accb02d63fbdabc


In nft_tproxy_udp.sh line 34:
	ip netns pids "$ns1" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_tproxy_udp.sh line 35:
	ip netns pids "$ns2" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_tproxy_udp.sh line 36:
	ip netns pids "$ns3" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns3 is referenced but not assigned.


In nft_tproxy_udp.sh line 37:
	ip netns pids "$nsrouter" | xargs kill 2>/dev/null
                       ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In nft_tproxy_udp.sh line 181:
	ip netns exec "$nsrouter" $ip_command rule add fwmark 1 table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" rule add fwmark 1 table 100


In nft_tproxy_udp.sh line 182:
	ip netns exec "$nsrouter" $ip_command route add local "$ns2_ip" dev lo table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" route add local "$ns2_ip" dev lo table 100


In nft_tproxy_udp.sh line 246:
	ip netns exec "$nsrouter" $ip_command rule del fwmark 1 table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" rule del fwmark 1 table 100


In nft_tproxy_udp.sh line 247:
	ip netns exec "$nsrouter" $ip_command route flush table 100
                                  ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$nsrouter" "$ip_command" route flush table 100

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...