WARNING: const array should probably be static const #32: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:23: +const char snprintf_u64_fmt[] = "%llu"; CHECK: Lines should not end with a '(' #45: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:170: + asm volatile ( CHECK: Lines should not end with a '(' #56: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:181: + asm volatile ( WARNING: quoted string split across lines #61: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:186: +"1:" + "r0 = r2;" WARNING: quoted string split across lines #63: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:188: +"2:" + "r0 = 0;" CHECK: Lines should not end with a '(' #99: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:387: + asm volatile ( CHECK: Lines should not end with a '(' #115: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:403: + asm volatile ( CHECK: Lines should not end with a '(' #147: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:435: + asm volatile ( CHECK: Lines should not end with a '(' #163: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:451: + asm volatile ( CHECK: Lines should not end with a '(' #172: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:460: + asm volatile ( CHECK: Lines should not end with a '(' #213: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:501: + asm volatile ( WARNING: quoted string split across lines #218: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:506: +"1:" + "*(u64 *)(r10 - 8) = r0;" CHECK: Lines should not end with a '(' #232: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:520: + asm volatile ( CHECK: Lines should not end with a '(' #249: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:537: + asm volatile ( CHECK: Lines should not end with a '(' #287: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:575: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #291: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:579: + /* fall-through (path A) explored first */ CHECK: Lines should not end with a '(' #354: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:642: + asm volatile ( CHECK: Lines should not end with a '(' #377: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:665: + asm volatile ( WARNING: quoted string split across lines #385: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:673: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #421: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:709: + asm volatile ( WARNING: line length of 83 exceeds 80 columns #424: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:712: + "*(u64 *)(r10 - 16) = r1;" /* fp-16 = ctx (STACK_SPILL ptr) */ CHECK: Lines should not end with a '(' #450: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:738: + asm volatile ( WARNING: quoted string split across lines #458: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:746: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #470: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:758: + asm volatile ( CHECK: Lines should not end with a '(' #525: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:813: + asm volatile ( WARNING: quoted string split across lines #534: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:822: +"1:" + "r1 = r10;" WARNING: quoted string split across lines #540: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:828: +"2:" + "r1 = r10;" CHECK: Lines should not end with a '(' #578: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:866: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #588: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:876: + /* Branch: fall-through (path A) verified first */ WARNING: quoted string split across lines #619: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:907: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #646: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:934: + asm volatile ( CHECK: Lines should not end with a '(' #676: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:964: + asm volatile ( CHECK: Lines should not end with a '(' #700: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:988: + asm volatile ( CHECK: Lines should not end with a '(' #728: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1016: + asm volatile ( CHECK: Lines should not end with a '(' #754: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1042: + asm volatile ( CHECK: Lines should not end with a '(' #778: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1066: + asm volatile ( CHECK: Lines should not end with a '(' #804: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1092: + asm volatile ( CHECK: Lines should not end with a '(' #839: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1127: + asm volatile ( WARNING: quoted string split across lines #845: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1133: +"1:" + "*(u32 *)(r10 - 4) = 0;" WARNING: quoted string split across lines #847: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1135: +"2:" + "r0 = *(u32 *)(r10 - 4);" CHECK: Lines should not end with a '(' #876: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1164: + asm volatile ( WARNING: quoted string split across lines #883: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1171: +"l_nonconst%=:" + "*(u8 *)(r10 - 4) = r0;" /* slot 0: STACK_MISC */ WARNING: quoted string split across lines #885: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1173: +"l_lookup%=:" + "r2 = r10;" WARNING: Prefer 'fallthrough;' over fallthrough comment #903: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1191: + * Path A (fall-through): spill r6 to fp-8 across helper call CHECK: Lines should not end with a '(' #918: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1206: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #940: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1228: + * on a register that already has non-zero spis falls through to CHECK: Lines should not end with a '(' #965: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1253: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #969: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1257: + /* Path A (fall-through, explored first): fp-8 = 0 */ CHECK: Lines should not end with a '(' #1021: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1309: + asm volatile ( WARNING: quoted string split across lines #1030: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1318: +"l_pathB%=:" + "r1 = 42;" WARNING: quoted string split across lines #1034: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1322: +"l_merge%=:" + "r6 = r10;" WARNING: quoted string split across lines #1049: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1337: +"l_danger%=:" + "r1 = 0;" CHECK: Lines should not end with a '(' #1077: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1365: + asm volatile ( CHECK: Lines should not end with a '(' #1091: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1379: + asm volatile ( WARNING: quoted string split across lines #1097: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1385: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1109: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1397: + asm volatile ( CHECK: Lines should not end with a '(' #1138: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1426: + asm volatile ( CHECK: Lines should not end with a '(' #1154: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1442: + asm volatile ( CHECK: Lines should not end with a '(' #1163: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1451: + asm volatile ( CHECK: Lines should not end with a '(' #1181: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1469: + asm volatile ( CHECK: Lines should not end with a '(' #1193: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1481: + asm volatile ( CHECK: Lines should not end with a '(' #1220: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1508: + asm volatile ( CHECK: Lines should not end with a '(' #1239: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1527: + asm volatile ( CHECK: Lines should not end with a '(' #1258: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1546: + asm volatile ( WARNING: quoted string split across lines #1264: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1552: + "1:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1276: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1564: + asm volatile ( CHECK: Lines should not end with a '(' #1297: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1585: + asm volatile ( CHECK: Lines should not end with a '(' #1316: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1604: + asm volatile ( CHECK: Lines should not end with a '(' #1334: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1622: + asm volatile ( WARNING: quoted string split across lines #1340: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1628: + "1:" + "r0 = *(u64 *)(r6 - 8);" CHECK: Lines should not end with a '(' #1358: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1646: + asm volatile ( CHECK: Lines should not end with a '(' #1382: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1670: + asm volatile ( CHECK: Lines should not end with a '(' #1416: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1704: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1425: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1713: + /* Branch: path A (fall-through) explored first */ WARNING: quoted string split across lines #1443: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1731: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1455: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1743: + asm volatile ( CHECK: Lines should not end with a '(' #1465: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1753: + asm volatile ( WARNING: line length of 85 exceeds 80 columns #1480: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1768: +__msg("14: (79) r1 = *(u64 *)(r10 -8) // r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") WARNING: line length of 94 exceeds 80 columns #1481: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1769: +__msg("15: (79) r0 = *(u64 *)(r1 +0) // r1=fp1-16 r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") CHECK: Lines should not end with a '(' #1487: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1775: + asm volatile ( CHECK: Lines should not end with a '(' #1498: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1786: + asm volatile ( CHECK: Lines should not end with a '(' #1517: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1805: + asm volatile ( WARNING: line length of 85 exceeds 80 columns #1526: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1814: +__msg("13: (79) r1 = *(u64 *)(r10 -8) // r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") WARNING: line length of 94 exceeds 80 columns #1527: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1815: +__msg("14: (79) r0 = *(u64 *)(r1 +0) // r1=fp1-16 r6=fp0-8 r7=fp1-16 fp-8=fp1-16 fp-16=fp0-8") CHECK: Lines should not end with a '(' #1533: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1821: + asm volatile ( CHECK: Lines should not end with a '(' #1544: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1832: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1573: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1861: + * if r0 != 0 goto clobber path A (fall-through) first CHECK: Lines should not end with a '(' #1608: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1896: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1612: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1900: + /* fall-through (path A) explored first */ WARNING: quoted string split across lines #1620: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1908: +"l_merge%=:" + "r1 = r10;" CHECK: Lines should not end with a '(' #1642: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1930: + asm volatile ( WARNING: line length of 81 exceeds 80 columns #1644: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1932: + "r2 = r1;" /* R2 = parent ptr (AT_PARENT) */ WARNING: line length of 84 exceeds 80 columns #1646: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1934: + "call %[bpf_map_lookup_elem];" /* reads 4 bytes from parent fp-4 */ CHECK: Lines should not end with a '(' #1672: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1960: + asm volatile ( CHECK: Lines should not end with a '(' #1685: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:1973: + asm volatile ( CHECK: Lines should not end with a '(' #1741: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2029: + asm volatile ( WARNING: Prefer 'fallthrough;' over fallthrough comment #1750: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2038: + /* Branch: path A (fall-through) explored first */ WARNING: quoted string split across lines #1773: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2061: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1791: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2079: + asm volatile ( WARNING: line length of 84 exceeds 80 columns #1793: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2081: + "r0 = *(u64 *)(r2 + 0);" /* read main's fp-16: triggers anc_use[0] */ CHECK: Lines should not end with a '(' #1804: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2092: + asm volatile ( CHECK: Lines should not end with a '(' #1813: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2101: + asm volatile ( WARNING: line length of 88 exceeds 80 columns #1815: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2103: + "r0 = *(u64 *)(r0 + 0);" /* deref: safe for map_ptr, unsafe for scalar */ CHECK: Lines should not end with a '(' #1852: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2140: + asm volatile ( WARNING: quoted string split across lines #1873: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2161: +"l_exit%=:" + "r0 = 0;" CHECK: Lines should not end with a '(' #1884: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2172: + asm volatile ( CHECK: Lines should not end with a '(' #1898: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2186: + asm volatile ( CHECK: Lines should not end with a '(' #1927: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2215: + asm volatile ( CHECK: Lines should not end with a '(' #1944: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2232: + asm volatile ( CHECK: Lines should not end with a '(' #1953: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2241: + asm volatile ( CHECK: Lines should not end with a '(' #1962: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2250: + asm volatile ( CHECK: Lines should not end with a '(' #1971: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2259: + asm volatile ( CHECK: Lines should not end with a '(' #1985: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2273: + asm volatile ( CHECK: Lines should not end with a '(' #2002: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2290: + asm volatile ( CHECK: Lines should not end with a '(' #2011: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2299: + asm volatile ( CHECK: Lines should not end with a '(' #2020: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2308: + asm volatile ( WARNING: quoted string split across lines #2027: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2315: + "1:" + "r2 = dyn_cb_b ll;" WARNING: quoted string split across lines #2029: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2317: + "2:" + "r1 = 1;" CHECK: Lines should not end with a '(' #2043: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2331: + asm volatile ( CHECK: Lines should not end with a '(' #2052: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2340: + asm volatile ( CHECK: Lines should not end with a '(' #2069: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2357: + asm volatile ( CHECK: Lines should not end with a '(' #2105: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2393: + asm volatile ( CHECK: Lines should not end with a '(' #2128: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2416: + asm volatile ( CHECK: Lines should not end with a '(' #2136: FILE: tools/testing/selftests/bpf/progs/verifier_live_stack.c:2424: + asm volatile ( total: 0 errors, 43 warnings, 81 checks, 2118 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 637cf15a7ab2 ("selftests/bpf: add new tests for static stack liveness analysis") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 43 warnings, 81 checks, 2118 lines checked