========== shellcheck - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/ecmp_rehash.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.S9ZiQ1VQgF 2026-04-08 03:32:14.004470223 -0400 +++ /tmp/tmp.NsDuNK2fPK 2026-04-08 03:32:14.404466343 -0400 @@ -0,0 +1,128 @@ + +In ecmp_rehash.sh line 54: + ip netns exec "$ns" awk ' + ^-- SC2016 (info): Expressions don't expand in single quotes, use double quotes for that. + + +In ecmp_rehash.sh line 176: + wait_local_port_listen "$NS2" $PORT tcp + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait_local_port_listen "$NS2" "$PORT" tcp + + +In ecmp_rehash.sh line 190: + defer kill_process $client_pid + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + defer kill_process "$client_pid" + + +In ecmp_rehash.sh line 197: + if [ $RET -ne 0 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$RET" -ne 0 ]; then + + +In ecmp_rehash.sh line 207: + wait $client_pid || rc=$? + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$client_pid" || rc=$? + + +In ecmp_rehash.sh line 245: + wait_local_port_listen "$NS2" $port tcp + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait_local_port_listen "$NS2" "$port" tcp + + +In ecmp_rehash.sh line 253: + defer kill_process $client_pid + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + defer kill_process "$client_pid" + + +In ecmp_rehash.sh line 259: + if [ $RET -ne 0 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$RET" -ne 0 ]; then + + +In ecmp_rehash.sh line 269: + wait $client_pid || rc=$? + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$client_pid" || rc=$? + + +In ecmp_rehash.sh line 294: + wait_local_port_listen "$NS2" $port tcp + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait_local_port_listen "$NS2" "$port" tcp + + +In ecmp_rehash.sh line 307: + defer kill_process $client_pid + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + defer kill_process "$client_pid" + + +In ecmp_rehash.sh line 309: + busywait $BUSYWAIT_TIMEOUT until_counter_is \ + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + busywait "$BUSYWAIT_TIMEOUT" until_counter_is \ + + +In ecmp_rehash.sh line 313: + if [ $RET -ne 0 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$RET" -ne 0 ]; then + + +In ecmp_rehash.sh line 335: + wait $client_pid || rc=$? + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$client_pid" || rc=$? + + +In ecmp_rehash.sh line 337: + check_err $rc "data transfer failed after blocking veth${active_idx}a" + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_err "$rc" "data transfer failed after blocking veth${active_idx}a" + + +In ecmp_rehash.sh line 361: +exit $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +exit "$EXIT_STATUS" + +For more information: + https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...