========== shellcheck - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/ecmp_rehash.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.WI3Sd8qU3g 2026-04-07 21:02:32.764384429 -0400 +++ /tmp/tmp.Ekx4KcsstR 2026-04-07 21:02:33.168381776 -0400 @@ -0,0 +1,144 @@ + +In ecmp_rehash.sh line 54: + ip netns exec "$ns" awk ' + ^-- SC2016 (info): Expressions don't expand in single quotes, use double quotes for that. + + +In ecmp_rehash.sh line 170: + wait_local_port_listen "$NS2" $PORT tcp + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait_local_port_listen "$NS2" "$PORT" tcp + + +In ecmp_rehash.sh line 182: + defer kill_process $client_pid + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + defer kill_process "$client_pid" + + +In ecmp_rehash.sh line 189: + if [ $RET -ne 0 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$RET" -ne 0 ]; then + + +In ecmp_rehash.sh line 199: + wait $client_pid || rc=$? + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$client_pid" || rc=$? + + +In ecmp_rehash.sh line 205: + if [ $rc -ne 0 ] || [[ "$result" != *"ESTABLISH_OK"* ]]; then + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$rc" -ne 0 ] || [[ "$result" != *"ESTABLISH_OK"* ]]; then + + +In ecmp_rehash.sh line 237: + wait_local_port_listen "$NS2" $port tcp + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait_local_port_listen "$NS2" "$port" tcp + + +In ecmp_rehash.sh line 246: + defer kill_process $client_pid + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + defer kill_process "$client_pid" + + +In ecmp_rehash.sh line 252: + if [ $RET -ne 0 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$RET" -ne 0 ]; then + + +In ecmp_rehash.sh line 262: + wait $client_pid || rc=$? + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$client_pid" || rc=$? + + +In ecmp_rehash.sh line 268: + if [ $rc -ne 0 ] || [[ "$result" != *"SYNACK_OK"* ]]; then + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$rc" -ne 0 ] || [[ "$result" != *"SYNACK_OK"* ]]; then + + +In ecmp_rehash.sh line 287: + wait_local_port_listen "$NS2" $port tcp + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait_local_port_listen "$NS2" "$port" tcp + + +In ecmp_rehash.sh line 300: + defer kill_process $client_pid + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + defer kill_process "$client_pid" + + +In ecmp_rehash.sh line 302: + busywait $BUSYWAIT_TIMEOUT until_counter_is \ + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + busywait "$BUSYWAIT_TIMEOUT" until_counter_is \ + + +In ecmp_rehash.sh line 306: + if [ $RET -ne 0 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$RET" -ne 0 ]; then + + +In ecmp_rehash.sh line 328: + wait $client_pid || rc=$? + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$client_pid" || rc=$? + + +In ecmp_rehash.sh line 330: + check_err $rc "data transfer failed after blocking veth${active_idx}a" + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_err "$rc" "data transfer failed after blocking veth${active_idx}a" + + +In ecmp_rehash.sh line 354: +exit $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +exit "$EXIT_STATUS" + +For more information: + https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...