ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.PX3j9nwmEK and /tmp/tmp.MwYjl4ZAnE
Tree base:
affca79399ea ("selftests: net: add team_bridge_macvlan rx_mode test")
Now at:
7358c12c8060 ("selftests: net: use ip commands instead of teamd in team rx_mode test")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/bonding/lag_lib.sh - c54b9d16a782dd603b64aa66bb498441c6b1ce972804201a9d5cb9791afe42a5


In lag_lib.sh line 95:
		ip netns add ${n}
                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip netns add "${n}"


In lag_lib.sh line 100:
	ip link set dev lag1 netns lag_node1 $state name eth0
                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1 netns lag_node1 "$state" name eth0


In lag_lib.sh line 101:
	ip link set dev lag1-end netns lag_node2 $state name eth0
                                                 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1-end netns lag_node2 "$state" name eth0


In lag_lib.sh line 104:
	ip link set dev lag1 netns lag_node1 $state name eth1
                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1 netns lag_node1 "$state" name eth1


In lag_lib.sh line 105:
	ip link set dev lag1-end netns lag_node2 $state name eth1
                                                 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1-end netns lag_node2 "$state" name eth1


In lag_lib.sh line 114:
		ip netns delete ${n} >/dev/null 2>&1 || true
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip netns delete "${n}" >/dev/null 2>&1 || true


In lag_lib.sh line 147:
	ip netns exec ${CLIENT} ip link add bond0 type bond $@
                                                            ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In lag_lib.sh line 156:
	RET=0
        ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).


In lag_lib.sh line 158:
	create_bond $@
                    ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC2034 -- RET appears unused. Verify use (o...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Checking tools/testing/selftests/drivers/net/team/dev_addr_lists.sh - 4c803f1dcb7088f2100de7b8aaa39c5d97e305311bf4957cbe4013657de7c80d


In dev_addr_lists.sh line 7:
ALL_TESTS="
^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally).


In dev_addr_lists.sh line 39:
	RET=0
        ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/bonding/lag_lib.sh - c54b9d16a782dd603b64aa66bb498441c6b1ce972804201a9d5cb9791afe42a5


In lag_lib.sh line 84:
		ip netns add ${n}
                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip netns add "${n}"


In lag_lib.sh line 89:
	ip link set dev lag1 netns lag_node1 $state name eth0
                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1 netns lag_node1 "$state" name eth0


In lag_lib.sh line 90:
	ip link set dev lag1-end netns lag_node2 $state name eth0
                                                 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1-end netns lag_node2 "$state" name eth0


In lag_lib.sh line 93:
	ip link set dev lag1 netns lag_node1 $state name eth1
                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1 netns lag_node1 "$state" name eth1


In lag_lib.sh line 94:
	ip link set dev lag1-end netns lag_node2 $state name eth1
                                                 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev lag1-end netns lag_node2 "$state" name eth1


In lag_lib.sh line 103:
		ip netns delete ${n} >/dev/null 2>&1 || true
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip netns delete "${n}" >/dev/null 2>&1 || true


In lag_lib.sh line 136:
	ip netns exec ${CLIENT} ip link add bond0 type bond $@
                                                            ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In lag_lib.sh line 145:
	RET=0
        ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).


In lag_lib.sh line 147:
	create_bond $@
                    ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC2034 -- RET appears unused. Verify use (o...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Checking tools/testing/selftests/drivers/net/team/dev_addr_lists.sh - 4c803f1dcb7088f2100de7b8aaa39c5d97e305311bf4957cbe4013657de7c80d


In dev_addr_lists.sh line 7:
ALL_TESTS="
^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally).


In dev_addr_lists.sh line 39:
	RET=0
        ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ...