CHECK: Please don't use multiple blank lines #75: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:11: + + WARNING: line length of 81 exceeds 80 columns #114: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:50: + * verification failures if verified with the rest of asan_test_buddy_uaf_single. CHECK: spaces preferred around that '*' (ctx:WxV) #116: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:52: +__weak int asan_test_buddy_byte(u8 __arena __arg_arena *mem, int i, bool freed) ^ CHECK: Alignment should match open parenthesis #120: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:56: + if (freed && BUDDY_HEADER_OFF <= i && + i < BUDDY_HEADER_OFF + sizeof(struct buddy_header)) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #163: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:99: + volatile u8 mem[48]; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #169: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:105: + volatile struct buddy_blob __arena *blob; CHECK: Alignment should match open parenthesis #198: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:134: + ret = buddy_init(&st_buddy_asan, + (arena_spinlock_t __arena *)&st_asan_buddy_lock); WARNING: Prefer ARRAY_SIZE(sizes) #204: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:140: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #208: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:144: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); CHECK: Alignment should match open parenthesis #227: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:163: + ret = buddy_init(&st_buddy_asan, + (arena_spinlock_t __arena *)&st_asan_buddy_lock); WARNING: Prefer ARRAY_SIZE(sizes) #233: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:169: + for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) { CHECK: Alignment should match open parenthesis #237: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:173: + arena_stdout("%s:%d Failed for size %lu", __func__, + __LINE__, sizes[i]); CHECK: Alignment should match open parenthesis #256: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:192: + ret = buddy_init(&st_buddy_asan, + (arena_spinlock_t __arena *)&st_asan_buddy_lock); CHECK: Alignment should match open parenthesis #266: FILE: tools/testing/selftests/bpf/libarena/selftests/st_asan_buddy.bpf.c:202: + arena_stdout("%s:%d Failed on iteration %d", __func__, + __LINE__, i); CHECK: Please don't use multiple blank lines #332: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:11: + + WARNING: do not add new typedefs #342: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:21: +typedef struct segarr_entry __arena segarr_entry_t; WARNING: line length of 87 exceeds 80 columns #348: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:27: +size_t __arena alloc_multiple_sizes[] = { 3, 17, 1025, 129, 16350, 333, 9, 517, 2099 }; CHECK: Lines should not end with a '(' #359: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:38: + ret = buddy_init( CHECK: Lines should not end with a '(' #378: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:57: + ret = buddy_init( CHECK: Alignment should match open parenthesis #402: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:81: + ret = buddy_init(&st_buddy, + (arena_spinlock_t __arena *)&st_buddy_lock); CHECK: Alignment should match open parenthesis #430: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:109: + ret = buddy_init(&st_buddy, + (arena_spinlock_t __arena *)&st_buddy_lock); CHECK: Alignment should match open parenthesis #485: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:164: + arena_stdout("%s:%d %lx %u vs %u", __func__, + __LINE__, &mem[j], mem[j], poison); CHECK: Alignment should match open parenthesis #503: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:182: + ret = buddy_init(&st_buddy, + (arena_spinlock_t __arena *)&st_buddy_lock); WARNING: line length of 81 exceeds 80 columns #511: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:190: + arena_stdout("alignment test: alloc failed for size %lu", CHECK: Alignment should match open parenthesis #512: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:191: + arena_stdout("alignment test: alloc failed for size %lu", + alignment_sizes[i]); CHECK: Lines should not end with a '(' #519: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:198: + arena_stdout( WARNING: braces {} are not necessary for single statement blocks #528: FILE: tools/testing/selftests/bpf/libarena/selftests/st_buddy.bpf.c:207: + for (i = zero; i < 17 && can_loop; i++) { + buddy_free(&st_buddy, ptrs[i]); + } WARNING: line length of 82 exceeds 80 columns #586: FILE: tools/testing/selftests/bpf/prog_tests/libarena.c:29: + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_alloc_reserve)); total: 0 errors, 10 warnings, 18 checks, 548 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7ac9f8129bee ("selftests/bpf: Add selftests for libarena buddy allocator") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 10 warnings, 18 checks, 548 lines checked