ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.tkcMWTOVhI and /tmp/tmp.A9Z21MfhwQ
Tree base:
ebf533c47ca3 ("selftests: net: Add tests for failover of team-aggregated ports")
Now at:
580adf049ef5 ("selftests: net: Add test for enablement of ports with teamd")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/team/team_lib.sh - 8a0fe0b10b91397530dc5d2a7e95d8bf69d04ea1dd7f79e4d351b100964be985


Checking tools/testing/selftests/net/lib.sh - c03467c29b10bc5091e0c288a3bb791664845bf18d1bc2e796311e58cd726204


In lib.sh line 78:
	local start_time="$(date -u +%s%3N)"
              ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 87:
		local current_time="$(date -u +%s%3N)"
                      ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 115:
	local current=$("$@")
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 118:
	((current $expr))
        ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors.
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	((current "$expr"))


In lib.sh line 126:
	local base=$("$@")
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 135:
	local base=$("$@")
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 145:
	if ! which $prog_name >/dev/null 2>/dev/null; then
                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! which "$prog_name" >/dev/null 2>/dev/null; then


In lib.sh line 147:
		if ! which $prog_name >/dev/null; then
                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		if ! which "$prog_name" >/dev/null; then


In lib.sh line 235:
    echo "$id 1" | ip netns exec $ns tee /sys/bus/netdevsim/new_device >/dev/null
                                 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    echo "$id 1" | ip netns exec "$ns" tee /sys/bus/netdevsim/new_device >/dev/null


In lib.sh line 236:
    local dev=$(ip netns exec $ns ls /sys/bus/netdevsim/devices/netdevsim$id/net)
          ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    local dev=$(ip netns exec "$ns" ls /sys/bus/netdevsim/devices/netdevsim"$id"/net)


In lib.sh line 237:
    ip -netns $ns link set dev $dev name nsim$id
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip -netns "$ns" link set dev "$dev" name nsim"$id"


In lib.sh line 238:
    ip -netns $ns link set dev nsim$id up
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip -netns "$ns" link set dev nsim"$id" up


In lib.sh line 240:
    echo nsim$id
             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    echo nsim"$id"


In lib.sh line 282:
	tc -j -s filter show dev $dev $dir pref $pref \
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -j -s filter show dev "$dev" "$dir" pref "$pref" \


In lib.sh line 294:
	tc $netns -j -s filter show $id \
           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc "$netns" -j -s filter show "$id" \


In lib.sh line 306:
	tc -n $ns qdisc add dev $dev root handle 1: prio bands 2 \
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" qdisc add dev "$dev" root handle 1: prio bands 2 \


In lib.sh line 309:
	tc -n $ns qdisc add dev $dev parent 1:1 handle 11: pfifo
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" qdisc add dev "$dev" parent 1:1 handle 11: pfifo


In lib.sh line 310:
	tc -n $ns qdisc add dev $dev parent 1:2 handle 12: pfifo
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" qdisc add dev "$dev" parent 1:2 handle 12: pfifo


In lib.sh line 312:
	tc -n $ns filter add dev $dev parent 1: protocol ipv$ipver \
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                            ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" filter add dev "$dev" parent 1: protocol ipv"$ipver" \


In lib.sh line 313:
			flower $flower_expr classid 1:2
                               ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			flower "$flower_expr" classid 1:2


In lib.sh line 320:
	tc -n $ns -j -s qdisc show dev $dev handle 12: | jq .[0].packets
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" -j -s qdisc show dev "$dev" handle 12: | jq .[0].packets


In lib.sh line 328:
	RET=$(ksft_status_merge $RET $ksft_status)
                                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	RET=$(ksft_status_merge $RET "$ksft_status")


In lib.sh line 329:
	if (( $? )); then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 351:
		read a
                ^--^ SC2162 (info): read without -r will mangle backslashes.


In lib.sh line 409:
	EXIT_STATUS=$(ksft_exit_status_merge $EXIT_STATUS $RET)
                                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	EXIT_STATUS=$(ksft_exit_status_merge $EXIT_STATUS "$RET")


In lib.sh line 410:
	return $RET
               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$RET"


In lib.sh line 415:
	RET=$ksft_skip retmsg= log_test "$@"
                              ^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).


In lib.sh line 420:
	RET=$ksft_xfail retmsg= log_test "$@"
                               ^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).


In lib.sh line 436:
			$current_test
                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			"$current_test"


In lib.sh line 472:
		check_fail $err "$what succeeded, but should have failed"
                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_fail "$err" "$what succeeded, but should have failed"


In lib.sh line 474:
		check_err $err "$what failed"
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_err "$err" "$what failed"


In lib.sh line 504:
	kind=$(ip -j -d link show dev $dev |
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	kind=$(ip -j -d link show dev "$dev" |


In lib.sh line 526:
	{ kill $pid && wait $pid; } 2>/dev/null
               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	{ kill "$pid" && wait "$pid"; } 2>/dev/null


In lib.sh line 535:
		return $EXIT_STATUS
                       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		return "$EXIT_STATUS"


In lib.sh line 544:
		exit $EXIT_STATUS
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		exit "$EXIT_STATUS"


In lib.sh line 570:
	local old_addr=$(mac_get "$name")
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 580:
	local state=$(ip -j link show "$name" |
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 641:
	[ ${protocol} = "tcp" ] && pattern="${pattern}0A"
          ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	[ "${protocol}" = "tcp" ] && pattern="${pattern}0A"


In lib.sh line 643:
		if ip netns exec "${listener_ns}" awk '{print $2" "$4}' \
                                                      ^---------------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.


In lib.sh line 665:
	output=$(echo $output | jq -r $jq_opts "$jq_exp")
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	output=$(echo "$output" | jq -r "$jq_opts" "$jq_exp")


In lib.sh line 670:
	echo $output
             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	echo "$output"

For more information:
  https://www.shellcheck.net/wiki/SC1105 -- Shells disambiguate (( differentl...
  https://www.shellcheck.net/wiki/SC1007 -- Remove space after = if trying to...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/team/team_lib.sh - 8a0fe0b10b91397530dc5d2a7e95d8bf69d04ea1dd7f79e4d351b100964be985


Checking tools/testing/selftests/drivers/net/team/teamd_activebackup.sh - 53d457443829a34d121f29525e762a9a13a99e834810347862e2719ecc123151


Checking tools/testing/selftests/net/lib.sh - c03467c29b10bc5091e0c288a3bb791664845bf18d1bc2e796311e58cd726204


In lib.sh line 78:
	local start_time="$(date -u +%s%3N)"
              ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 87:
		local current_time="$(date -u +%s%3N)"
                      ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 115:
	local current=$("$@")
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 118:
	((current $expr))
        ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors.
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	((current "$expr"))


In lib.sh line 126:
	local base=$("$@")
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 135:
	local base=$("$@")
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 145:
	if ! which $prog_name >/dev/null 2>/dev/null; then
                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! which "$prog_name" >/dev/null 2>/dev/null; then


In lib.sh line 147:
		if ! which $prog_name >/dev/null; then
                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		if ! which "$prog_name" >/dev/null; then


In lib.sh line 248:
    echo "$id 1" | ip netns exec $ns tee /sys/bus/netdevsim/new_device >/dev/null
                                 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    echo "$id 1" | ip netns exec "$ns" tee /sys/bus/netdevsim/new_device >/dev/null


In lib.sh line 249:
    local dev=$(ip netns exec $ns ls /sys/bus/netdevsim/devices/netdevsim$id/net)
          ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    local dev=$(ip netns exec "$ns" ls /sys/bus/netdevsim/devices/netdevsim"$id"/net)


In lib.sh line 250:
    ip -netns $ns link set dev $dev name nsim$id
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip -netns "$ns" link set dev "$dev" name nsim"$id"


In lib.sh line 251:
    ip -netns $ns link set dev nsim$id up
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip -netns "$ns" link set dev nsim"$id" up


In lib.sh line 253:
    echo nsim$id
             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    echo nsim"$id"


In lib.sh line 295:
	tc -j -s filter show dev $dev $dir pref $pref \
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -j -s filter show dev "$dev" "$dir" pref "$pref" \


In lib.sh line 307:
	tc $netns -j -s filter show $id \
           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc "$netns" -j -s filter show "$id" \


In lib.sh line 319:
	tc -n $ns qdisc add dev $dev root handle 1: prio bands 2 \
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" qdisc add dev "$dev" root handle 1: prio bands 2 \


In lib.sh line 322:
	tc -n $ns qdisc add dev $dev parent 1:1 handle 11: pfifo
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" qdisc add dev "$dev" parent 1:1 handle 11: pfifo


In lib.sh line 323:
	tc -n $ns qdisc add dev $dev parent 1:2 handle 12: pfifo
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" qdisc add dev "$dev" parent 1:2 handle 12: pfifo


In lib.sh line 325:
	tc -n $ns filter add dev $dev parent 1: protocol ipv$ipver \
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                            ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" filter add dev "$dev" parent 1: protocol ipv"$ipver" \


In lib.sh line 326:
			flower $flower_expr classid 1:2
                               ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			flower "$flower_expr" classid 1:2


In lib.sh line 333:
	tc -n $ns -j -s qdisc show dev $dev handle 12: | jq .[0].packets
              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc -n "$ns" -j -s qdisc show dev "$dev" handle 12: | jq .[0].packets


In lib.sh line 341:
	RET=$(ksft_status_merge $RET $ksft_status)
                                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	RET=$(ksft_status_merge $RET "$ksft_status")


In lib.sh line 342:
	if (( $? )); then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 364:
		read a
                ^--^ SC2162 (info): read without -r will mangle backslashes.


In lib.sh line 422:
	EXIT_STATUS=$(ksft_exit_status_merge $EXIT_STATUS $RET)
                                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	EXIT_STATUS=$(ksft_exit_status_merge $EXIT_STATUS "$RET")


In lib.sh line 423:
	return $RET
               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$RET"


In lib.sh line 428:
	RET=$ksft_skip retmsg= log_test "$@"
                              ^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).


In lib.sh line 433:
	RET=$ksft_xfail retmsg= log_test "$@"
                               ^-- SC1007 (warning): Remove space after = if trying to assign a value (for empty string, use var='' ... ).


In lib.sh line 449:
			$current_test
                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			"$current_test"


In lib.sh line 485:
		check_fail $err "$what succeeded, but should have failed"
                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_fail "$err" "$what succeeded, but should have failed"


In lib.sh line 487:
		check_err $err "$what failed"
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_err "$err" "$what failed"


In lib.sh line 517:
	kind=$(ip -j -d link show dev $dev |
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	kind=$(ip -j -d link show dev "$dev" |


In lib.sh line 539:
	{ kill $pid && wait $pid; } 2>/dev/null
               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	{ kill "$pid" && wait "$pid"; } 2>/dev/null


In lib.sh line 548:
		return $EXIT_STATUS
                       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		return "$EXIT_STATUS"


In lib.sh line 557:
		exit $EXIT_STATUS
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		exit "$EXIT_STATUS"


In lib.sh line 583:
	local old_addr=$(mac_get "$name")
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 593:
	local state=$(ip -j link show "$name" |
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 654:
	[ ${protocol} = "tcp" ] && pattern="${pattern}0A"
          ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	[ "${protocol}" = "tcp" ] && pattern="${pattern}0A"


In lib.sh line 656:
		if ip netns exec "${listener_ns}" awk '{print $2" "$4}' \
                                                      ^---------------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.


In lib.sh line 678:
	output=$(echo $output | jq -r $jq_opts "$jq_exp")
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	output=$(echo "$output" | jq -r "$jq_opts" "$jq_exp")


In lib.sh line 683:
	echo $output
             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	echo "$output"

For more information:
  https://www.shellcheck.net/wiki/SC1105 -- Shells disambiguate (( differentl...
  https://www.shellcheck.net/wiki/SC1007 -- Remove space after = if trying to...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

tools/testing/selftests/drivers/net/team/teamd_activebackup.sh is shellcheck compliant
tools/testing/selftests/drivers/net/team/team_lib.sh is shellcheck compliant