ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.vpMq3thEyj and /tmp/tmp.v0WslV46rZ
Tree base:
d60702966174 ("net/sched: act_nat: fix inner IP header checksum in ICMP error packets")
Now at:
78abe7d81763 ("selftests: net: add act_nat ICMP inner checksum test")
 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/act_nat_icmp_csum.sh - 0ccf271963f90622d31aafc155ebca862460e6fc0de97af6037de2c86dee62b8


In act_nat_icmp_csum.sh line 33:
	cleanup_ns $NS1 $NS2
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	cleanup_ns "$NS1" "$NS2"


In act_nat_icmp_csum.sh line 45:
ip -netns $NS1 link add veth0 type veth peer name veth0 netns $NS2
          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip -netns "$NS1" link add veth0 type veth peer name veth0 netns "$NS2"


In act_nat_icmp_csum.sh line 46:
ip -netns $NS1 link set dev veth0 up
          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip -netns "$NS1" link set dev veth0 up


In act_nat_icmp_csum.sh line 47:
ip -netns $NS2 link set dev veth0 up
          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip -netns "$NS2" link set dev veth0 up


In act_nat_icmp_csum.sh line 49:
ip -netns $NS1 addr add 10.0.1.1/24 dev veth0
          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip -netns "$NS1" addr add 10.0.1.1/24 dev veth0


In act_nat_icmp_csum.sh line 50:
ip -netns $NS2 addr add 10.0.2.1/24 dev veth0
          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip -netns "$NS2" addr add 10.0.2.1/24 dev veth0


In act_nat_icmp_csum.sh line 52:
ip netns exec $NS2 sysctl -qw net.ipv4.ip_forward=1
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns exec "$NS2" sysctl -qw net.ipv4.ip_forward=1


In act_nat_icmp_csum.sh line 53:
ip netns exec $NS2 sysctl -qw net.ipv4.icmp_ratelimit=0
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns exec "$NS2" sysctl -qw net.ipv4.icmp_ratelimit=0


In act_nat_icmp_csum.sh line 55:
ip -netns $NS1 route add 10.0.2.0/24 dev veth0
          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip -netns "$NS1" route add 10.0.2.0/24 dev veth0


In act_nat_icmp_csum.sh line 58:
ip netns exec $NS1 tc qdisc add dev veth0 clsact
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns exec "$NS1" tc qdisc add dev veth0 clsact


In act_nat_icmp_csum.sh line 61:
ip netns exec $NS1 tc filter add dev veth0 egress protocol ip prio 1 \
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns exec "$NS1" tc filter add dev veth0 egress protocol ip prio 1 \


In act_nat_icmp_csum.sh line 66:
ip netns exec $NS1 tc filter add dev veth0 ingress protocol ip prio 1 \
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns exec "$NS1" tc filter add dev veth0 ingress protocol ip prio 1 \


In act_nat_icmp_csum.sh line 71:
ip netns exec $NS1 python3 "$(dirname "$0")/act_nat_icmp_csum_verify.py"
              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns exec "$NS1" python3 "$(dirname "$0")/act_nat_icmp_csum_verify.py"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...