WARNING: line length of 81 exceeds 80 columns #38: FILE: include/asm-generic/btf_ids.lds.h:19: +#define BTF_IDS_VERIFIER_SUBSEGS \ ERROR: Macros with complex values should be enclosed in parentheses #38: FILE: include/asm-generic/btf_ids.lds.h:19: +#define BTF_IDS_VERIFIER_SUBSEGS \ + BTF_IDS_SUBSEG(bpf_verif_kfunc_rbtree_add) \ + BTF_IDS_SUBSEG(bpf_verif_kfunc_rbtree_graph_node) \ + BTF_IDS_SUBSEG(bpf_verif_kfunc_rbtree_api) BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 81 exceeds 80 columns #39: FILE: include/asm-generic/btf_ids.lds.h:20: + BTF_IDS_SUBSEG(bpf_verif_kfunc_rbtree_add) \ WARNING: line length of 81 exceeds 80 columns #40: FILE: include/asm-generic/btf_ids.lds.h:21: + BTF_IDS_SUBSEG(bpf_verif_kfunc_rbtree_graph_node) \ CHECK: Please use a blank line after function/struct/union/enum declarations #53: FILE: kernel/bpf/helpers.c:2609: } +BPF_VERIF_KFUNC_DEF(bpf_rbtree_remove, rbtree_api, rbtree_graph_node) CHECK: Please use a blank line after function/struct/union/enum declarations #61: FILE: kernel/bpf/helpers.c:2671: } +BPF_VERIF_KFUNC_DEF(bpf_rbtree_add, rbtree_api, rbtree_add, rbtree_graph_node) WARNING: line length of 83 exceeds 80 columns #69: FILE: kernel/bpf/helpers.c:2679: +BPF_VERIF_KFUNC_DEF(bpf_rbtree_add_impl, rbtree_api, rbtree_add, rbtree_graph_node) CHECK: Please use a blank line after function/struct/union/enum declarations #69: FILE: kernel/bpf/helpers.c:2679: } +BPF_VERIF_KFUNC_DEF(bpf_rbtree_add_impl, rbtree_api, rbtree_add, rbtree_graph_node) CHECK: Please use a blank line after function/struct/union/enum declarations #77: FILE: kernel/bpf/helpers.c:2687: } +BPF_VERIF_KFUNC_DEF(bpf_rbtree_first, rbtree_api) CHECK: Please use a blank line after function/struct/union/enum declarations #85: FILE: kernel/bpf/helpers.c:2695: } +BPF_VERIF_KFUNC_DEF(bpf_rbtree_root, rbtree_api) CHECK: Please use a blank line after function/struct/union/enum declarations #93: FILE: kernel/bpf/helpers.c:2706: } +BPF_VERIF_KFUNC_DEF(bpf_rbtree_left, rbtree_api, rbtree_graph_node) CHECK: Please use a blank line after function/struct/union/enum declarations #101: FILE: kernel/bpf/helpers.c:2717: } +BPF_VERIF_KFUNC_DEF(bpf_rbtree_right, rbtree_api, rbtree_graph_node) WARNING: line length of 85 exceeds 80 columns #182: FILE: kernel/bpf/verifier.c:13336: + ret = btf_id_set_contains(&bpf_verif_kfunc_rbtree_api, kfunc_btf_id); WARNING: line length of 92 exceeds 80 columns #194: FILE: kernel/bpf/verifier.c:13361: + ret = btf_id_set_contains(&bpf_verif_kfunc_rbtree_graph_node, kfunc_btf_id); WARNING: line length of 94 exceeds 80 columns #203: FILE: kernel/bpf/verifier.c:13898: + if (btf_id_set_contains(&bpf_verif_kfunc_rbtree_add, meta->func_id)) { WARNING: line length of 85 exceeds 80 columns #231: FILE: kernel/bpf/verifier.c:23728: + btf_id_set_contains(&bpf_verif_kfunc_rbtree_add, desc->func_id)) { WARNING: line length of 86 exceeds 80 columns #238: FILE: kernel/bpf/verifier.c:23734: + if (btf_id_set_contains(&bpf_verif_kfunc_rbtree_add, desc->func_id)) { total: 1 errors, 9 warnings, 7 checks, 181 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 6fe278856d29 ("bpf: classify rbtree kfuncs with BPF_VERIF_KFUNC_DEF sets") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.