WARNING: line length of 81 exceeds 80 columns #43: FILE: include/asm-generic/btf_ids.lds.h:15: +#define BTF_IDS_SUBSEG(sfx) \ WARNING: Non-declarative macros with multiple statements should be enclosed in a do - while loop #43: FILE: include/asm-generic/btf_ids.lds.h:15: +#define BTF_IDS_SUBSEG(sfx) \ + KEEP(*(.BTF_ids.##sfx)) \ + __BTF_ids_seg_end_##sfx = .; BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: macros should not use a trailing semicolon #43: FILE: include/asm-generic/btf_ids.lds.h:15: +#define BTF_IDS_SUBSEG(sfx) \ + KEEP(*(.BTF_ids.##sfx)) \ + __BTF_ids_seg_end_##sfx = .; WARNING: line length of 81 exceeds 80 columns #44: FILE: include/asm-generic/btf_ids.lds.h:16: + KEEP(*(.BTF_ids.##sfx)) \ WARNING: line length of 82 exceeds 80 columns #141: FILE: tools/bpf/resolve_btfids/main.c:357: + pr_err("FAILED scatter set symbol name overflow: %s\n", id->name); WARNING: line length of 84 exceeds 80 columns #153: FILE: tools/bpf/resolve_btfids/main.c:369: + id->name, (unsigned long)begin, sym_end, (unsigned long)end); WARNING: line length of 82 exceeds 80 columns #189: FILE: tools/bpf/resolve_btfids/main.c:631: + if (id && scatter_set_cnt_from_seg(obj, id, sym.st_value)) total: 0 errors, 7 warnings, 0 checks, 168 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 835e0c7639ed ("bpf: Teach resolve_btfids about the setsc type") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 7 warnings, 0 checks, 168 lines checked