====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.IbtzIBW5K2 2026-04-03 11:51:32.676707601 -0400 +++ /tmp/tmp.jSRnEi6ij5 2026-04-03 11:51:33.927698063 -0400 @@ -2 +2 @@ -In bridge_vlan_mcast.sh line 16: +In bridge_vlan_mcast.sh line 17: @@ -10 +10 @@ -In bridge_vlan_mcast.sh line 17: +In bridge_vlan_mcast.sh line 18: @@ -19 +19 @@ -In bridge_vlan_mcast.sh line 22: +In bridge_vlan_mcast.sh line 23: @@ -27 +27 @@ -In bridge_vlan_mcast.sh line 23: +In bridge_vlan_mcast.sh line 24: @@ -35 +35 @@ -In bridge_vlan_mcast.sh line 28: +In bridge_vlan_mcast.sh line 29: @@ -43 +43 @@ -In bridge_vlan_mcast.sh line 29: +In bridge_vlan_mcast.sh line 30: @@ -52 +52 @@ -In bridge_vlan_mcast.sh line 34: +In bridge_vlan_mcast.sh line 35: @@ -60 +60 @@ -In bridge_vlan_mcast.sh line 35: +In bridge_vlan_mcast.sh line 36: @@ -68 +68 @@ -In bridge_vlan_mcast.sh line 42: +In bridge_vlan_mcast.sh line 43: @@ -76 +76 @@ -In bridge_vlan_mcast.sh line 43: +In bridge_vlan_mcast.sh line 44: @@ -84 +84 @@ -In bridge_vlan_mcast.sh line 46: +In bridge_vlan_mcast.sh line 47: @@ -92 +92 @@ -In bridge_vlan_mcast.sh line 47: +In bridge_vlan_mcast.sh line 48: @@ -100 +100 @@ -In bridge_vlan_mcast.sh line 49: +In bridge_vlan_mcast.sh line 50: @@ -108 +108 @@ -In bridge_vlan_mcast.sh line 50: +In bridge_vlan_mcast.sh line 51: @@ -116 +116 @@ -In bridge_vlan_mcast.sh line 52: +In bridge_vlan_mcast.sh line 53: @@ -124 +124 @@ -In bridge_vlan_mcast.sh line 53: +In bridge_vlan_mcast.sh line 54: @@ -132 +132 @@ -In bridge_vlan_mcast.sh line 62: +In bridge_vlan_mcast.sh line 63: @@ -140 +140 @@ -In bridge_vlan_mcast.sh line 63: +In bridge_vlan_mcast.sh line 64: @@ -148 +148 @@ -In bridge_vlan_mcast.sh line 65: +In bridge_vlan_mcast.sh line 66: @@ -156 +156 @@ -In bridge_vlan_mcast.sh line 66: +In bridge_vlan_mcast.sh line 67: @@ -164 +164,14 @@ -In bridge_vlan_mcast.sh line 104: +In bridge_vlan_mcast.sh line 103: + local args=$@ + ^-- SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. + + +In bridge_vlan_mcast.sh line 107: + return $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + return "$EXIT_STATUS" + + +In bridge_vlan_mcast.sh line 116: @@ -173 +186 @@ -In bridge_vlan_mcast.sh line 110: +In bridge_vlan_mcast.sh line 122: @@ -181 +194 @@ -In bridge_vlan_mcast.sh line 117: +In bridge_vlan_mcast.sh line 129: @@ -189 +202 @@ -In bridge_vlan_mcast.sh line 118: +In bridge_vlan_mcast.sh line 130: @@ -199 +212 @@ -In bridge_vlan_mcast.sh line 130: +In bridge_vlan_mcast.sh line 142: @@ -208 +221 @@ -In bridge_vlan_mcast.sh line 131: +In bridge_vlan_mcast.sh line 143: @@ -216 +229 @@ -In bridge_vlan_mcast.sh line 137: +In bridge_vlan_mcast.sh line 149: @@ -224 +237 @@ -In bridge_vlan_mcast.sh line 157: +In bridge_vlan_mcast.sh line 169: @@ -232 +245 @@ -In bridge_vlan_mcast.sh line 167: +In bridge_vlan_mcast.sh line 181: @@ -240 +253,17 @@ -In bridge_vlan_mcast.sh line 171: +In bridge_vlan_mcast.sh line 186: + tc filter add dev $dev egress pref 20 prot 802.1Q u32 \ + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tc filter add dev "$dev" egress pref 20 prot 802.1Q u32 \ + + +In bridge_vlan_mcast.sh line 187: + match u8 0x11 0xff at 24 $intvl_match \ + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + match u8 0x11 0xff at 24 "$intvl_match" \ + + +In bridge_vlan_mcast.sh line 191: @@ -248 +277,25 @@ -In bridge_vlan_mcast.sh line 184: +In bridge_vlan_mcast.sh line 196: + tc filter add dev $dev egress pref 20 prot 802.1Q u32 \ + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tc filter add dev "$dev" egress pref 20 prot 802.1Q u32 \ + + +In bridge_vlan_mcast.sh line 197: + match u8 0x82 0xff at 48 $intvl_match \ + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + match u8 0x82 0xff at 48 "$intvl_match" \ + + +In bridge_vlan_mcast.sh line 209: + tc filter del dev $dev egress pref 20 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tc filter del dev "$dev" egress pref 20 + + +In bridge_vlan_mcast.sh line 210: @@ -256,2 +309,36 @@ -In bridge_vlan_mcast.sh line 196: - vlmc_query_cnt_setup $type $dev +In bridge_vlan_mcast.sh line 226: + encode="$(./mc_encode 8 $interval)" + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + encode="$(./mc_encode 8 "$interval")" + + +In bridge_vlan_mcast.sh line 237: + encode="$(./mc_encode 8 $interval)" + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + encode="$(./mc_encode 8 "$interval")" + + +In bridge_vlan_mcast.sh line 242: + encode="$(./mc_encode 16 $interval)" + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + encode="$(./mc_encode 16 "$interval")" + + +In bridge_vlan_mcast.sh line 260: + intvl_match="$(vlmc_query_get_intvl_match $type $version $interval)" + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + intvl_match="$(vlmc_query_get_intvl_match "$type" "$version" "$interval")" + + +In bridge_vlan_mcast.sh line 261: + vlmc_query_cnt_setup $type $dev "$intvl_match" @@ -262 +349 @@ - vlmc_query_cnt_setup "$type" "$dev" + vlmc_query_cnt_setup "$type" "$dev" "$intvl_match" @@ -265 +352 @@ -In bridge_vlan_mcast.sh line 198: +In bridge_vlan_mcast.sh line 263: @@ -276 +363 @@ -In bridge_vlan_mcast.sh line 202: +In bridge_vlan_mcast.sh line 267: @@ -284,2 +371,2 @@ -In bridge_vlan_mcast.sh line 204: - local tcstats=$(tc_rule_stats_get $dev 10 egress) +In bridge_vlan_mcast.sh line 269: + local tcstats=$(tc_rule_stats_get $dev 20 egress) @@ -290 +377 @@ - local tcstats=$(tc_rule_stats_get "$dev" 10 egress) + local tcstats=$(tc_rule_stats_get "$dev" 20 egress) @@ -293 +380 @@ -In bridge_vlan_mcast.sh line 205: +In bridge_vlan_mcast.sh line 270: @@ -304 +391 @@ -In bridge_vlan_mcast.sh line 207: +In bridge_vlan_mcast.sh line 272: @@ -309 +396 @@ -In bridge_vlan_mcast.sh line 208: +In bridge_vlan_mcast.sh line 273: @@ -316 +403 @@ -In bridge_vlan_mcast.sh line 209: +In bridge_vlan_mcast.sh line 274: @@ -322 +409 @@ -In bridge_vlan_mcast.sh line 215: +In bridge_vlan_mcast.sh line 280: @@ -330 +417 @@ -In bridge_vlan_mcast.sh line 217: +In bridge_vlan_mcast.sh line 282: @@ -338 +425 @@ -In bridge_vlan_mcast.sh line 223: +In bridge_vlan_mcast.sh line 288: @@ -347 +434 @@ -In bridge_vlan_mcast.sh line 224: +In bridge_vlan_mcast.sh line 289: @@ -355 +442 @@ -In bridge_vlan_mcast.sh line 228: +In bridge_vlan_mcast.sh line 293: @@ -363 +450 @@ -In bridge_vlan_mcast.sh line 240: +In bridge_vlan_mcast.sh line 305: @@ -371 +458 @@ -In bridge_vlan_mcast.sh line 245: +In bridge_vlan_mcast.sh line 310: @@ -379 +466 @@ -In bridge_vlan_mcast.sh line 253: +In bridge_vlan_mcast.sh line 318: @@ -388 +475 @@ -In bridge_vlan_mcast.sh line 254: +In bridge_vlan_mcast.sh line 319: @@ -396 +483 @@ -In bridge_vlan_mcast.sh line 258: +In bridge_vlan_mcast.sh line 323: @@ -404 +491 @@ -In bridge_vlan_mcast.sh line 264: +In bridge_vlan_mcast.sh line 329: @@ -412 +499 @@ -In bridge_vlan_mcast.sh line 275: +In bridge_vlan_mcast.sh line 340: @@ -420 +507 @@ -In bridge_vlan_mcast.sh line 285: +In bridge_vlan_mcast.sh line 350: @@ -428 +515 @@ -In bridge_vlan_mcast.sh line 296: +In bridge_vlan_mcast.sh line 361: @@ -437 +524 @@ -In bridge_vlan_mcast.sh line 297: +In bridge_vlan_mcast.sh line 362: @@ -445 +532 @@ -In bridge_vlan_mcast.sh line 301: +In bridge_vlan_mcast.sh line 366: @@ -453 +540 @@ -In bridge_vlan_mcast.sh line 308: +In bridge_vlan_mcast.sh line 373: @@ -461 +548 @@ -In bridge_vlan_mcast.sh line 330: +In bridge_vlan_mcast.sh line 395: @@ -470 +557 @@ -In bridge_vlan_mcast.sh line 331: +In bridge_vlan_mcast.sh line 396: @@ -478 +565 @@ -In bridge_vlan_mcast.sh line 335: +In bridge_vlan_mcast.sh line 400: @@ -486 +573 @@ -In bridge_vlan_mcast.sh line 342: +In bridge_vlan_mcast.sh line 407: @@ -494 +581 @@ -In bridge_vlan_mcast.sh line 351: +In bridge_vlan_mcast.sh line 416: @@ -502 +589 @@ -In bridge_vlan_mcast.sh line 358: +In bridge_vlan_mcast.sh line 423: @@ -510 +597 @@ -In bridge_vlan_mcast.sh line 369: +In bridge_vlan_mcast.sh line 434: @@ -519 +606 @@ -In bridge_vlan_mcast.sh line 370: +In bridge_vlan_mcast.sh line 435: @@ -527 +614 @@ -In bridge_vlan_mcast.sh line 374: +In bridge_vlan_mcast.sh line 439: @@ -535 +622 @@ -In bridge_vlan_mcast.sh line 395: +In bridge_vlan_mcast.sh line 460: @@ -544 +631 @@ -In bridge_vlan_mcast.sh line 396: +In bridge_vlan_mcast.sh line 461: @@ -552 +639 @@ -In bridge_vlan_mcast.sh line 400: +In bridge_vlan_mcast.sh line 465: @@ -560 +647 @@ -In bridge_vlan_mcast.sh line 415: +In bridge_vlan_mcast.sh line 480: @@ -568 +655 @@ -In bridge_vlan_mcast.sh line 417: +In bridge_vlan_mcast.sh line 482: @@ -576 +663 @@ -In bridge_vlan_mcast.sh line 421: +In bridge_vlan_mcast.sh line 486: @@ -584 +671 @@ -In bridge_vlan_mcast.sh line 422: +In bridge_vlan_mcast.sh line 487: @@ -592 +679 @@ -In bridge_vlan_mcast.sh line 432: +In bridge_vlan_mcast.sh line 501: @@ -601 +688 @@ -In bridge_vlan_mcast.sh line 433: +In bridge_vlan_mcast.sh line 502: @@ -609 +696 @@ -In bridge_vlan_mcast.sh line 437: +In bridge_vlan_mcast.sh line 506: @@ -617 +704 @@ -In bridge_vlan_mcast.sh line 448: +In bridge_vlan_mcast.sh line 518: @@ -625 +712,33 @@ -In bridge_vlan_mcast.sh line 459: +In bridge_vlan_mcast.sh line 532: + vlmc_check_query igmp 3 $swp1 1 1 60 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 60 + + +In bridge_vlan_mcast.sh line 537: + vlmc_check_query mld 2 $swp1 1 1 60 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 60 + + +In bridge_vlan_mcast.sh line 545: + vlmc_check_query igmp 3 $swp1 1 1 160 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 160 + + +In bridge_vlan_mcast.sh line 550: + vlmc_check_query mld 2 $swp1 1 1 160 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 160 + + +In bridge_vlan_mcast.sh line 567: @@ -634 +753 @@ -In bridge_vlan_mcast.sh line 460: +In bridge_vlan_mcast.sh line 568: @@ -642 +761 @@ -In bridge_vlan_mcast.sh line 464: +In bridge_vlan_mcast.sh line 572: @@ -650 +769,33 @@ -In bridge_vlan_mcast.sh line 481: +In bridge_vlan_mcast.sh line 588: + vlmc_check_query igmp 3 $swp1 1 1 60 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 60 + + +In bridge_vlan_mcast.sh line 596: + vlmc_check_query igmp 3 $swp1 1 1 160 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query igmp 3 "$swp1" 1 1 160 + + +In bridge_vlan_mcast.sh line 607: + vlmc_check_query mld 2 $swp1 1 1 30000 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 30000 + + +In bridge_vlan_mcast.sh line 615: + vlmc_check_query mld 2 $swp1 1 1 60000 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + vlmc_check_query mld 2 "$swp1" 1 1 60000 + + +In bridge_vlan_mcast.sh line 628: @@ -659 +810 @@ -In bridge_vlan_mcast.sh line 482: +In bridge_vlan_mcast.sh line 629: @@ -667 +818 @@ -In bridge_vlan_mcast.sh line 487: +In bridge_vlan_mcast.sh line 634: @@ -675 +826 @@ -In bridge_vlan_mcast.sh line 495: +In bridge_vlan_mcast.sh line 642: @@ -683 +834 @@ -In bridge_vlan_mcast.sh line 500: +In bridge_vlan_mcast.sh line 647: @@ -691 +842 @@ -In bridge_vlan_mcast.sh line 502: +In bridge_vlan_mcast.sh line 649: @@ -699 +850 @@ -In bridge_vlan_mcast.sh line 504: +In bridge_vlan_mcast.sh line 651: @@ -707 +858 @@ -In bridge_vlan_mcast.sh line 513: +In bridge_vlan_mcast.sh line 660: @@ -716 +867 @@ -In bridge_vlan_mcast.sh line 517: +In bridge_vlan_mcast.sh line 664: @@ -725 +876 @@ -In bridge_vlan_mcast.sh line 518: +In bridge_vlan_mcast.sh line 665: @@ -733 +884 @@ -In bridge_vlan_mcast.sh line 521: +In bridge_vlan_mcast.sh line 668: @@ -741 +892 @@ -In bridge_vlan_mcast.sh line 522: +In bridge_vlan_mcast.sh line 669: @@ -749 +900 @@ -In bridge_vlan_mcast.sh line 525: +In bridge_vlan_mcast.sh line 672: @@ -757 +908 @@ -In bridge_vlan_mcast.sh line 526: +In bridge_vlan_mcast.sh line 673: @@ -765 +916 @@ -In bridge_vlan_mcast.sh line 546: +In bridge_vlan_mcast.sh line 693: @@ -775 +926 @@ - https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... + https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A...