CHECK: Comparison to NULL could be written "!ctx.offsets" #229: FILE: arch/arm/net/bpf_jit_32.c:2167: + if (ctx.offsets == NULL) CHECK: Comparison to NULL could be written "!ctx.imms" #252: FILE: arch/arm/net/bpf_jit_32.c:2197: + if (ctx.imms == NULL) CHECK: Comparison to NULL could be written "!header" #264: FILE: arch/arm/net/bpf_jit_32.c:2220: + if (header == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #355: FILE: arch/arm64/net/bpf_jit_comp.c:2065: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #523: FILE: arch/loongarch/net/bpf_jit.c:1964: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!addrs" #853: FILE: arch/powerpc/net/bpf_jit_comp.c:183: + if (addrs == NULL) CHECK: Comparison to NULL could be written "!jit.addrs" #1145: FILE: arch/s390/net/bpf_jit_comp.c:2343: + if (jit.addrs == NULL) CHECK: Comparison to NULL could be written "!ctx.offset" #1263: FILE: arch/sparc/net/bpf_jit_comp_64.c:1515: + if (ctx.offset == NULL) CHECK: Comparison to NULL could be written "!header" #1289: FILE: arch/sparc/net/bpf_jit_comp_64.c:1553: + if (header == NULL) WARNING: line length of 89 exceeds 80 columns #1563: FILE: include/linux/filter.h:1191: +static inline struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off, WARNING: line length of 89 exceeds 80 columns #1564: FILE: include/linux/filter.h:1192: + const struct bpf_insn *patch, u32 len) WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #1566: FILE: include/linux/filter.h:1194: + return ERR_PTR(-ENOTSUPP); WARNING: line length of 94 exceeds 80 columns #1578: FILE: include/linux/filter.h:1324: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog); WARNING: line length of 93 exceeds 80 columns #1599: FILE: include/linux/filter.h:1476: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog) WARNING: line length of 93 exceeds 80 columns #1604: FILE: include/linux/filter.h:1481: +static inline void bpf_jit_prog_release_other(struct bpf_prog *fp, struct bpf_prog *fp_other) WARNING: line length of 86 exceeds 80 columns #1619: FILE: kernel/bpf/core.c:1509: +/* Now this function is used only to blind the main prog and must be invoked only when WARNING: line length of 93 exceeds 80 columns #1622: FILE: kernel/bpf/core.c:1512: +struct bpf_prog *bpf_jit_blind_constants(struct bpf_verifier_env *env, struct bpf_prog *prog) WARNING: line length of 84 exceeds 80 columns #1655: FILE: kernel/bpf/core.c:1561: + tmp = bpf_patch_insn_single(clone, i, insn_buff, rewritten); WARNING: line length of 97 exceeds 80 columns #1659: FILE: kernel/bpf/core.c:1565: + /* record the actual length of the adjusted env->insn_aux_data */ WARNING: line length of 93 exceeds 80 columns #1681: FILE: kernel/bpf/core.c:1584: + /* Instructions arrays must be updated using absolute xlated offsets. WARNING: line length of 94 exceeds 80 columns #1682: FILE: kernel/bpf/core.c:1585: + * The arrays have already been adjusted by bpf_patch_insn_data() when WARNING: line length of 93 exceeds 80 columns #1693: FILE: kernel/bpf/core.c:1597: + /* also record the actual length of env->insn_aux_data on success, so it can be freed WARNING: line length of 88 exceeds 80 columns #1713: FILE: kernel/bpf/core.c:2570: + /* If blinding was requested and we failed during blinding, we must fall WARNING: line length of 82 exceeds 80 columns #1781: FILE: kernel/bpf/verifier.c:23001: +static void restore_subprog_starts(struct bpf_verifier_env *env, u32 *orig_starts) CHECK: multiple assignments should be avoided #1852: FILE: kernel/bpf/verifier.c:23286: + prog = orig_prog = env->prog; WARNING: line length of 88 exceeds 80 columns #1882: FILE: kernel/bpf/verifier.c:23316: + /* We will fall back to interpreter mode when err is not -EFAULT, before WARNING: line length of 92 exceeds 80 columns #1883: FILE: kernel/bpf/verifier.c:23317: + * that, insn->off and insn->imm should be restored to their original values WARNING: line length of 86 exceeds 80 columns #1887: FILE: kernel/bpf/verifier.c:23321: + for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) { WARNING: line length of 82 exceeds 80 columns #1923: FILE: kernel/bpf/verifier.c:26532: + clear_insn_aux_data(env, 0, env->blinded_insn_aux_len ? : env->prog->len); total: 0 errors, 19 warnings, 10 checks, 1670 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 34d289876c33 ("bpf: Move constants blinding out of arch-specific JITs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 19 warnings, 10 checks, 1670 lines checked