ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.LUTM9DJIbt and /tmp/tmp.2Oj2OqjP9E
Tree base:
b30e3affd362 ("selftests/net: Test PACKET_STATISTICS")
Now at:
0e0c88172100 ("selftests/net: Test PACKET_STATISTICS drops")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/psock_snd.sh - 5fb5b73d6a88a1570fe273ed24cca13c559f1acba14dd83491b887ae769f215d


In psock_snd.sh line 15:
readonly mss="$((${mtu} - ${iphlen} - ${udphlen}))"
                 ^----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                          ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                      ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 16:
readonly mss_exceeds="$((${mss} + 1))"
                         ^----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 19:
readonly max_mss="$((${max_mtu} - ${iphlen} - ${udphlen}))"
                     ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                  ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                              ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 20:
readonly max_mss_exceeds="$((${max_mss} + 1))"
                             ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 78:
(! ./in_netns.sh ./psock_snd -t "$((${vnet_hlen} + ${eth_hlen}))")
                                    ^----------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                                   ^---------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 81:
(! ./in_netns.sh ./psock_snd -t "$((${vnet_hlen} + ${eth_hlen} - 1))")
                                    ^----------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                                   ^---------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.

For more information:
  https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/psock_snd.sh - 5fb5b73d6a88a1570fe273ed24cca13c559f1acba14dd83491b887ae769f215d


In psock_snd.sh line 15:
readonly mss="$((${mtu} - ${iphlen} - ${udphlen}))"
                 ^----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                          ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                      ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 16:
readonly mss_exceeds="$((${mss} + 1))"
                         ^----^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 19:
readonly max_mss="$((${max_mtu} - ${iphlen} - ${udphlen}))"
                     ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                  ^-------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                              ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 20:
readonly max_mss_exceeds="$((${max_mss} + 1))"
                             ^--------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 78:
(! ./in_netns.sh ./psock_snd -t "$((${vnet_hlen} + ${eth_hlen}))")
                                    ^----------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                                   ^---------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In psock_snd.sh line 81:
(! ./in_netns.sh ./psock_snd -t "$((${vnet_hlen} + ${eth_hlen} - 1))")
                                    ^----------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
                                                   ^---------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.

For more information:
  https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...