ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.XAx21AKkNv and /tmp/tmp.1eJqAqZQk2
Tree base:
fc91732715a3 ("net: team: Decouple rx and tx enablement in the team driver")
Now at:
cee2ec8b1b02 ("selftests: net: Add tests for team driver decoupled tx and rx control")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/team/options.sh - 8923621aa6103a750c8a06390ec378233a35970a1108624075d2d8955a2c557c


In options.sh line 29:
get_and_check_value()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 50:
set_and_check_get()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 71:
get_port_flag()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 80:
attach_port_if_specified()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 90:
detach_port_if_specified()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 109:
team_test_option()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 145:
team_test_get_option_fails()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 166:
team_test_options()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

Checking tools/testing/selftests/drivers/net/team/team_lib.sh - 8a0fe0b10b91397530dc5d2a7e95d8bf69d04ea1dd7f79e4d351b100964be985


In team_lib.sh line 6:
source "${test_dir}/../../../net/forwarding/lib.sh"
        ^---------^ SC2154 (warning): test_dir is referenced but not assigned.


In team_lib.sh line 34:
			${NODAD} dev "${team}"
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			"${NODAD}" dev "${team}"


In team_lib.sh line 50:
		ip -n "${namespace}" link set ${member} master "${team}"
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip -n "${namespace}" link set "${member}" master "${team}"


In team_lib.sh line 59:
	if ! ip -n ${namespace} addr add "${ip_address}/${prefix_length}" \
                   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip -n "${namespace}" addr add "${ip_address}/${prefix_length}" \


In team_lib.sh line 60:
			${NODAD} dev "${team}"; then
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			"${NODAD}" dev "${team}"; then


In team_lib.sh line 120:
	local packet_count=$(tcpdump_show "$interface" | grep \
              ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                         ^-- SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- test_dir is referenced but not as...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/team/decoupled_enablement.sh - cd6377950759aff460f67bef23b4e781cdcb9a5cf878e08a1b9440b7bbc4171d


In decoupled_enablement.sh line 89:
set_option_value()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In decoupled_enablement.sh line 103:
try_ping()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In decoupled_enablement.sh line 109:
team_test_mode_tx_enablement()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In decoupled_enablement.sh line 146:
team_test_mode_rx_enablement()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In decoupled_enablement.sh line 183:
team_test_tx_enablement()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In decoupled_enablement.sh line 190:
team_test_rx_enablement()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

Checking tools/testing/selftests/drivers/net/team/options.sh - 8923621aa6103a750c8a06390ec378233a35970a1108624075d2d8955a2c557c


In options.sh line 32:
get_and_check_value()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 53:
set_and_check_get()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 74:
get_port_flag()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 83:
attach_port_if_specified()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 93:
detach_port_if_specified()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 112:
team_test_option()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 148:
team_test_get_option_fails()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 169:
team_test_options()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 190:
team_test_enabled_implicit_changes()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 220:
team_test_rx_enabled_implicit_changes()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In options.sh line 250:
team_test_tx_enabled_implicit_changes()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

Checking tools/testing/selftests/drivers/net/team/team_lib.sh - 8a0fe0b10b91397530dc5d2a7e95d8bf69d04ea1dd7f79e4d351b100964be985


In team_lib.sh line 6:
source "${test_dir}/../../../net/forwarding/lib.sh"
        ^---------^ SC2154 (warning): test_dir is referenced but not assigned.


In team_lib.sh line 34:
			${NODAD} dev "${team}"
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			"${NODAD}" dev "${team}"


In team_lib.sh line 50:
		ip -n "${namespace}" link set ${member} master "${team}"
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip -n "${namespace}" link set "${member}" master "${team}"


In team_lib.sh line 59:
	if ! ip -n ${namespace} addr add "${ip_address}/${prefix_length}" \
                   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip -n "${namespace}" addr add "${ip_address}/${prefix_length}" \


In team_lib.sh line 60:
			${NODAD} dev "${team}"; then
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			"${NODAD}" dev "${team}"; then


In team_lib.sh line 120:
	local packet_count=$(tcpdump_show "$interface" | grep \
              ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                         ^-- SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.


In team_lib.sh line 136:
	local packet_count=$(tcpdump_show "$interface" | grep \
              ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                         ^-- SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- test_dir is referenced but not as...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...