====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/drivers/net/team/team_lib.sh is a new file, but not shellcheck compliant tools/testing/selftests/drivers/net/team/transmit_failover.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.4gWGmeEuzj 2026-03-31 02:29:17.577986959 -0400 +++ /tmp/tmp.Lot5u0NEXt 2026-03-31 02:29:20.081970021 -0400 @@ -1,0 +2,65 @@ +In team_lib.sh line 6: +source "${test_dir}/../../../net/forwarding/lib.sh" + ^---------^ SC2154 (warning): test_dir is referenced but not assigned. + + +In team_lib.sh line 34: + ${NODAD} dev "${team}" + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + "${NODAD}" dev "${team}" + + +In team_lib.sh line 50: + ip -n "${namespace}" link set ${member} master "${team}" + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "${namespace}" link set "${member}" master "${team}" + + +In team_lib.sh line 59: + if ! ip -n ${namespace} addr add "${ip_address}/${prefix_length}" \ + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if ! ip -n "${namespace}" addr add "${ip_address}/${prefix_length}" \ + + +In team_lib.sh line 60: + ${NODAD} dev "${team}"; then + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + "${NODAD}" dev "${team}"; then + + +In team_lib.sh line 120: + local packet_count=$(tcpdump_show "$interface" | grep \ + ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-- SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. + +For more information: + https://www.shellcheck.net/wiki/SC2154 -- test_dir is referenced but not as... + https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + +In transmit_failover.sh line 92: +team_test_mode_failover() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In transmit_failover.sh line 98: + echo "Members: ${MEMBERS[@]}" + ^-----------^ SC2145 (error): Argument mixes string and array. Use * or separate argument. + + +In transmit_failover.sh line 142: +team_test_failover() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + +For more information: + https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ... + https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C... + @@ -1516 +1581,18 @@ -In lib.sh line 1626: +In lib.sh line 1613: + tcpdump_start_nosleep $1 $2 + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_start_nosleep "$1" "$2" + + +In lib.sh line 1627: + tcpdump_stop_nosleep $1 + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_stop_nosleep "$1" + + +In lib.sh line 1635: @@ -1525 +1607 @@ -In lib.sh line 1633: +In lib.sh line 1642: @@ -1533 +1615 @@ -In lib.sh line 1656: +In lib.sh line 1665: @@ -1541 +1623 @@ -In lib.sh line 1657: +In lib.sh line 1666: @@ -1549 +1631 @@ -In lib.sh line 1658: +In lib.sh line 1667: @@ -1557 +1639 @@ -In lib.sh line 1660: +In lib.sh line 1669: @@ -1568 +1650 @@ -In lib.sh line 1663: +In lib.sh line 1672: @@ -1576 +1658 @@ -In lib.sh line 1666: +In lib.sh line 1675: @@ -1581 +1663 @@ -In lib.sh line 1670: +In lib.sh line 1679: @@ -1589 +1671 @@ -In lib.sh line 1671: +In lib.sh line 1680: @@ -1597 +1679 @@ -In lib.sh line 1706: +In lib.sh line 1715: @@ -1611 +1693 @@ -In lib.sh line 1708: +In lib.sh line 1717: @@ -1619 +1701 @@ -In lib.sh line 1722: +In lib.sh line 1731: @@ -1627 +1709 @@ -In lib.sh line 1747: +In lib.sh line 1756: @@ -1636 +1718 @@ -In lib.sh line 1752: +In lib.sh line 1761: @@ -1644 +1726 @@ -In lib.sh line 1753: +In lib.sh line 1762: @@ -1653 +1735 @@ -In lib.sh line 1768: +In lib.sh line 1777: @@ -1662 +1744 @@ -In lib.sh line 1770: +In lib.sh line 1779: @@ -1670 +1752 @@ -In lib.sh line 1771: +In lib.sh line 1780: @@ -1679 +1761 @@ -In lib.sh line 1825: +In lib.sh line 1834: @@ -1687 +1769 @@ -In lib.sh line 1826: +In lib.sh line 1835: @@ -1697 +1779 @@ -In lib.sh line 1839: +In lib.sh line 1848: @@ -1705 +1787 @@ -In lib.sh line 1840: +In lib.sh line 1849: @@ -1716 +1798 @@ -In lib.sh line 1841: +In lib.sh line 1850: @@ -1725 +1807 @@ -In lib.sh line 1843: +In lib.sh line 1852: @@ -1733 +1815 @@ -In lib.sh line 1857: +In lib.sh line 1866: @@ -1738 +1820 @@ -In lib.sh line 1858: +In lib.sh line 1867: @@ -1747 +1829 @@ -In lib.sh line 1859: +In lib.sh line 1868: @@ -1755 +1837 @@ -In lib.sh line 1862: +In lib.sh line 1871: @@ -1760 +1842 @@ -In lib.sh line 1864: +In lib.sh line 1873: @@ -1768 +1850 @@ -In lib.sh line 1867: +In lib.sh line 1876: @@ -1773 +1855 @@ -In lib.sh line 1869: +In lib.sh line 1878: @@ -1781 +1863 @@ -In lib.sh line 1872: +In lib.sh line 1881: @@ -1786 +1868 @@ -In lib.sh line 1873: +In lib.sh line 1882: @@ -1795 +1877 @@ -In lib.sh line 1874: +In lib.sh line 1883: @@ -1803 +1885 @@ -In lib.sh line 1883: +In lib.sh line 1892: @@ -1811 +1893 @@ -In lib.sh line 1902: +In lib.sh line 1911: @@ -1819 +1901 @@ -In lib.sh line 1920: +In lib.sh line 1929: @@ -1827 +1909 @@ -In lib.sh line 1959: +In lib.sh line 1968: @@ -1836 +1918 @@ -In lib.sh line 1961: +In lib.sh line 1970: @@ -1841 +1923 @@ -In lib.sh line 1978: +In lib.sh line 1987: @@ -1846 +1928 @@ -In lib.sh line 1982: +In lib.sh line 1991: @@ -1851 +1933 @@ -In lib.sh line 1983: +In lib.sh line 1992: @@ -1856 +1938 @@ -In lib.sh line 1984: +In lib.sh line 1993: @@ -1861 +1943 @@ -In lib.sh line 1985: +In lib.sh line 1994: @@ -1866 +1948 @@ -In lib.sh line 1986: +In lib.sh line 1995: @@ -1871 +1953 @@ -In lib.sh line 1987: +In lib.sh line 1996: @@ -1876 +1958 @@ -In lib.sh line 1988: +In lib.sh line 1997: @@ -1881 +1963 @@ -In lib.sh line 1989: +In lib.sh line 1998: @@ -1886 +1968 @@ -In lib.sh line 1990: +In lib.sh line 1999: @@ -1895 +1977 @@ -In lib.sh line 1992: +In lib.sh line 2001: @@ -1903 +1985 @@ -In lib.sh line 1996: +In lib.sh line 2005: @@ -1908 +1990 @@ -In lib.sh line 1998: +In lib.sh line 2007: @@ -1916 +1998 @@ -In lib.sh line 2005: +In lib.sh line 2014: @@ -1921 +2003 @@ -In lib.sh line 2006: +In lib.sh line 2015: @@ -1926 +2008 @@ -In lib.sh line 2007: +In lib.sh line 2016: @@ -1931 +2013 @@ -In lib.sh line 2008: +In lib.sh line 2017: @@ -1936 +2018 @@ -In lib.sh line 2009: +In lib.sh line 2018: @@ -1944 +2026 @@ -In lib.sh line 2011: +In lib.sh line 2020: @@ -1949 +2031 @@ -In lib.sh line 2013: +In lib.sh line 2022: @@ -1957 +2039 @@ -In lib.sh line 2024: +In lib.sh line 2033: @@ -1962 +2044 @@ -In lib.sh line 2027: +In lib.sh line 2036: @@ -1967 +2049 @@ -In lib.sh line 2028: +In lib.sh line 2037: @@ -1972 +2054 @@ -In lib.sh line 2033: +In lib.sh line 2042: @@ -1977 +2059 @@ -In lib.sh line 2034: +In lib.sh line 2043: @@ -1982 +2064 @@ -In lib.sh line 2035: +In lib.sh line 2044: @@ -1987 +2069 @@ -In lib.sh line 2036: +In lib.sh line 2045: @@ -1992 +2074 @@ -In lib.sh line 2037: +In lib.sh line 2046: @@ -1997 +2079 @@ -In lib.sh line 2038: +In lib.sh line 2047: @@ -2002 +2084 @@ -In lib.sh line 2039: +In lib.sh line 2048: @@ -2007 +2089 @@ -In lib.sh line 2040: +In lib.sh line 2049: @@ -2012 +2094 @@ -In lib.sh line 2041: +In lib.sh line 2050: @@ -2021 +2103 @@ -In lib.sh line 2043: +In lib.sh line 2052: @@ -2029 +2111 @@ -In lib.sh line 2048: +In lib.sh line 2057: @@ -2039 +2121 @@ -In lib.sh line 2049: +In lib.sh line 2058: @@ -2044 +2126 @@ -In lib.sh line 2050: +In lib.sh line 2059: @@ -2053 +2135 @@ -In lib.sh line 2051: +In lib.sh line 2060: @@ -2062 +2144 @@ -In lib.sh line 2052: +In lib.sh line 2061: @@ -2067 +2149 @@ -In lib.sh line 2055: +In lib.sh line 2064: @@ -2077 +2159 @@ -In lib.sh line 2057: +In lib.sh line 2066: @@ -2085 +2167 @@ -In lib.sh line 2069: +In lib.sh line 2078: @@ -2090 +2172 @@ -In lib.sh line 2070: +In lib.sh line 2079: @@ -2095 +2177 @@ -In lib.sh line 2075: +In lib.sh line 2084: @@ -2100 +2182 @@ -In lib.sh line 2076: +In lib.sh line 2085: @@ -2105 +2187 @@ -In lib.sh line 2077: +In lib.sh line 2086: @@ -2110 +2192 @@ -In lib.sh line 2078: +In lib.sh line 2087: @@ -2115 +2197 @@ -In lib.sh line 2079: +In lib.sh line 2088: @@ -2120 +2202 @@ -In lib.sh line 2080: +In lib.sh line 2089: @@ -2128 +2210 @@ -In lib.sh line 2083: +In lib.sh line 2092: @@ -2138 +2220 @@ -In lib.sh line 2084: +In lib.sh line 2093: @@ -2143 +2225 @@ -In lib.sh line 2085: +In lib.sh line 2094: @@ -2152 +2234 @@ -In lib.sh line 2086: +In lib.sh line 2095: @@ -2161 +2243 @@ -In lib.sh line 2087: +In lib.sh line 2096: @@ -2166 +2248 @@ -In lib.sh line 2090: +In lib.sh line 2099: @@ -2176 +2258 @@ -In lib.sh line 2092: +In lib.sh line 2101: @@ -2184 +2266 @@ -In lib.sh line 2121: +In lib.sh line 2130: @@ -2193 +2275 @@ -In lib.sh line 2122: +In lib.sh line 2131: @@ -2201 +2283 @@ -In lib.sh line 2139: +In lib.sh line 2148: @@ -2210 +2292 @@ -In lib.sh line 2140: +In lib.sh line 2149: @@ -2219 +2301 @@ -In lib.sh line 2143: +In lib.sh line 2152: @@ -2227 +2309 @@ -In lib.sh line 2144: +In lib.sh line 2153: @@ -2235 +2317 @@ -In lib.sh line 2145: +In lib.sh line 2154: @@ -2240 +2322 @@ -In lib.sh line 2148: +In lib.sh line 2157: