ERROR: do not use assignment in if condition #62: FILE: tools/testing/selftests/bpf/test_loader.c:448: + if ((val = str_has_pfx(s, "test_description="))) { ERROR: do not use assignment in if condition #91: FILE: tools/testing/selftests/bpf/test_loader.c:470: + } else if ((msg = str_has_pfx(s, "test_expect_msg="))) { ERROR: do not use assignment in if condition #97: FILE: tools/testing/selftests/bpf/test_loader.c:475: + } else if ((msg = str_has_pfx(s, "test_expect_not_msg="))) { ERROR: do not use assignment in if condition #103: FILE: tools/testing/selftests/bpf/test_loader.c:480: + } else if ((msg = str_has_pfx(s, "test_expect_msg_unpriv="))) { WARNING: line length of 83 exceeds 80 columns #109: FILE: tools/testing/selftests/bpf/test_loader.c:485: + } else if ((msg = str_has_pfx(s, "test_expect_not_msg_unpriv="))) { ERROR: do not use assignment in if condition #109: FILE: tools/testing/selftests/bpf/test_loader.c:485: + } else if ((msg = str_has_pfx(s, "test_expect_not_msg_unpriv="))) { ERROR: do not use assignment in if condition #115: FILE: tools/testing/selftests/bpf/test_loader.c:490: + } else if ((msg = str_has_pfx(s, "test_jited="))) { ERROR: do not use assignment in if condition #124: FILE: tools/testing/selftests/bpf/test_loader.c:502: + } else if ((msg = str_has_pfx(s, "test_jited_unpriv="))) { ERROR: do not use assignment in if condition #133: FILE: tools/testing/selftests/bpf/test_loader.c:514: + } else if ((msg = str_has_pfx(s, "test_expect_xlated="))) { WARNING: line length of 82 exceeds 80 columns #140: FILE: tools/testing/selftests/bpf/test_loader.c:520: + } else if ((msg = str_has_pfx(s, "test_expect_xlated_unpriv="))) { ERROR: do not use assignment in if condition #140: FILE: tools/testing/selftests/bpf/test_loader.c:520: + } else if ((msg = str_has_pfx(s, "test_expect_xlated_unpriv="))) { ERROR: do not use assignment in if condition #147: FILE: tools/testing/selftests/bpf/test_loader.c:526: + } else if ((val = str_has_pfx(s, "test_retval="))) { ERROR: do not use assignment in if condition #154: FILE: tools/testing/selftests/bpf/test_loader.c:532: + } else if ((val = str_has_pfx(s, "test_retval_unpriv="))) { ERROR: do not use assignment in if condition #162: FILE: tools/testing/selftests/bpf/test_loader.c:539: + } else if ((val = str_has_pfx(s, "test_log_level="))) { ERROR: do not use assignment in if condition #167: FILE: tools/testing/selftests/bpf/test_loader.c:543: + } else if ((val = str_has_pfx(s, "test_prog_flags="))) { ERROR: do not use assignment in if condition #176: FILE: tools/testing/selftests/bpf/test_loader.c:568: + } else if ((val = str_has_pfx(s, "test_arch="))) { ERROR: do not use assignment in if condition #185: FILE: tools/testing/selftests/bpf/test_loader.c:586: + } else if ((val = str_has_pfx(s, "test_btf_path="))) { ERROR: do not use assignment in if condition #188: FILE: tools/testing/selftests/bpf/test_loader.c:588: + } else if ((val = str_has_pfx(s, "test_caps_unpriv="))) { ERROR: do not use assignment in if condition #194: FILE: tools/testing/selftests/bpf/test_loader.c:593: + } else if ((val = str_has_pfx(s, "load_mode="))) { ERROR: do not use assignment in if condition #203: FILE: tools/testing/selftests/bpf/test_loader.c:603: + } else if ((msg = str_has_pfx(s, "test_expect_stderr="))) { WARNING: line length of 82 exceeds 80 columns #209: FILE: tools/testing/selftests/bpf/test_loader.c:608: + } else if ((msg = str_has_pfx(s, "test_expect_stderr_unpriv="))) { ERROR: do not use assignment in if condition #209: FILE: tools/testing/selftests/bpf/test_loader.c:608: + } else if ((msg = str_has_pfx(s, "test_expect_stderr_unpriv="))) { ERROR: do not use assignment in if condition #215: FILE: tools/testing/selftests/bpf/test_loader.c:613: + } else if ((msg = str_has_pfx(s, "test_expect_stdout="))) { WARNING: line length of 82 exceeds 80 columns #221: FILE: tools/testing/selftests/bpf/test_loader.c:618: + } else if ((msg = str_has_pfx(s, "test_expect_stdout_unpriv="))) { ERROR: do not use assignment in if condition #221: FILE: tools/testing/selftests/bpf/test_loader.c:618: + } else if ((msg = str_has_pfx(s, "test_expect_stdout_unpriv="))) { ERROR: do not use assignment in if condition #227: FILE: tools/testing/selftests/bpf/test_loader.c:623: + } else if ((val = str_has_pfx(s, "test_linear_size="))) { total: 22 errors, 4 warnings, 0 checks, 202 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 9488eb1e75f4 ("selftests/bpf: inline TEST_TAG constants in test_loader.c") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.