ERROR: do not use assignment in if condition #50: FILE: tools/testing/selftests/bpf/test_loader.c:175: + if (!in_regex && (m = str_has_pfx(pattern, "{{"))) { ERROR: do not use assignment in if condition #57: FILE: tools/testing/selftests/bpf/test_loader.c:180: + if (in_regex && (m = str_has_pfx(pattern, "}}"))) { ERROR: do not use assignment in if condition #70: FILE: tools/testing/selftests/bpf/test_loader.c:459: + if ((val = str_has_pfx(s, TEST_TAG_DESCRIPTION_PFX))) { ERROR: do not use assignment in if condition #81: FILE: tools/testing/selftests/bpf/test_loader.c:537: + } else if ((val = str_has_pfx(s, TEST_TAG_RETVAL_PFX))) { ERROR: do not use assignment in if condition #89: FILE: tools/testing/selftests/bpf/test_loader.c:543: + } else if ((val = str_has_pfx(s, TEST_TAG_RETVAL_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #98: FILE: tools/testing/selftests/bpf/test_loader.c:550: + } else if ((val = str_has_pfx(s, TEST_TAG_LOG_LEVEL_PFX))) { ERROR: do not use assignment in if condition #105: FILE: tools/testing/selftests/bpf/test_loader.c:554: + } else if ((val = str_has_pfx(s, TEST_TAG_PROG_FLAGS_PFX))) { ERROR: do not use assignment in if condition #115: FILE: tools/testing/selftests/bpf/test_loader.c:579: + } else if ((val = str_has_pfx(s, TEST_TAG_ARCH))) { ERROR: do not use assignment in if condition #127: FILE: tools/testing/selftests/bpf/test_loader.c:597: + } else if ((val = str_has_pfx(s, TEST_BTF_PATH))) { ERROR: do not use assignment in if condition #129: FILE: tools/testing/selftests/bpf/test_loader.c:599: + } else if ((val = str_has_pfx(s, TEST_TAG_CAPS_UNPRIV))) { ERROR: do not use assignment in if condition #136: FILE: tools/testing/selftests/bpf/test_loader.c:604: + } else if ((val = str_has_pfx(s, TEST_TAG_LOAD_MODE_PFX))) { ERROR: do not use assignment in if condition #145: FILE: tools/testing/selftests/bpf/test_loader.c:634: + } else if ((val = str_has_pfx(s, TEST_TAG_LINEAR_SIZE))) { total: 12 errors, 0 warnings, 0 checks, 125 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit bb17f52a6b84 ("selftests/bpf: make str_has_pfx return pointer past the prefix") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.