ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.wcOn9wht1q and /tmp/tmp.2j3qBuO0Mk Tree base: 964ce9f3e46a ("ipv6: mld: encode multicast exponential fields") Now at: f3fde2cf9c23 ("selftests: net: bridge: add tests for igmpv3 MRC and QQIC validation") ====== Checking before the patch ====== Checking tools/testing/selftests/net/forwarding/bridge_igmp.sh - 7f05e1ecbd63c4b5170ddfd2a347d3b84f3d3bec9951bb591e877de73485755f In bridge_igmp.sh line 53: simple_if_init $h1 192.0.2.1/24 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/24 2001:db8:1::1/64 In bridge_igmp.sh line 56: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 58: simple_if_fini $h1 192.0.2.1/24 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" 192.0.2.1/24 2001:db8:1::1/64 In bridge_igmp.sh line 63: simple_if_init $h2 192.0.2.2/24 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/24 2001:db8:1::2/64 In bridge_igmp.sh line 66: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 68: simple_if_fini $h2 192.0.2.2/24 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" 192.0.2.2/24 2001:db8:1::2/64 In bridge_igmp.sh line 75: ip link set dev $swp1 master br0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br0 In bridge_igmp.sh line 76: ip link set dev $swp2 master br0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" master br0 In bridge_igmp.sh line 79: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In bridge_igmp.sh line 80: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In bridge_igmp.sh line 83: switch_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 85: ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" down In bridge_igmp.sh line 86: ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" down In bridge_igmp.sh line 107: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 119: v2reportleave_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 122: ip address add dev $h2 $TEST_GROUP/32 autojoin ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$h2" "$TEST_GROUP"/32 autojoin In bridge_igmp.sh line 126: bridge mdb show dev br0 | grep $TEST_GROUP 1>/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb show dev br0 | grep "$TEST_GROUP" 1>/dev/null In bridge_igmp.sh line 129: mcast_packet_test $TEST_GROUP_MAC 192.0.2.1 $TEST_GROUP $h1 $h2 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mcast_packet_test "$TEST_GROUP_MAC" 192.0.2.1 "$TEST_GROUP" "$h1" "$h2" In bridge_igmp.sh line 135: bridge mdb show dev br0 | grep $TEST_GROUP 1>/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb show dev br0 | grep "$TEST_GROUP" 1>/dev/null In bridge_igmp.sh line 138: ip address del dev $h2 $TEST_GROUP/32 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address del dev "$h2" "$TEST_GROUP"/32 In bridge_igmp.sh line 142: bridge mdb show dev br0 | grep $TEST_GROUP 1>/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb show dev br0 | grep "$TEST_GROUP" 1>/dev/null In bridge_igmp.sh line 145: mcast_packet_test $TEST_GROUP_MAC 192.0.2.1 $TEST_GROUP $h1 $h2 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mcast_packet_test "$TEST_GROUP_MAC" 192.0.2.1 "$TEST_GROUP" "$h1" "$h2" In bridge_igmp.sh line 151: v3include_prepare() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 161: $MZ $host1_if -b $mac -c 1 -B $group -t ip "proto=2,p=$MZPKT_IS_INC" -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -b "$mac" -c 1 -B "$group" -t ip "proto=2,p=$MZPKT_IS_INC" -q In bridge_igmp.sh line 175: v3exclude_prepare() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 180: local pkt=$4 ^-^ SC2034 (warning): pkt appears unused. Verify use (or export if used externally). In bridge_igmp.sh line 184: v3include_prepare $host1_if $mac $group ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$host1_if" "$mac" "$group" In bridge_igmp.sh line 186: $MZ $host1_if -c 1 -b $mac -B $group -t ip "proto=2,p=$MZPKT_IS_EXC" -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -b "$mac" -B "$group" -t ip "proto=2,p=$MZPKT_IS_EXC" -q In bridge_igmp.sh line 207: v3cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 212: bridge mdb del dev br0 port $port grp $group ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb del dev br0 port "$port" grp "$group" In bridge_igmp.sh line 216: v3include_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 221: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 230: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 233: v3inc_allow_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 238: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 240: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_ALLOW" -q In bridge_igmp.sh line 251: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 254: v3inc_is_include_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 259: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 261: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_INC2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_INC2" -q In bridge_igmp.sh line 272: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 275: v3inc_is_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 279: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 286: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 289: v3inc_to_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 295: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 300: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_TO_EXC" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_TO_EXC" -q In bridge_igmp.sh line 333: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 336: v3exc_allow_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 342: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 344: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_ALLOW2" -q In bridge_igmp.sh line 356: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 359: v3exc_is_include_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 365: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 367: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_INC3" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_INC3" -q In bridge_igmp.sh line 379: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 382: v3exc_is_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 388: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 390: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_EXC2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_EXC2" -q In bridge_igmp.sh line 402: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 405: v3exc_to_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 411: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 416: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_TO_EXC" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_TO_EXC" -q In bridge_igmp.sh line 430: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 433: v3inc_block_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 438: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 440: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_BLOCK" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_BLOCK" -q In bridge_igmp.sh line 459: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 462: v3exc_block_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 468: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 473: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_BLOCK" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_BLOCK" -q In bridge_igmp.sh line 487: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 490: v3exc_timeout_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 500: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 505: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_ALLOW2" -q In bridge_igmp.sh line 539: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 542: v3star_ex_auto_add_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 546: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 548: $MZ $h2 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_INC" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h2" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_INC" -q In bridge_igmp.sh line 567: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 568: v3cleanup $swp2 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp2" "$TEST_GROUP" In bridge_igmp.sh line 571: v2per_vlan_snooping_stp_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 589: [[ $is_port -eq 1 ]] && bridge link set dev $swp1 state 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -eq 1 ]] && bridge link set dev "$swp1" state 0 In bridge_igmp.sh line 590: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev $swp1 state 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev "$swp1" state 4 In bridge_igmp.sh line 592: local tx_s=$(ip -j -p stats show dev $swp1 \ ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tx_s=$(ip -j -p stats show dev "$swp1" \ In bridge_igmp.sh line 596: [[ $is_port -eq 1 ]] && bridge link set dev $swp1 state 3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -eq 1 ]] && bridge link set dev "$swp1" state 3 In bridge_igmp.sh line 597: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev $swp1 state 3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev "$swp1" state 3 In bridge_igmp.sh line 599: local tx_e=$(ip -j -p stats show dev $swp1 \ ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tx_e=$(ip -j -p stats show dev "$swp1" \ In bridge_igmp.sh line 604: local tx=$(expr $tx_e - $tx_s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tx=$(expr "$tx_e" - "$tx_s") In bridge_igmp.sh line 605: test $tx -gt 0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$tx" -gt 0 In bridge_igmp.sh line 619: v2per_vlan_snooping_port_stp_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 624: v2per_vlan_snooping_vlan_stp_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 636: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- pkt appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/forwarding/bridge_igmp.sh - 7f05e1ecbd63c4b5170ddfd2a347d3b84f3d3bec9951bb591e877de73485755f In bridge_igmp.sh line 55: simple_if_init $h1 192.0.2.1/24 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/24 2001:db8:1::1/64 In bridge_igmp.sh line 58: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 60: simple_if_fini $h1 192.0.2.1/24 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" 192.0.2.1/24 2001:db8:1::1/64 In bridge_igmp.sh line 65: simple_if_init $h2 192.0.2.2/24 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/24 2001:db8:1::2/64 In bridge_igmp.sh line 68: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 70: simple_if_fini $h2 192.0.2.2/24 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" 192.0.2.2/24 2001:db8:1::2/64 In bridge_igmp.sh line 77: ip link set dev $swp1 master br0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br0 In bridge_igmp.sh line 78: ip link set dev $swp2 master br0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" master br0 In bridge_igmp.sh line 81: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In bridge_igmp.sh line 82: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In bridge_igmp.sh line 85: switch_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 87: ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" down In bridge_igmp.sh line 88: ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" down In bridge_igmp.sh line 110: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 122: check_binary() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 125: local args=$@ ^-- SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. In bridge_igmp.sh line 129: return $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$EXIT_STATUS" In bridge_igmp.sh line 133: tcpdump_show_with_filter() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 136: local filter=$@ ^-- SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. In bridge_igmp.sh line 138: tcpdump -e -n -r ${capfile[$if_name]} "$filter" 2>&1 ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump -e -n -r "${capfile[$if_name]}" "$filter" 2>&1 In bridge_igmp.sh line 141: validate_query() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 151: check_binary "./mc_encode" $msg || return 1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_binary "./mc_encode" "$msg" || return 1 In bridge_igmp.sh line 155: field_val=$(tshark -r ${capfile[$if_name]} -Y "igmp.type==0x11" \ ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: field_val=$(tshark -r "${capfile[$if_name]}" -Y "igmp.type==0x11" \ In bridge_igmp.sh line 159: field_val=$(tshark -r ${capfile[$if_name]} -Y "igmp.type==0x11" \ ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: field_val=$(tshark -r "${capfile[$if_name]}" -Y "igmp.type==0x11" \ In bridge_igmp.sh line 163: local enc_val=$(./mc_encode $value) ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local enc_val=$(./mc_encode "$value") In bridge_igmp.sh line 166: tcpdump_show_with_filter $if_name $pattern | grep -q "igmp query v3" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_show_with_filter "$if_name" "$pattern" | grep -q "igmp query v3" In bridge_igmp.sh line 168: if [ "$field_val" != "" -a $ret -ne 0 ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$field_val" != "" -a "$ret" -ne 0 ]; then In bridge_igmp.sh line 171: check_err $ret "$opt_str" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$ret" "$opt_str" In bridge_igmp.sh line 176: v3query_mrc_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 184: mcast_query_response_interval $br_qri \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mcast_query_response_interval "$br_qri" \ In bridge_igmp.sh line 189: tcpdump_start $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_start "$h2" In bridge_igmp.sh line 192: tcpdump_stop $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_stop "$h2" In bridge_igmp.sh line 194: validate_query $h2 "MRC" $qri_val ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_query "$h2" "MRC" "$qri_val" In bridge_igmp.sh line 195: tcpdump_cleanup $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_cleanup "$h2" In bridge_igmp.sh line 202: v3query_qqic_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 209: ip link set dev br0 type bridge mcast_query_interval $br_qqi \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br0 type bridge mcast_query_interval "$br_qqi" \ In bridge_igmp.sh line 215: tcpdump_start $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_start "$h2" In bridge_igmp.sh line 218: tcpdump_stop $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_stop "$h2" In bridge_igmp.sh line 220: validate_query $h2 "QQIC" $qqi_val ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_query "$h2" "QQIC" "$qqi_val" In bridge_igmp.sh line 221: tcpdump_cleanup $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump_cleanup "$h2" In bridge_igmp.sh line 228: v2reportleave_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 231: ip address add dev $h2 $TEST_GROUP/32 autojoin ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$h2" "$TEST_GROUP"/32 autojoin In bridge_igmp.sh line 235: bridge mdb show dev br0 | grep $TEST_GROUP 1>/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb show dev br0 | grep "$TEST_GROUP" 1>/dev/null In bridge_igmp.sh line 238: mcast_packet_test $TEST_GROUP_MAC 192.0.2.1 $TEST_GROUP $h1 $h2 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mcast_packet_test "$TEST_GROUP_MAC" 192.0.2.1 "$TEST_GROUP" "$h1" "$h2" In bridge_igmp.sh line 244: bridge mdb show dev br0 | grep $TEST_GROUP 1>/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb show dev br0 | grep "$TEST_GROUP" 1>/dev/null In bridge_igmp.sh line 247: ip address del dev $h2 $TEST_GROUP/32 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address del dev "$h2" "$TEST_GROUP"/32 In bridge_igmp.sh line 251: bridge mdb show dev br0 | grep $TEST_GROUP 1>/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb show dev br0 | grep "$TEST_GROUP" 1>/dev/null In bridge_igmp.sh line 254: mcast_packet_test $TEST_GROUP_MAC 192.0.2.1 $TEST_GROUP $h1 $h2 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mcast_packet_test "$TEST_GROUP_MAC" 192.0.2.1 "$TEST_GROUP" "$h1" "$h2" In bridge_igmp.sh line 260: v3include_prepare() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 270: $MZ $host1_if -b $mac -c 1 -B $group -t ip "proto=2,p=$MZPKT_IS_INC" -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -b "$mac" -c 1 -B "$group" -t ip "proto=2,p=$MZPKT_IS_INC" -q In bridge_igmp.sh line 284: v3exclude_prepare() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 289: local pkt=$4 ^-^ SC2034 (warning): pkt appears unused. Verify use (or export if used externally). In bridge_igmp.sh line 293: v3include_prepare $host1_if $mac $group ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$host1_if" "$mac" "$group" In bridge_igmp.sh line 295: $MZ $host1_if -c 1 -b $mac -B $group -t ip "proto=2,p=$MZPKT_IS_EXC" -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -b "$mac" -B "$group" -t ip "proto=2,p=$MZPKT_IS_EXC" -q In bridge_igmp.sh line 316: v3cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 321: bridge mdb del dev br0 port $port grp $group ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge mdb del dev br0 port "$port" grp "$group" In bridge_igmp.sh line 325: v3include_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 330: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 339: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 342: v3inc_allow_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 347: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 349: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_ALLOW" -q In bridge_igmp.sh line 360: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 363: v3inc_is_include_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 368: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 370: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_INC2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_INC2" -q In bridge_igmp.sh line 381: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 384: v3inc_is_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 388: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 395: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 398: v3inc_to_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 404: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 409: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_TO_EXC" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_TO_EXC" -q In bridge_igmp.sh line 442: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 445: v3exc_allow_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 451: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 453: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_ALLOW2" -q In bridge_igmp.sh line 465: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 468: v3exc_is_include_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 474: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 476: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_INC3" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_INC3" -q In bridge_igmp.sh line 488: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 491: v3exc_is_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 497: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 499: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_EXC2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_EXC2" -q In bridge_igmp.sh line 511: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 514: v3exc_to_exclude_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 520: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 525: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_TO_EXC" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_TO_EXC" -q In bridge_igmp.sh line 539: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 542: v3inc_block_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 547: v3include_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3include_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 549: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_BLOCK" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_BLOCK" -q In bridge_igmp.sh line 568: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 571: v3exc_block_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 577: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 582: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_BLOCK" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_BLOCK" -q In bridge_igmp.sh line 596: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 599: v3exc_timeout_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 609: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 614: $MZ $h1 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_ALLOW2" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_ALLOW2" -q In bridge_igmp.sh line 648: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 651: v3star_ex_auto_add_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 655: v3exclude_prepare $h1 $ALL_MAC $ALL_GROUP ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3exclude_prepare "$h1" "$ALL_MAC" "$ALL_GROUP" In bridge_igmp.sh line 657: $MZ $h2 -c 1 -b $ALL_MAC -B $ALL_GROUP -t ip "proto=2,p=$MZPKT_IS_INC" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h2" -c 1 -b "$ALL_MAC" -B "$ALL_GROUP" -t ip "proto=2,p=$MZPKT_IS_INC" -q In bridge_igmp.sh line 676: v3cleanup $swp1 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp1" "$TEST_GROUP" In bridge_igmp.sh line 677: v3cleanup $swp2 $TEST_GROUP ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: v3cleanup "$swp2" "$TEST_GROUP" In bridge_igmp.sh line 680: v2per_vlan_snooping_stp_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 698: [[ $is_port -eq 1 ]] && bridge link set dev $swp1 state 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -eq 1 ]] && bridge link set dev "$swp1" state 0 In bridge_igmp.sh line 699: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev $swp1 state 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev "$swp1" state 4 In bridge_igmp.sh line 701: local tx_s=$(ip -j -p stats show dev $swp1 \ ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tx_s=$(ip -j -p stats show dev "$swp1" \ In bridge_igmp.sh line 705: [[ $is_port -eq 1 ]] && bridge link set dev $swp1 state 3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -eq 1 ]] && bridge link set dev "$swp1" state 3 In bridge_igmp.sh line 706: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev $swp1 state 3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [[ $is_port -ne 1 ]] && bridge vlan set vid 1 dev "$swp1" state 3 In bridge_igmp.sh line 708: local tx_e=$(ip -j -p stats show dev $swp1 \ ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tx_e=$(ip -j -p stats show dev "$swp1" \ In bridge_igmp.sh line 713: local tx=$(expr $tx_e - $tx_s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tx=$(expr "$tx_e" - "$tx_s") In bridge_igmp.sh line 714: test $tx -gt 0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$tx" -gt 0 In bridge_igmp.sh line 728: v2per_vlan_snooping_port_stp_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 733: v2per_vlan_snooping_vlan_stp_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_igmp.sh line 745: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- pkt appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...