====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.wcOn9wht1q 2026-03-30 16:06:49.678908152 -0400 +++ /tmp/tmp.2j3qBuO0Mk 2026-03-30 16:06:50.837899800 -0400 @@ -2 +2 @@ -In bridge_igmp.sh line 53: +In bridge_igmp.sh line 55: @@ -10 +10 @@ -In bridge_igmp.sh line 56: +In bridge_igmp.sh line 58: @@ -15 +15 @@ -In bridge_igmp.sh line 58: +In bridge_igmp.sh line 60: @@ -23 +23 @@ -In bridge_igmp.sh line 63: +In bridge_igmp.sh line 65: @@ -31 +31 @@ -In bridge_igmp.sh line 66: +In bridge_igmp.sh line 68: @@ -36 +36 @@ -In bridge_igmp.sh line 68: +In bridge_igmp.sh line 70: @@ -44 +44 @@ -In bridge_igmp.sh line 75: +In bridge_igmp.sh line 77: @@ -52 +52 @@ -In bridge_igmp.sh line 76: +In bridge_igmp.sh line 78: @@ -60 +60 @@ -In bridge_igmp.sh line 79: +In bridge_igmp.sh line 81: @@ -68 +68 @@ -In bridge_igmp.sh line 80: +In bridge_igmp.sh line 82: @@ -76 +76 @@ -In bridge_igmp.sh line 83: +In bridge_igmp.sh line 85: @@ -81 +81 @@ -In bridge_igmp.sh line 85: +In bridge_igmp.sh line 87: @@ -89 +89 @@ -In bridge_igmp.sh line 86: +In bridge_igmp.sh line 88: @@ -97 +97 @@ -In bridge_igmp.sh line 107: +In bridge_igmp.sh line 110: @@ -102 +102,193 @@ -In bridge_igmp.sh line 119: +In bridge_igmp.sh line 122: +check_binary() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In bridge_igmp.sh line 125: + local args=$@ + ^-- SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. + + +In bridge_igmp.sh line 129: + return $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + return "$EXIT_STATUS" + + +In bridge_igmp.sh line 133: +tcpdump_show_with_filter() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In bridge_igmp.sh line 136: + local filter=$@ + ^-- SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. + + +In bridge_igmp.sh line 138: + tcpdump -e -n -r ${capfile[$if_name]} "$filter" 2>&1 + ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump -e -n -r "${capfile[$if_name]}" "$filter" 2>&1 + + +In bridge_igmp.sh line 141: +validate_query() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In bridge_igmp.sh line 151: + check_binary "./mc_encode" $msg || return 1 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_binary "./mc_encode" "$msg" || return 1 + + +In bridge_igmp.sh line 155: + field_val=$(tshark -r ${capfile[$if_name]} -Y "igmp.type==0x11" \ + ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + field_val=$(tshark -r "${capfile[$if_name]}" -Y "igmp.type==0x11" \ + + +In bridge_igmp.sh line 159: + field_val=$(tshark -r ${capfile[$if_name]} -Y "igmp.type==0x11" \ + ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + field_val=$(tshark -r "${capfile[$if_name]}" -Y "igmp.type==0x11" \ + + +In bridge_igmp.sh line 163: + local enc_val=$(./mc_encode $value) + ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local enc_val=$(./mc_encode "$value") + + +In bridge_igmp.sh line 166: + tcpdump_show_with_filter $if_name $pattern | grep -q "igmp query v3" + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_show_with_filter "$if_name" "$pattern" | grep -q "igmp query v3" + + +In bridge_igmp.sh line 168: + if [ "$field_val" != "" -a $ret -ne 0 ]; then + ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$field_val" != "" -a "$ret" -ne 0 ]; then + + +In bridge_igmp.sh line 171: + check_err $ret "$opt_str" + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_err "$ret" "$opt_str" + + +In bridge_igmp.sh line 176: +v3query_mrc_test() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In bridge_igmp.sh line 184: + mcast_query_response_interval $br_qri \ + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + mcast_query_response_interval "$br_qri" \ + + +In bridge_igmp.sh line 189: + tcpdump_start $h2 + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_start "$h2" + + +In bridge_igmp.sh line 192: + tcpdump_stop $h2 + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_stop "$h2" + + +In bridge_igmp.sh line 194: + validate_query $h2 "MRC" $qri_val + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + validate_query "$h2" "MRC" "$qri_val" + + +In bridge_igmp.sh line 195: + tcpdump_cleanup $h2 + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_cleanup "$h2" + + +In bridge_igmp.sh line 202: +v3query_qqic_test() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In bridge_igmp.sh line 209: + ip link set dev br0 type bridge mcast_query_interval $br_qqi \ + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set dev br0 type bridge mcast_query_interval "$br_qqi" \ + + +In bridge_igmp.sh line 215: + tcpdump_start $h2 + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_start "$h2" + + +In bridge_igmp.sh line 218: + tcpdump_stop $h2 + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_stop "$h2" + + +In bridge_igmp.sh line 220: + validate_query $h2 "QQIC" $qqi_val + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + validate_query "$h2" "QQIC" "$qqi_val" + + +In bridge_igmp.sh line 221: + tcpdump_cleanup $h2 + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tcpdump_cleanup "$h2" + + +In bridge_igmp.sh line 228: @@ -107 +299 @@ -In bridge_igmp.sh line 122: +In bridge_igmp.sh line 231: @@ -116 +308 @@ -In bridge_igmp.sh line 126: +In bridge_igmp.sh line 235: @@ -124 +316 @@ -In bridge_igmp.sh line 129: +In bridge_igmp.sh line 238: @@ -135 +327 @@ -In bridge_igmp.sh line 135: +In bridge_igmp.sh line 244: @@ -143 +335 @@ -In bridge_igmp.sh line 138: +In bridge_igmp.sh line 247: @@ -152 +344 @@ -In bridge_igmp.sh line 142: +In bridge_igmp.sh line 251: @@ -160 +352 @@ -In bridge_igmp.sh line 145: +In bridge_igmp.sh line 254: @@ -171 +363 @@ -In bridge_igmp.sh line 151: +In bridge_igmp.sh line 260: @@ -176 +368 @@ -In bridge_igmp.sh line 161: +In bridge_igmp.sh line 270: @@ -186 +378 @@ -In bridge_igmp.sh line 175: +In bridge_igmp.sh line 284: @@ -191 +383 @@ -In bridge_igmp.sh line 180: +In bridge_igmp.sh line 289: @@ -196 +388 @@ -In bridge_igmp.sh line 184: +In bridge_igmp.sh line 293: @@ -206 +398 @@ -In bridge_igmp.sh line 186: +In bridge_igmp.sh line 295: @@ -216 +408 @@ -In bridge_igmp.sh line 207: +In bridge_igmp.sh line 316: @@ -221 +413 @@ -In bridge_igmp.sh line 212: +In bridge_igmp.sh line 321: @@ -230 +422 @@ -In bridge_igmp.sh line 216: +In bridge_igmp.sh line 325: @@ -235 +427 @@ -In bridge_igmp.sh line 221: +In bridge_igmp.sh line 330: @@ -245 +437 @@ -In bridge_igmp.sh line 230: +In bridge_igmp.sh line 339: @@ -254 +446 @@ -In bridge_igmp.sh line 233: +In bridge_igmp.sh line 342: @@ -259 +451 @@ -In bridge_igmp.sh line 238: +In bridge_igmp.sh line 347: @@ -269 +461 @@ -In bridge_igmp.sh line 240: +In bridge_igmp.sh line 349: @@ -279 +471 @@ -In bridge_igmp.sh line 251: +In bridge_igmp.sh line 360: @@ -288 +480 @@ -In bridge_igmp.sh line 254: +In bridge_igmp.sh line 363: @@ -293 +485 @@ -In bridge_igmp.sh line 259: +In bridge_igmp.sh line 368: @@ -303 +495 @@ -In bridge_igmp.sh line 261: +In bridge_igmp.sh line 370: @@ -313 +505 @@ -In bridge_igmp.sh line 272: +In bridge_igmp.sh line 381: @@ -322 +514 @@ -In bridge_igmp.sh line 275: +In bridge_igmp.sh line 384: @@ -327 +519 @@ -In bridge_igmp.sh line 279: +In bridge_igmp.sh line 388: @@ -337 +529 @@ -In bridge_igmp.sh line 286: +In bridge_igmp.sh line 395: @@ -346 +538 @@ -In bridge_igmp.sh line 289: +In bridge_igmp.sh line 398: @@ -351 +543 @@ -In bridge_igmp.sh line 295: +In bridge_igmp.sh line 404: @@ -361 +553 @@ -In bridge_igmp.sh line 300: +In bridge_igmp.sh line 409: @@ -371 +563 @@ -In bridge_igmp.sh line 333: +In bridge_igmp.sh line 442: @@ -380 +572 @@ -In bridge_igmp.sh line 336: +In bridge_igmp.sh line 445: @@ -385 +577 @@ -In bridge_igmp.sh line 342: +In bridge_igmp.sh line 451: @@ -395 +587 @@ -In bridge_igmp.sh line 344: +In bridge_igmp.sh line 453: @@ -405 +597 @@ -In bridge_igmp.sh line 356: +In bridge_igmp.sh line 465: @@ -414 +606 @@ -In bridge_igmp.sh line 359: +In bridge_igmp.sh line 468: @@ -419 +611 @@ -In bridge_igmp.sh line 365: +In bridge_igmp.sh line 474: @@ -429 +621 @@ -In bridge_igmp.sh line 367: +In bridge_igmp.sh line 476: @@ -439 +631 @@ -In bridge_igmp.sh line 379: +In bridge_igmp.sh line 488: @@ -448 +640 @@ -In bridge_igmp.sh line 382: +In bridge_igmp.sh line 491: @@ -453 +645 @@ -In bridge_igmp.sh line 388: +In bridge_igmp.sh line 497: @@ -463 +655 @@ -In bridge_igmp.sh line 390: +In bridge_igmp.sh line 499: @@ -473 +665 @@ -In bridge_igmp.sh line 402: +In bridge_igmp.sh line 511: @@ -482 +674 @@ -In bridge_igmp.sh line 405: +In bridge_igmp.sh line 514: @@ -487 +679 @@ -In bridge_igmp.sh line 411: +In bridge_igmp.sh line 520: @@ -497 +689 @@ -In bridge_igmp.sh line 416: +In bridge_igmp.sh line 525: @@ -507 +699 @@ -In bridge_igmp.sh line 430: +In bridge_igmp.sh line 539: @@ -516 +708 @@ -In bridge_igmp.sh line 433: +In bridge_igmp.sh line 542: @@ -521 +713 @@ -In bridge_igmp.sh line 438: +In bridge_igmp.sh line 547: @@ -531 +723 @@ -In bridge_igmp.sh line 440: +In bridge_igmp.sh line 549: @@ -541 +733 @@ -In bridge_igmp.sh line 459: +In bridge_igmp.sh line 568: @@ -550 +742 @@ -In bridge_igmp.sh line 462: +In bridge_igmp.sh line 571: @@ -555 +747 @@ -In bridge_igmp.sh line 468: +In bridge_igmp.sh line 577: @@ -565 +757 @@ -In bridge_igmp.sh line 473: +In bridge_igmp.sh line 582: @@ -575 +767 @@ -In bridge_igmp.sh line 487: +In bridge_igmp.sh line 596: @@ -584 +776 @@ -In bridge_igmp.sh line 490: +In bridge_igmp.sh line 599: @@ -589 +781 @@ -In bridge_igmp.sh line 500: +In bridge_igmp.sh line 609: @@ -599 +791 @@ -In bridge_igmp.sh line 505: +In bridge_igmp.sh line 614: @@ -609 +801 @@ -In bridge_igmp.sh line 539: +In bridge_igmp.sh line 648: @@ -618 +810 @@ -In bridge_igmp.sh line 542: +In bridge_igmp.sh line 651: @@ -623 +815 @@ -In bridge_igmp.sh line 546: +In bridge_igmp.sh line 655: @@ -633 +825 @@ -In bridge_igmp.sh line 548: +In bridge_igmp.sh line 657: @@ -643 +835 @@ -In bridge_igmp.sh line 567: +In bridge_igmp.sh line 676: @@ -652 +844 @@ -In bridge_igmp.sh line 568: +In bridge_igmp.sh line 677: @@ -661 +853 @@ -In bridge_igmp.sh line 571: +In bridge_igmp.sh line 680: @@ -666 +858 @@ -In bridge_igmp.sh line 589: +In bridge_igmp.sh line 698: @@ -674 +866 @@ -In bridge_igmp.sh line 590: +In bridge_igmp.sh line 699: @@ -682 +874 @@ -In bridge_igmp.sh line 592: +In bridge_igmp.sh line 701: @@ -691 +883 @@ -In bridge_igmp.sh line 596: +In bridge_igmp.sh line 705: @@ -699 +891 @@ -In bridge_igmp.sh line 597: +In bridge_igmp.sh line 706: @@ -707 +899 @@ -In bridge_igmp.sh line 599: +In bridge_igmp.sh line 708: @@ -716 +908 @@ -In bridge_igmp.sh line 604: +In bridge_igmp.sh line 713: @@ -727 +919 @@ -In bridge_igmp.sh line 605: +In bridge_igmp.sh line 714: @@ -735 +927 @@ -In bridge_igmp.sh line 619: +In bridge_igmp.sh line 728: @@ -740 +932 @@ -In bridge_igmp.sh line 624: +In bridge_igmp.sh line 733: @@ -745 +937 @@ -In bridge_igmp.sh line 636: +In bridge_igmp.sh line 745: @@ -753,0 +946 @@ + https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A... @@ -755 +947,0 @@ - https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...