WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead #62: FILE: tools/testing/selftests/net/forwarding/bridge_igmp.sh:2: # SPDX-License-Identifier: GPL-2.0 WARNING: line length of 81 exceeds 80 columns #115: FILE: tools/testing/selftests/net/forwarding/bridge_igmp.sh:155: + field_val=$(tshark -r ${capfile[$if_name]} -Y "igmp.type==0x11" \ WARNING: line length of 81 exceeds 80 columns #119: FILE: tools/testing/selftests/net/forwarding/bridge_igmp.sh:159: + field_val=$(tshark -r ${capfile[$if_name]} -Y "igmp.type==0x11" \ WARNING: please, no spaces at the start of a line #214: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:18: + if (code < IGMPV3_EXP_MIN_THRESHOLD) {$ ERROR: code indent should use tabs where possible #215: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:19: + return (unsigned long)code;$ WARNING: please, no spaces at the start of a line #215: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:19: + return (unsigned long)code;$ WARNING: please, no spaces at the start of a line #216: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:20: + } else {$ ERROR: code indent should use tabs where possible #217: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:21: + unsigned long mc_man, mc_exp;$ WARNING: please, no spaces at the start of a line #217: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:21: + unsigned long mc_man, mc_exp;$ ERROR: code indent should use tabs where possible #218: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:22: + mc_exp = IGMPV3_FP_EXP(code);$ WARNING: Missing a blank line after declarations #218: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:22: + unsigned long mc_man, mc_exp; + mc_exp = IGMPV3_FP_EXP(code); WARNING: please, no spaces at the start of a line #218: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:22: + mc_exp = IGMPV3_FP_EXP(code);$ ERROR: code indent should use tabs where possible #219: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:23: + mc_man = IGMPV3_FP_MAN(code);$ WARNING: please, no spaces at the start of a line #219: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:23: + mc_man = IGMPV3_FP_MAN(code);$ ERROR: code indent should use tabs where possible #220: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:24: + return ((mc_man | 0x10) << (mc_exp + 3));$ WARNING: please, no spaces at the start of a line #220: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:24: + return ((mc_man | 0x10) << (mc_exp + 3));$ WARNING: please, no spaces at the start of a line #221: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:25: + }$ WARNING: please, no spaces at the start of a line #226: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:30: + uint8_t qqic = 0;$ WARNING: Missing a blank line after declarations #227: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:31: + uint8_t qqic = 0; + if (argc >= 2) WARNING: please, no spaces at the start of a line #227: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:31: + if (argc >= 2)$ ERROR: code indent should use tabs where possible #228: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:32: + qqic = atoi(argv[1]);$ WARNING: please, no spaces at the start of a line #228: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:32: + qqic = atoi(argv[1]);$ WARNING: please, no spaces at the start of a line #229: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:33: + unsigned long qqi = decode_field(qqic);$ WARNING: please, no spaces at the start of a line #231: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:35: + printf("%lu\n", qqi);$ WARNING: please, no spaces at the start of a line #233: FILE: tools/testing/selftests/net/forwarding/mc_decode.c:37: + return 0;$ WARNING: please, no spaces at the start of a line #253: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:13: + uint8_t mc_exp, mc_man;$ WARNING: please, no spaces at the start of a line #256: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:16: + if (value < IGMPV3_EXP_MIN_THRESHOLD)$ ERROR: code indent should use tabs where possible #257: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:17: + return (uint8_t)value;$ WARNING: please, no spaces at the start of a line #257: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:17: + return (uint8_t)value;$ WARNING: please, no spaces at the start of a line #260: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:20: + if (value >= IGMPV3_EXP_MAX_THRESHOLD)$ ERROR: code indent should use tabs where possible #261: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:21: + return 0xFF;$ WARNING: please, no spaces at the start of a line #261: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:21: + return 0xFF;$ WARNING: please, no spaces at the start of a line #263: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:23: + mc_exp = (uint8_t)(fls(value) - 8);$ WARNING: please, no spaces at the start of a line #264: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:24: + mc_man = (uint8_t)((value >> (mc_exp + 3)) & 0x0F);$ WARNING: please, no spaces at the start of a line #266: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:26: + return 0x80 | (mc_exp << 4) | mc_man;$ WARNING: please, no spaces at the start of a line #271: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:31: + unsigned int qqi = 0;$ WARNING: Missing a blank line after declarations #272: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:32: + unsigned int qqi = 0; + if (argc >= 2) WARNING: please, no spaces at the start of a line #272: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:32: + if (argc >= 2)$ ERROR: code indent should use tabs where possible #273: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:33: + qqi = atoi(argv[1]);$ WARNING: please, no spaces at the start of a line #273: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:33: + qqi = atoi(argv[1]);$ WARNING: please, no spaces at the start of a line #275: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:35: + uint8_t qqic = encode_field(qqi);$ WARNING: please, no spaces at the start of a line #277: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:37: + printf("%u\n", qqic);$ WARNING: please, no spaces at the start of a line #279: FILE: tools/testing/selftests/net/forwarding/mc_encode.c:39: + return 0;$ total: 9 errors, 34 warnings, 0 checks, 225 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit a26ecc2b67b7 ("selftests: net: bridge: add tests for igmpv3 MRC and QQIC validation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.