WARNING: else is not generally useful after a break or return #77: FILE: include/linux/igmp.h:135: + return (unsigned long)code; + } else { CHECK: spaces preferred around that '*' (ctx:VxV) #133: FILE: net/ipv4/igmp.c:994: + max_delay = igmpv3_mrt(ih3)*(HZ/IGMP_TIMER_SCALE); ^ CHECK: spaces preferred around that '/' (ctx:VxV) #133: FILE: net/ipv4/igmp.c:994: + max_delay = igmpv3_mrt(ih3)*(HZ/IGMP_TIMER_SCALE); ^ CHECK: spaces preferred around that '*' (ctx:VxV) #142: FILE: net/ipv4/igmp.c:1009: + max_delay = igmpv3_mrt(ih3)*(HZ/IGMP_TIMER_SCALE); ^ CHECK: spaces preferred around that '/' (ctx:VxV) #142: FILE: net/ipv4/igmp.c:1009: + max_delay = igmpv3_mrt(ih3)*(HZ/IGMP_TIMER_SCALE); ^ CHECK: spaces preferred around that '*' (ctx:VxV) #151: FILE: net/ipv4/igmp.c:1019: + in_dev->mr_qi = igmpv3_qqi(ih3)*HZ ?: IGMP_QUERY_INTERVAL; ^ total: 0 errors, 1 warnings, 5 checks, 117 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c17d4f9bcae4 ("ipv4: igmp: get rid of IGMPV3_{QQIC,MRC} and simplify calculation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 5 checks, 117 lines checked